Added integration with the image-builder kubevirt image by isaacdorfman · Pull Request #108 · kubernetes-sigs/cluster-api-provider-kubevirt

isaacdorfman · 2022-03-07T12:46:04Z

What this PR does / why we need it:
I created a kubevirt target in my fork of the image-builder project:
https://github.com/isaacdorfman/image-builder/tree/kubevirt-target

This image is the image of the machines in the cluster.
I pushed the image I built in my image-builder fork into quay and updated the capk to use this image instead of the kubevirtci one.
In this PR I also fixed the problems that this change caused.
*I also fixed a problem with the local container reigstry by changing the url of the registry from localhost to 127.0.0.1, this caused problems related to ipv6 in some devices.
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release notes:

coveralls · 2022-03-07T12:47:51Z

Pull Request Test Coverage Report for Build 2233042500

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 46.035%

Totals
Change from base Build 2169614395:	0.0%
Covered Lines:	714
Relevant Lines:	1551

💛 - Coveralls

davidvossel · 2022-03-08T16:16:53Z

/ok-to-test

isaacdorfman · 2022-03-09T09:49:41Z

/retest

davidvossel · 2022-03-09T19:22:33Z

https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubernetes-sigs_cluster-api-provider-kubevirt/108/pull-kubernetes-sigs-cluster-api-provider-kubevirt-e2e/1501230590018457600

• Failure [620.180 seconds]
CreateCluster
/home/prow/go/src/github.com/kubernetes-sigs/cluster-api-provider-kubevirt/e2e-tests/create-cluster_test.go:30
  creating a simple cluster with persistent VMs [It]
  /home/prow/go/src/github.com/kubernetes-sigs/cluster-api-provider-kubevirt/e2e-tests/create-cluster_test.go:361
  Timed out after 600.000s.
      
  cluster should have control plane initialized
  Expected success, but got an error:
      <*errors.errorString | 0xc000913130>: {
          s: "still waiting on controlPlaneInitialized condition to be true",
      }
      still waiting on controlPlaneInitialized condition to be true
  /home/prow/go/src/github.com/kubernetes-sigs/cluster-api-provider-kubevirt/e2e-tests/create-cluster_test.go:257
------------------------------

It looks like the control plane didn't start up successfully using this image.

davidvossel · 2022-03-09T19:24:00Z

ah, but it was only the creating a simple cluster with persistent VMs [It] test that failed. The others passed! so that's a great initial starting point. Just investigate why that one test creating a simple cluster with persistent VMs [It] is failing. Maybe you can reproduce this locally?

davidvossel · 2022-03-16T16:01:20Z

/retest

isaacdorfman · 2022-03-20T14:14:51Z

/retest

isaacdorfman · 2022-03-20T14:16:16Z

/help

nirarg · 2022-03-31T06:14:05Z

 	sigs.k8s.io/cluster-api v0.3.11-0.20210525210043-6c7878e7b4a9
 	sigs.k8s.io/controller-runtime v0.11.0-beta.0.0.20211110210527-619e6b92dab9
 	sigs.k8s.io/kind v0.11.0
+	sigs.k8s.io/yaml v1.3.0


Please remove this change, as it does nothing

isaacdorfman · 2022-04-04T15:29:56Z

/retest

davidvossel · 2022-04-05T19:57:45Z

/hold cancel

sorry, you'll have to rebase. my pr went in

davidvossel · 2022-04-05T19:58:44Z

this PR #126 will impact you as well. Make sure to alter the env vars that are moved to hack/functest.sh

davidvossel · 2022-04-26T15:04:42Z

/retest
/lgtm

davidvossel · 2022-04-26T15:04:54Z

/hold

waiting for ci to pass

davidvossel

/lgtm cancel

nirarg · 2022-04-27T12:41:42Z

/lgtm

davidvossel

/lgtm

k8s-ci-robot · 2022-04-27T15:48:13Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidvossel, isaacdorfman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [davidvossel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

davidvossel · 2022-04-27T15:48:15Z

/hold cancel

Release-4.18 sync with upstream 2025-01-17

k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 7, 2022

k8s-ci-robot requested review from justinsb and timothysc March 7, 2022 12:46

k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 7, 2022

k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Mar 8, 2022

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 16, 2022

isaacdorfman force-pushed the image-builder-integration branch 3 times, most recently from b1cb599 to 954b224 Compare March 30, 2022 10:57

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 30, 2022

isaacdorfman changed the title ~~WIP: added integration with the image-builder kubevirt image~~ Added integration with the image-builder kubevirt image Mar 30, 2022

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 30, 2022

isaacdorfman commented Mar 30, 2022

View reviewed changes

Comment thread Makefile

nirarg reviewed Mar 31, 2022

View reviewed changes

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 4, 2022

isaacdorfman force-pushed the image-builder-integration branch from 3b4c29a to b74d3ea Compare April 4, 2022 15:31

davidvossel mentioned this pull request Apr 4, 2022

Switch to using rook-ceph for e2e storage class #127

Merged

k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Apr 5, 2022

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 25, 2022

nirarg mentioned this pull request Apr 26, 2022

Clusterctl integration #113

Merged

isaacdorfman force-pushed the image-builder-integration branch from 446082f to e4c5a34 Compare April 26, 2022 08:25

k8s-ci-robot assigned davidvossel Apr 26, 2022

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 26, 2022

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 26, 2022

davidvossel reviewed Apr 26, 2022

View reviewed changes

Comment thread e2e/create-cluster_test.go Outdated

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 26, 2022

isaacdorfman force-pushed the image-builder-integration branch from e4c5a34 to db983f4 Compare April 27, 2022 11:48

isaacdorfman mentioned this pull request Apr 27, 2022

Changed capk makefile target from functest to functest-ubuntu kubevirt/project-infra#2057

Closed

added integration with the image-builder kubevirt image

9d7d45d

isaacdorfman force-pushed the image-builder-integration branch from db983f4 to 9d7d45d Compare April 27, 2022 12:26

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 27, 2022

k8s-ci-robot assigned nirarg Apr 27, 2022

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 27, 2022

davidvossel approved these changes Apr 27, 2022

View reviewed changes

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 27, 2022

k8s-ci-robot merged commit 5850b33 into kubernetes-sigs:main Apr 27, 2022

nirarg mentioned this pull request May 2, 2022

Add capk image build process #84

Closed

nunnatsa added a commit to nunnatsa/cluster-api-provider-kubevirt that referenced this pull request Mar 11, 2025

Merge pull request kubernetes-sigs#108 from nunnatsa/r418-sync-with-us

5375958

Release-4.18 sync with upstream 2025-01-17

Conversation

isaacdorfman commented Mar 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coveralls commented Mar 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Test Coverage Report for Build 2233042500

💛 - Coveralls

Uh oh!

davidvossel commented Mar 8, 2022

Uh oh!

isaacdorfman commented Mar 9, 2022

Uh oh!

davidvossel commented Mar 9, 2022

Uh oh!

davidvossel commented Mar 9, 2022

Uh oh!

davidvossel commented Mar 16, 2022

Uh oh!

isaacdorfman commented Mar 20, 2022

Uh oh!

isaacdorfman commented Mar 20, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nirarg Mar 31, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

isaacdorfman commented Apr 4, 2022

Uh oh!

davidvossel commented Apr 5, 2022

Uh oh!

davidvossel commented Apr 5, 2022

Uh oh!

davidvossel commented Apr 26, 2022

Uh oh!

davidvossel commented Apr 26, 2022

Uh oh!

davidvossel left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

nirarg commented Apr 27, 2022

Uh oh!

davidvossel left a comment

Choose a reason for hiding this comment

Uh oh!

k8s-ci-robot commented Apr 27, 2022

Uh oh!

davidvossel commented Apr 27, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

isaacdorfman commented Mar 7, 2022 •

edited

Loading

coveralls commented Mar 7, 2022 •

edited

Loading