Clusterctl integration by isaacdorfman · Pull Request #113 · kubernetes-sigs/cluster-api-provider-kubevirt

isaacdorfman · 2022-03-15T13:02:31Z

What this PR does / why we need it:
In order to use capk with clusterctl, i.e: "clusterctl init", "clusterctl generate", the github repo must contain a release with manifests in the form specified by the clusterctl.
https://cluster-api.sigs.k8s.io/clusterctl/provider-contract.html

This PR is intended to create a github action that creates such release each time a PR is merged into the main branch.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release notes:

coveralls · 2022-03-15T13:04:39Z

Pull Request Test Coverage Report for Build 2301198525

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.1%) to 45.93%

Totals
Change from base Build 2256884798:	-0.1%
Covered Lines:	711
Relevant Lines:	1548

💛 - Coveralls

davidvossel · 2022-03-22T14:55:51Z

/ok-to-test

isaacdorfman · 2022-04-25T12:31:40Z

/retest

nirarg

Its look like this PR include also changes from image builder PR (#108)
Please change it to include only relevant changes to this PR

isaacdorfman · 2022-04-27T11:49:38Z

@davidvossel
I created a new makefile target called "functest-ubuntu" which uses environment variables that are relevant to the new image.
I need a way for the CI to invoke this target instead of the old one.

nirarg

You added two files named infrastructure-components.yaml, one under the root directory and one empty under config/manager
I guess this is mistake, please check

nirarg · 2022-05-03T14:21:07Z

/lgtm

davidvossel · 2022-05-03T14:25:49Z

related to #101

davidvossel

looks great, i just had some minor comments.

davidvossel · 2022-05-09T21:26:44Z

@@ -0,0 +1,5464 @@
+apiVersion: v1


so we need to have this infrastructure-components.yaml in the source tree, or do we just need it uploaded as an asset to the release?

if we need it in the source tree, then we need something (a CI job) to ensure it's always up-to-date. If we don't need this yaml for the quickstart in the source tree itself, then i say we don't commit it and only upload it in it's generated form to the github release.

It only needs to be in the release.

Deleted and gitignored it.

davidvossel · 2022-05-09T21:27:53Z

/retest

davidvossel · 2022-05-09T21:28:42Z

/hold

i'm trying to trigger e2e tests again.

davidvossel · 2022-05-09T21:28:49Z

/hold cancel

for some reason holding and unholding triggers the e2e test due to the label change on the PR

nirarg · 2022-05-10T07:20:05Z

/lgtm

davidvossel

/lgtm
/approve

k8s-ci-robot · 2022-05-10T14:15:14Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidvossel, isaacdorfman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [davidvossel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 15, 2022

k8s-ci-robot requested review from justinsb and timothysc March 15, 2022 13:02

k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 15, 2022

k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Mar 22, 2022

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 6, 2022

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 24, 2022

isaacdorfman force-pushed the clusterctl-integration branch from 21e9d88 to 95abf49 Compare April 25, 2022 12:03

isaacdorfman changed the title ~~WIP: Clusterctl integration~~ Clusterctl integration Apr 25, 2022

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 25, 2022

isaacdorfman force-pushed the clusterctl-integration branch from 95abf49 to ad3520e Compare April 25, 2022 12:55

nirarg reviewed Apr 26, 2022

View reviewed changes

Comment thread .github/workflows/create_release.yaml Outdated

Comment thread Makefile Outdated

Comment thread Makefile Outdated

Comment thread e2e/create-cluster_test.go Outdated

isaacdorfman force-pushed the clusterctl-integration branch 2 times, most recently from a0fd18c to 9a8e0a9 Compare April 27, 2022 11:45

isaacdorfman force-pushed the clusterctl-integration branch 3 times, most recently from 56bcf15 to a744567 Compare May 2, 2022 10:03

nirarg reviewed May 2, 2022

View reviewed changes

Comment thread e2e/create-cluster_test.go Outdated

Comment thread config/manager/kustomization.yaml Outdated

isaacdorfman force-pushed the clusterctl-integration branch from a744567 to eb7e714 Compare May 2, 2022 12:18

nirarg reviewed May 2, 2022

View reviewed changes

isaacdorfman force-pushed the clusterctl-integration branch 2 times, most recently from 1e703a7 to 16826aa Compare May 3, 2022 13:18

k8s-ci-robot assigned nirarg May 3, 2022

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 3, 2022

davidvossel reviewed May 3, 2022

View reviewed changes

Comment thread infrastructure-components.yaml Outdated

davidvossel mentioned this pull request May 3, 2022

Add quickstart example in README #36

Closed

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 8, 2022

isaacdorfman force-pushed the clusterctl-integration branch 3 times, most recently from 10271f2 to 0fcf17b Compare May 9, 2022 15:15

davidvossel reviewed May 9, 2022

View reviewed changes

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 9, 2022

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 9, 2022

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 10, 2022

Isaac Dorfman added 2 commits May 10, 2022 17:08

clusterctl integration

e5c71d0

Fixed a linting problem

7f597e1

isaacdorfman force-pushed the clusterctl-integration branch from 0fcf17b to 7f597e1 Compare May 10, 2022 14:08

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 10, 2022

davidvossel approved these changes May 10, 2022

View reviewed changes

k8s-ci-robot assigned davidvossel May 10, 2022

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 10, 2022

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 10, 2022

k8s-ci-robot merged commit 879a4cb into kubernetes-sigs:main May 10, 2022

isaacdorfman mentioned this pull request Jun 1, 2022

Add clusterctl init intergration #101

Closed

Conversation

isaacdorfman commented Mar 15, 2022

Uh oh!

coveralls commented Mar 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Test Coverage Report for Build 2301198525

💛 - Coveralls

Uh oh!

davidvossel commented Mar 22, 2022

Uh oh!

isaacdorfman commented Apr 25, 2022

Uh oh!

nirarg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

isaacdorfman commented Apr 27, 2022

Uh oh!

Uh oh!

Uh oh!

nirarg left a comment

Choose a reason for hiding this comment

Uh oh!

nirarg commented May 3, 2022

Uh oh!

davidvossel commented May 3, 2022

Uh oh!

Uh oh!

davidvossel left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

davidvossel May 9, 2022

Choose a reason for hiding this comment

Uh oh!

isaacdorfman May 9, 2022

Choose a reason for hiding this comment

Uh oh!

isaacdorfman May 10, 2022

Choose a reason for hiding this comment

Uh oh!

davidvossel commented May 9, 2022

Uh oh!

davidvossel commented May 9, 2022

Uh oh!

davidvossel commented May 9, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nirarg commented May 10, 2022

Uh oh!

davidvossel left a comment

Choose a reason for hiding this comment

Uh oh!

k8s-ci-robot commented May 10, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

coveralls commented Mar 15, 2022 •

edited

Loading

davidvossel commented May 9, 2022 •

edited

Loading