WIP: Power VS: Create LB DNS records in IBM DNS for private clusters #142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjturek
force-pushed
the
use-ibm-dns-for-private
branch
3 times, most recently
from
edba468 to
9176c2b
Compare
IBMCloud: BYON Enablement
We want to get the first static IP address, not the IP address of the first interface.
…fied Numerous places assume that there will be at least one NMStateConfig: * https://bugzilla.redhat.com/show_bug.cgi?id=2116489 * https://bugzilla.redhat.com/show_bug.cgi?id=2115770 * https://bugzilla.redhat.com/show_bug.cgi?id=2115798 * https://bugzilla.redhat.com/show_bug.cgi?id=2115803 * https://bugzilla.redhat.com/show_bug.cgi?id=2117302 Since these are not easily discoverable by users, temporarily reinstate the requirement that at least one NMState configuration be provided (even if the RendezvousIP is specified). This will provide users with an upfront error rather than a difficult-to-debug mystery.
A shared mutex for all ibmcloud.metadata functions, including the public Client method, deadlocks calls. Since the Client is a public method, we should still use a mutex, but it should be a unique mutex to prevent deadlocking.
AGENT-246: Temporarily require at least one NMStateConfig to be specified
Bug 2109800: IBMCloud: Allow metrics traffic
Bug 2115770: Check for RendezvousIP in Agent config if NMStateConfig is not provided
Collapse AgentConfig spec and add versioning
powervs: allow VPC, Cloud connection, and NW re-use
Handle cases when there is no ResourceGroupName provided during destroy, or the ResourceGroup doesn't exist, or cannot be found. Related: https://bugzilla.redhat.com/show_bug.cgi?id=2061947
…ple-images Extract the image-references file from the release, pass it to `machine-config-operator`
** Pull the NetworkProjectID out of the installconfig and pass it to the cloud provider manifests ** Added tests for the new manifest information ** Added the network project ID to match that of https://github.com/openshift/origin/blob/57b52e0a9528027448422d678c4ef682dfc0b885/vendor/k8s.io/legacy-cloud-providers/gce/gce.go#L136 CORS-2037 Alated
If "none" is specified as platform, we should skip the terraform stages
extraction since terraform is not used in that case. Otherwise we'll get
the following panic:
```
panic: unsupported platform "none"
goroutine 1 [running]:
github.com/openshift/installer/pkg/terraform/stages/platform.StagesForPlatform({0x146f2d0a, 0x1619aa08})
/go/src/github.com/openshift/installer/pkg/terraform/stages/platform/stages.go:55 +0x2ff
main.runGatherBootstrapCmd({0x14d8e028, 0x1})
/go/src/github.com/openshift/installer/cmd/openshift-install/gather.go:115 +0x2d6
main.newGatherBootstrapCmd.func1(0xc001364500, {0xc0005a0b40, 0x2, 0x2})
/go/src/github.com/openshift/installer/cmd/openshift-install/gather.go:65 +0x59
github.com/spf13/cobra.(*Command).execute(0xc001364500, {0xc0005a0b20, 0x2, 0x2})
/go/src/github.com/openshift/installer/vendor/github.com/spf13/cobra/command.go:860 +0x5f8
github.com/spf13/cobra.(*Command).ExecuteC(0xc001334c80)
/go/src/github.com/openshift/installer/vendor/github.com/spf13/cobra/command.go:974 +0x3bc
github.com/spf13/cobra.(*Command).Execute(...)
/go/src/github.com/openshift/installer/vendor/github.com/spf13/cobra/command.go:902
main.installerMain()
/go/src/github.com/openshift/installer/cmd/openshift-install/main.go:72 +0x29e
main.main()
/go/src/github.com/openshift/installer/cmd/openshift-install/main.go:50 +0x125
```
OCPBUGS-262: UPI image download govc rate limit failure
…llision detection docs/design/resource_dep.svg shows the complicated hierarchy of installer assets, and it is likely that not all users are familiar with all the manifests that the installer generates. It's also possible that there is a complicated hierarchy on the caller's side, and not just a single actor, creating additional manifests to feed into a create-manifests flow. With all of these inputs, it seems possible that folks occasionally call the installer with directory contents that result in multiple manifests for a single resource, as determined by the (group, kind, namespace, name) tuples. This commit adds a check at the slightly-before-Ignition-serialization overrides asset, which was already in the business of iterating over the content and building ClusterVersion spec.overrides. Failing fast before we build Ignition configs should allow for relatively cheap recovery, vs. a user's cluster failing to come up, or coming up with a config that diverges from their intention because some other manifest ended up taking precedence over the resource that they'd been trying to control. Not covered in this commit is deduping between manifests generated on the bootstrap machine (e.g. by the various 'render' calls to operator containers). But that can happen orthogonally, or not, and I think it's still worth having this cheap, pre-Ignition-config sanity check.
…utex IBMCloud: Use unique mutex for Client retrieval
** Added the Network Project ID data to gcp terraform vars ** Added checks to GCP terraform to set count to 0 for firewall rules when the Network Project ID is available. CORS 2039 Requires openshift#6166 ** Added a default value for the terraform value for network_project_id
Co-authored-by: Rafael F. <[email protected]>
Bug 2109538: nutanix: allow creating manifests without Prism Central connection
…s_4.12 CORS-1994: Update Installer Dependencies
Bug 2061947: IBMCloud: Handle missing RG
Bug 2098072: vsphere: fix default disk type when not speficied
IBMCloud DNS support requires a change to PlatformStatus, which is now available in the openshift/api. Updating go.mod and go.sum with latest api content.
CORS-2280: IBMCloud: Add DNS Record for internal public traffic
azure: validation: avoid specifying capabilities twice
powervs-delete-named-dhcp
…fields aws: replace deprecated object in terraform config
GCP: Add me-west1 region
go getter update for terraform & terraform providers
AWS: resolve subnet-related FIXMEs
OCPBUGS-1489: [vsphere] Loop over all folders for destroy
mjturek
force-pushed
the
use-ibm-dns-for-private
branch
18 times, most recently
from
f814349 to
01d3006
Compare
mjturek
force-pushed
the
use-ibm-dns-for-private
branch
from
01d3006 to
5988bfe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If creating a public cluster, continue to create records in CIS DNS. If creating a private cluster, create DNS records in IBM DNS Services.