Bug 2109538: nutanix: allow creating manifests without Prism Central connection #6149

vrutkovs · 2022-07-21T14:12:16Z

In Assisted Installer we create manifests and generate Ignition in the cloud and pass ignition files to the agents. For platform integration we can't request credentials from users, instead we fill these in with fake credentials and let them change these later.

This commit moves validations to ValidateForProvisioning, so that openshift-install create manifests phase would pass with fake credentials

openshift-ci · 2022-07-21T14:12:40Z

@vrutkovs: This pull request references Bugzilla bug 2109538, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.12.0) matches configured target release for branch (4.12.0)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla ([email protected]), skipping review request.

Details

In response to this:

Bug 2109538: nutanix: allow creating manifests without Prism Central connection

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

vrutkovs · 2022-07-21T14:12:43Z

/cherry-pick release-4.11

openshift-cherrypick-robot · 2022-07-21T14:12:45Z

@vrutkovs: once the present PR merges, I will cherry-pick it on top of release-4.11 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2022-07-21T14:16:44Z

@vrutkovs: An error was encountered adding this pull request to the external tracker bugs for bug 2109538 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message.


response code 400 not 200

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

Details

In response to this:

Bug 2109538: nutanix: allow creating manifests without Prism Central connection

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

vrutkovs · 2022-07-21T14:16:44Z

/cc @thunderboltsid

openshift-ci · 2022-07-21T14:16:46Z

@vrutkovs: This pull request references Bugzilla bug 2109538. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.
Warning: Failed to comment on Bugzilla bug with reason for changed state.

Details

In response to this:

Bug 2109538: nutanix: allow creating manifests without Prism Central connection

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2022-07-21T14:17:13Z

@vrutkovs: GitHub didn't allow me to request PR reviews from the following users: thunderboltsid.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

/cc @thunderboltsid

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

thunderboltsid · 2022-07-21T15:25:20Z

My only concern is that if someone has a misconfigured PE on install-config, they won’t get an error on running create manifests but only on create cluster .

thunderboltsid

LGTM

vrutkovs · 2022-07-21T18:24:04Z

/retest

thunderboltsid · 2022-07-21T20:38:06Z

/retest

vrutkovs · 2022-07-22T05:38:17Z

Still no luck with upi-installer build:

[3/3] STEP 22/30: RUN curl -L -o - "https://github.com/vmware/govmomi/releases/latest/download/govc_$(uname -s)_$(uname -m).tar.gz" | tar -C /bin -xvzf - govc
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100  1474  100  1474    0     0  10941      0 --:--:-- --:--:-- --:--:-- 11000

gzip: stdin: not in gzip format
tar: Child returned status 1
tar: Error is not recoverable: exiting now

/retest

In Assisted Installer we create manifests and generate Ignition in the cloud and pass ignition files to the agents. For platform integration we can't request credentials from users, instead we fill these in with fake credentials and let them change these later. This commit moves validations to ValidateForProvisioning, so that `openshift-install create manifests` phase would pass with fake credentials

In Assisted Installer we can't contact Prism Central to resolve Prism Element name via API. Instead we allow setting it to dummy value and let users update Infrastructure object later. This field is optional and would use API call if not set

vrutkovs · 2022-07-26T15:00:07Z

/retest

vrutkovs · 2022-07-27T15:40:00Z

/retest

vrutkovs · 2022-08-04T16:27:43Z

/test e2e-nutanix

vrutkovs · 2022-08-04T16:27:55Z

/cc @jhixson74 @patrickdillon

vrutkovs · 2022-08-04T17:29:38Z

/test e2e-nutanix

vrutkovs · 2022-08-05T05:55:05Z

/test e2e-nutanix

sadasu · 2022-08-05T14:56:57Z

pkg/asset/installconfig/nutanix/validation.go

+			return field.InternalError(field.NewPath("platform", "nutanix", "prismElements"), errors.Wrapf(err, "prism element UUID %s does not correspond to a valid prism element in Prism", pe.UUID))
+		}
+	}
+


Now that you getting the "Name" of the PrismElement as an optional parameter, do you need to validate if that exists also? And I am assuming that the Name of the PrismElement should correspond to the same UUID in the Nutanix cluster.

Yes, the name should match the UUID, it is being validated in create cluster phase - or filled in if its unset.

patrickdillon · 2022-08-22T11:30:37Z

/approve

openshift-ci · 2022-08-22T11:32:54Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon, thunderboltsid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [patrickdillon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

rvanderp3 · 2022-08-22T12:26:38Z

/lgtm

openshift-ci-robot · 2022-08-22T12:33:03Z

/retest-required

Remaining retests: 2 against base HEAD e781753 and 8 for PR HEAD 02a6ad4 in total

vrutkovs · 2022-08-22T12:54:58Z

/skip

openshift-ci-robot · 2022-08-22T15:27:50Z

/retest-required

Remaining retests: 1 against base HEAD e781753 and 7 for PR HEAD 02a6ad4 in total

openshift-ci · 2022-08-22T15:30:01Z

@vrutkovs: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-openstack	`02a6ad4`	link	false	`/test e2e-openstack`
ci/prow/e2e-libvirt	`02a6ad4`	link	false	`/test e2e-libvirt`
ci/prow/e2e-metal-ipi	`02a6ad4`	link	false	`/test e2e-metal-ipi`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

vrutkovs · 2022-08-22T16:05:49Z

/skip
/retest

vrutkovs · 2022-08-22T17:07:21Z

/retest-required

openshift-ci · 2022-08-22T20:25:58Z

@vrutkovs: All pull requests linked via external trackers have merged:

openshift/installer#6149

Bugzilla bug 2109538 has been moved to the MODIFIED state.

Details

In response to this:

Bug 2109538: nutanix: allow creating manifests without Prism Central connection

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2022-08-22T20:27:25Z

@vrutkovs: new pull request created: #6251

Details

In response to this:

/cherry-pick release-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jul 21, 2022

openshift-ci bot requested review from AnnaZivkovic and sadasu July 21, 2022 14:14

vrutkovs closed this Jul 21, 2022

vrutkovs reopened this Jul 21, 2022

thunderboltsid approved these changes Jul 21, 2022

View reviewed changes

Vadim Rutkovsky added 2 commits July 26, 2022 15:27

vrutkovs force-pushed the nutanix-validate-later branch from 47b1bb1 to 02a6ad4 Compare July 26, 2022 13:29

openshift-ci bot requested review from jhixson74 and patrickdillon August 4, 2022 16:27

sadasu reviewed Aug 5, 2022

View reviewed changes

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 22, 2022

openshift-ci bot assigned rvanderp3 Aug 22, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 22, 2022

openshift-merge-robot merged commit 7a069c0 into openshift:master Aug 22, 2022

openshift-cherrypick-robot mentioned this pull request Aug 22, 2022

[release-4.11] OCPBUGS-433: nutanix: allow creating manifests without Prism Central connection #6251

Merged

Bug 2109538: nutanix: allow creating manifests without Prism Central connection #6149

Bug 2109538: nutanix: allow creating manifests without Prism Central connection #6149

Uh oh!

Conversation

vrutkovs commented Jul 21, 2022

Uh oh!

openshift-ci bot commented Jul 21, 2022

Uh oh!

vrutkovs commented Jul 21, 2022

Uh oh!

openshift-cherrypick-robot commented Jul 21, 2022

Uh oh!

openshift-ci bot commented Jul 21, 2022

Uh oh!

vrutkovs commented Jul 21, 2022

Uh oh!

openshift-ci bot commented Jul 21, 2022

Uh oh!

openshift-ci bot commented Jul 21, 2022

Uh oh!

thunderboltsid commented Jul 21, 2022

Uh oh!

thunderboltsid left a comment

Choose a reason for hiding this comment

Uh oh!

vrutkovs commented Jul 21, 2022

Uh oh!

thunderboltsid commented Jul 21, 2022

Uh oh!

vrutkovs commented Jul 22, 2022

Uh oh!

vrutkovs commented Jul 26, 2022

Uh oh!

vrutkovs commented Jul 27, 2022

Uh oh!

vrutkovs commented Aug 4, 2022

Uh oh!

vrutkovs commented Aug 4, 2022

Uh oh!

vrutkovs commented Aug 4, 2022

Uh oh!

vrutkovs commented Aug 5, 2022

Uh oh!

sadasu Aug 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vrutkovs Aug 5, 2022

Choose a reason for hiding this comment

Uh oh!

patrickdillon commented Aug 22, 2022

Uh oh!

openshift-ci bot commented Aug 22, 2022

Uh oh!

rvanderp3 commented Aug 22, 2022

Uh oh!

openshift-ci-robot commented Aug 22, 2022

Uh oh!

vrutkovs commented Aug 22, 2022

Uh oh!

openshift-ci-robot commented Aug 22, 2022

Uh oh!

openshift-ci bot commented Aug 22, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vrutkovs commented Aug 22, 2022

Uh oh!

vrutkovs commented Aug 22, 2022

Uh oh!

openshift-ci bot commented Aug 22, 2022

Uh oh!

openshift-cherrypick-robot commented Aug 22, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

sadasu Aug 5, 2022 •

edited

Loading

openshift-ci bot commented Aug 22, 2022 •

edited

Loading