Bug 2061947: IBMCloud: Handle missing RG

[cjschaef]

Handle cases when there is no ResourceGroupName provided
during destroy, or the ResourceGroup doesn't exist, or cannot
be found.

Related: https://bugzilla.redhat.com/show_bug.cgi?id=2061947

[openshift-ci]

@cjschaef: This pull request references Bugzilla bug 2061947, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.12.0) matches configured target release for branch (4.12.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @MayXuQQ

Details

In response to this:

Bug 2061947: IBMCloud: Handle missing RG

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[cjschaef]

Tested that an empty resourceGroupName or one that doesn't exist in the metadata.json result in a failure.

# bin/openshift-install destroy cluster --dir bz_2061947/bz2061947-no-rg-2
FATAL Failed to destroy cluster: No ResourceGroupName provided

# bin/openshift-install destroy cluster --dir bz_2061947/bz2061947-no-rg-2
FATAL Failed to destroy cluster: ResourceGroup '"bz2061947-no-rg-not-rg-tqcmc"' not found

[MayXuQQ]

can you help deal with such issue, fail to delete the volume (blocked by Service Broker returned error status code 500) , avoid loop prompt.
the metadata.json
{"clusterName":"logci4272","clusterID":"eaaac982-574e-48c1-a455-32b3bbd6a0c8","infraID":"logci4272-ddbjm","ibmcloud":{"accountID":"fdc2e14cf8bc4d53a67f972dc2e2c861","baseDomain":"ibmcloud.qe.devcluster.openshift.com","cisInstanceCRN":"crn:v1:bluemix:public:internet-svcs:global:a/fdc2e14cf8bc4d53a67f972dc2e2c861:e8ee6ca1-4b31-4307-8190-e67f6925f83b::","region":"us-east","resourceGroupName":"logci4272-ddbjm"}}

{"clusterName":"logci4315","clusterID":"211f8ae0-bd1a-4b81-a0e3-3db827a6a5f6","infraID":"logci4315-hxxvx","ibmcloud":{"accountID":"fdc2e14cf8bc4d53a67f972dc2e2c861","baseDomain":"ibmcloud.qe.devcluster.openshift.com","cisInstanceCRN":"crn:v1:bluemix:public:internet-svcs:global:a/fdc2e14cf8bc4d53a67f972dc2e2c861:e8ee6ca1-4b31-4307-8190-e67f6925f83b::","region":"us-east","resourceGroupName":"logci4315-hxxvx"}}

[jhixson74]

/retest

[MayXuQQ]

/test e2e-ibmcloud

[cjschaef]

Slightly concerning on the recent e2e-ibmcloud failure

level=error msg=  with module.image.ibm_iam_authorization_policy.policy,
level=error msg=  on image/main.tf line 19, in resource "ibm_iam_authorization_policy" "policy":
level=error msg=  19: resource "ibm_iam_authorization_policy" "policy" {
level=error
level=error msg=failed to fetch Cluster: failed to generate asset "Cluster": failure applying terraform for "network" stage: failed to create cluster: failed to apply Terraform: exit status 1 

May have been an issue with IBM Cloud API's (outage), but will look for a more serious issue in case the IAM policies that have been setup have been corrupted/changed.

[cjschaef]

Things appear okay, will attempt to retry test, given other CI builds don't seem affected a this time.
/test e2e-ibmcloud

[cjschaef]

There have been numerous issues with IBM Cloud IAM and COS. I believe that is the cause of the latest failure (perhaps earlier failure as well), I have experienced with local testing. I will monitor until things appear to be restored and retry the testing then.

[MayXuQQ]

/label qe-approved
/bugzilla cc-qa

[openshift-ci]

@MayXuQQ: This pull request references Bugzilla bug 2061947, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.12.0) matches configured target release for branch (4.12.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @MayXuQQ

Details

In response to this:

/label qe-approved
/bugzilla cc-qa

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[cjschaef]

I've been seeing IAM errors with IBM Cloud, causing COS and other failures, likely resulting in the issues during testing.
I will see if I can get some successful builds to verify whether those issues have been resolved.

/test e2e-ibmcloud

[cjschaef]

/test e2e-ibmcloud

[cjschaef]

e2e-ibmcloud requires a fix to the MAPI repo/image
openshift/machine-api-provider-ibmcloud#3

[cjschaef]

MAPI patch merged.

Retesting e2e-ibmcloud to verify install works (Conformance tests expected to fail).
/test e2e-ibmcloud

[cjschaef]

This e2e-ibmcloud failure is expected, the install completed, and failure during Conformance tests (yet to be resolved).

This should be good for review/merge finally.

[jeffnowicki]

/cc @rvanderp3

[rvanderp3]

/lgtm
/assign @jstuever

[patrickdillon]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MayXuQQ, patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• pkg/destroy/ibmcloud/OWNERS [patrickdillon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

/retest-required

Remaining retests: 2 against base HEAD e781753 and 8 for PR HEAD 65ab4df in total

[jeffnowicki]

/retest

[jeffnowicki]

/retest-required

[openshift-ci]

@cjschaef: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-ibmcloud	65ab4df	link	false	/test e2e-ibmcloud

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci]

@cjschaef: All pull requests linked via external trackers have merged:

• openshift/installer#6013
• openshift/installer#6152

Bugzilla bug 2061947 has been moved to the MODIFIED state.

Details

In response to this:

Bug 2061947: IBMCloud: Handle missing RG

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.