Skip to content

Conversation

@r4f4
Copy link
Contributor

@r4f4 r4f4 commented Jul 19, 2022

When looking at the subnet code I noticed the comment // FIXME: port to DescribeSubnetsPagesWithContext once we bump our vendored AWS package past v1.19.30. So I did it.

@openshift-ci openshift-ci bot requested review from jstuever and patrickdillon July 19, 2022 16:30
Copy link
Contributor

@barbacbd barbacbd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 22, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 15, 2022

@r4f4: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-single-node a3544ea link false /test e2e-aws-single-node
ci/prow/e2e-aws-proxy a3544ea link false /test e2e-aws-proxy

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@patrickdillon
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 16, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 16, 2022
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 36e5ac3 and 2 for PR HEAD a3544ea in total

@r4f4
Copy link
Contributor Author

r4f4 commented Sep 22, 2022

/retest-required

@r4f4
Copy link
Contributor Author

r4f4 commented Sep 22, 2022

/skip

@openshift-merge-robot openshift-merge-robot merged commit 80ba53b into openshift:master Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants