Skip to content

CORS-1994: Update Installer Dependencies #6175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 5 commits into from
Aug 23, 2022
Merged

CORS-1994: Update Installer Dependencies #6175

openshift-merge-robot merged 5 commits into from
Aug 23, 2022

Conversation

@barbacbd
Copy link
Contributor

@barbacbd barbacbd commented Jul 27, 2022 •
edited
Loading

** Updating all dependencies for the installer project
** Updated all with go mod tidy and go mod vendor.

** NOTE: Requires go v1.18+
#6163
#6077

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 27, 2022
@barbacbd
Copy link
Contributor Author

barbacbd commented Jul 27, 2022

/cc patrickdillon

@openshift-ci openshift-ci bot requested review from patrickdillon, r4f4 and rna-afk July 27, 2022 20:02
@jhixson74
Copy link
Member

jhixson74 commented Jul 28, 2022

This should be broken up into go mod vendor and go mod tidy commits.

@jhixson74 jhixson74 mentioned this pull request Jul 28, 2022
Merged
@barbacbd barbacbd closed this Jul 28, 2022
@barbacbd barbacbd force-pushed the upgrade_installer_deps_4.12 branch from 5143c46 to 2aa8651 Compare July 28, 2022 19:23
@barbacbd
Copy link
Contributor Author

barbacbd commented Jul 28, 2022

/reopen

@openshift-ci openshift-ci bot reopened this Jul 28, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 28, 2022

@barbacbd: Reopened this PR.

Details

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@barbacbd barbacbd changed the title WIP CORS-1994: Update Installer Dependencies CORS-1994: Update Installer Dependencies Jul 28, 2022
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 28, 2022
@jhixson74
Copy link
Member

jhixson74 commented Jul 29, 2022

/retest

1 similar comment
@patrickdillon
Copy link
Contributor

patrickdillon commented Aug 1, 2022

/retest

@barbacbd
Copy link
Contributor Author

barbacbd commented Aug 1, 2022

depends on #6077

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 13, 2022
@barbacbd barbacbd force-pushed the upgrade_installer_deps_4.12 branch from a39023d to db2864b Compare August 15, 2022 12:28
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 15, 2022
@patrickdillon
Copy link
Contributor

patrickdillon commented Aug 16, 2022

/approve
/retest

LGTM with successful test runs.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 16, 2022
@patrickdillon
Copy link
Contributor

patrickdillon commented Aug 19, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 19, 2022
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 19, 2022

/retest-required

Remaining retests: 2 against base HEAD 44e71ef and 8 for PR HEAD 12618e6 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 19, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon, r4f4

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 19, 2022

/retest-required

Remaining retests: 2 against base HEAD fc94a6c and 7 for PR HEAD 12618e6 in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 20, 2022

/retest-required

Remaining retests: 1 against base HEAD fc94a6c and 6 for PR HEAD 12618e6 in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 20, 2022

/retest-required

Remaining retests: 0 against base HEAD fc94a6c and 5 for PR HEAD 12618e6 in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 20, 2022

/retest-required

Remaining retests: 2 against base HEAD b08fe18 and 4 for PR HEAD 12618e6 in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 20, 2022

/retest-required

Remaining retests: 1 against base HEAD b08fe18 and 3 for PR HEAD 12618e6 in total

@barbacbd
Copy link
Contributor Author

barbacbd commented Aug 22, 2022

/retest

@barbacbd
Copy link
Contributor Author

barbacbd commented Aug 22, 2022

/test gofmt
/test okd-unit

@patrickdillon
Copy link
Contributor

patrickdillon commented Aug 22, 2022

/skip

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 22, 2022

/retest-required

Remaining retests: 2 against base HEAD 7a069c0 and 2 for PR HEAD 12618e6 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 23, 2022

@barbacbd: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ibmcloud 12618e6 link false /test e2e-ibmcloud
ci/prow/e2e-openstack 12618e6 link false /test e2e-openstack
ci/prow/e2e-metal-ipi 12618e6 link false /test e2e-metal-ipi
ci/prow/e2e-libvirt 12618e6 link false /test e2e-libvirt

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 2c36e07 into openshift:master Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

@rna-afk rna-afk Awaiting requested review from rna-afk

1 more reviewer

@r4f4 r4f4 r4f4 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@patrickdillon patrickdillon

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@barbacbd @jhixson74 @patrickdillon @openshift-ci-robot @r4f4 @openshift-merge-robot