OCPBUGS-1489: [vsphere] Loop over all folders for destroy #6378

jcpowermac · 2022-09-20T13:36:01Z

With the addition of vsphere zonal there
can and will be more than one folder in folderMoList. Adding a loop to delete all the folders.

With the addition of vsphere zonal there can and will be more than one folder in `folderMoList`. Adding a loop to delete all the folders.

openshift-ci-robot · 2022-09-20T13:36:07Z

@jcpowermac: This pull request references Jira Issue OCPBUGS-1489, which is invalid:

expected the bug to target the "4.12.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

With the addition of vsphere zonal there
can and will be more than one folder in folderMoList. Adding a loop to delete all the folders.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jcpowermac · 2022-09-20T13:37:04Z

/jira refresh

openshift-ci-robot · 2022-09-20T13:37:10Z

@jcpowermac: This pull request references Jira Issue OCPBUGS-1489, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.12.0) matches configured target version for branch (4.12.0)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jinyunma

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jcpowermac · 2022-09-20T13:37:49Z

/test e2e-vsphere-zones

bostrt · 2022-09-20T18:17:36Z

/lgtm

bostrt · 2022-09-20T18:29:11Z

I'm not sure this is a blocker but I just noticed 2 Folders being deleted. Is this one Folder per datacenter?

https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift_installer/6378/pull-ci-openshift-installer-master-e2e-vsphere-zones/1572224338780753920/artifacts/e2e-vsphere-zones/ipi-deprovision-deprovision/artifacts/.openshift_install.log

time="2022-09-20T17:22:06Z" level=debug msg="Delete Folder"
time="2022-09-20T17:22:06Z" level=debug msg="Find attached Folder on tag"
time="2022-09-20T17:22:17Z" level=info msg=Destroyed Folder=ci-op-5lnzcl4d-2bf35-rjfcf
time="2022-09-20T17:22:17Z" level=info msg=Destroyed Folder=ci-op-5lnzcl4d-2bf35-rjfcf

jcpowermac · 2022-09-20T18:34:06Z

I'm not sure this is a blocker but I just noticed 2 Folders being deleted. Is this one Folder per datacenter?

https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift_installer/6378/pull-ci-openshift-installer-master-e2e-vsphere-zones/1572224338780753920/artifacts/e2e-vsphere-zones/ipi-deprovision-deprovision/artifacts/.openshift_install.log
time="2022-09-20T17:22:06Z" level=debug msg="Delete Folder"
time="2022-09-20T17:22:06Z" level=debug msg="Find attached Folder on tag"
time="2022-09-20T17:22:17Z" level=info msg=Destroyed Folder=ci-op-5lnzcl4d-2bf35-rjfcf
time="2022-09-20T17:22:17Z" level=info msg=Destroyed Folder=ci-op-5lnzcl4d-2bf35-rjfcf

Right,

/<datacenter>/vm/<folder>/

Each datacenter needs a virtual machine folder.

bostrt · 2022-09-20T19:41:39Z

I think it would be nice to know the Datacenter in case a deletion fails and some manual intervention is needed. If its going to be difficult to include it, I don't think it should block this PR.

sadasu · 2022-09-21T15:03:29Z

/retitle OCPBUGS-1489: [vsphere] Loop over all folders for destroy

sadasu · 2022-09-21T15:03:52Z

/retest-required

sadasu · 2022-09-21T15:07:05Z

/test e2e-vsphere-zones

jcpowermac · 2022-09-21T18:56:25Z

The cluster installed, looks like a potential performance issue in this CI env.
both datacenter folders were removed

https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift_installer/6378/pull-ci-openshift-installer-master-e2e-vsphere-zones/1572603362526892032/artifacts/e2e-vsphere-zones/ipi-deprovision-deprovision/build-log.txt

sadasu · 2022-09-22T13:32:10Z

/retest-required

sadasu · 2022-09-22T13:32:21Z

/test e2e-vsphere-zones

jcpowermac · 2022-09-22T13:44:50Z

/test e2e-vsphere-zones

@sadasu currently we don't expect this job to pass. We got the results we need.

openshift-ci · 2022-09-22T15:30:23Z

@jcpowermac: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-e2e-gcp-ovn-upgrade	`980f1c5`	link	false	`/test okd-e2e-gcp-ovn-upgrade`
ci/prow/e2e-vsphere-zones	`980f1c5`	link	false	`/test e2e-vsphere-zones`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

sadasu · 2022-09-22T18:33:21Z

/approve

sadasu · 2022-09-22T18:33:27Z

/skip

openshift-ci · 2022-09-22T18:34:30Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sadasu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~pkg/destroy/vsphere/OWNERS~~ [sadasu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2022-09-22T21:26:52Z

@jcpowermac: All pull requests linked via external trackers have merged:

openshift/installer#6378

Jira Issue OCPBUGS-1489 has been moved to the MODIFIED state.

Details

In response to this:

With the addition of vsphere zonal there
can and will be more than one folder in folderMoList. Adding a loop to delete all the folders.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

OCPBUGS-1489: Loop over all folders for destroy

980f1c5

With the addition of vsphere zonal there can and will be more than one folder in `folderMoList`. Adding a loop to delete all the folders.

openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 20, 2022

openshift-ci bot requested a review from jinyunma September 20, 2022 13:37

openshift-ci bot requested review from bostrt and patrickdillon September 20, 2022 13:38

openshift-ci bot assigned bostrt Sep 20, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 20, 2022

openshift-ci bot changed the title ~~OCPBUGS-1489: Loop over all folders for destroy~~ OCPBUGS-1489: [vsphere] Loop over all folders for destroy Sep 21, 2022

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 22, 2022

openshift-merge-robot merged commit 25470c0 into openshift:master Sep 22, 2022

OCPBUGS-1489: [vsphere] Loop over all folders for destroy #6378

OCPBUGS-1489: [vsphere] Loop over all folders for destroy #6378

Conversation

jcpowermac commented Sep 20, 2022

Uh oh!

openshift-ci-robot commented Sep 20, 2022

Uh oh!

jcpowermac commented Sep 20, 2022

Uh oh!

openshift-ci-robot commented Sep 20, 2022

Uh oh!

jcpowermac commented Sep 20, 2022

Uh oh!

bostrt commented Sep 20, 2022

Uh oh!

bostrt commented Sep 20, 2022

Uh oh!

jcpowermac commented Sep 20, 2022

Uh oh!

bostrt commented Sep 20, 2022

Uh oh!

sadasu commented Sep 21, 2022

Uh oh!

sadasu commented Sep 21, 2022

Uh oh!

sadasu commented Sep 21, 2022

Uh oh!

jcpowermac commented Sep 21, 2022

Uh oh!

sadasu commented Sep 22, 2022

Uh oh!

sadasu commented Sep 22, 2022

Uh oh!

jcpowermac commented Sep 22, 2022

Uh oh!

openshift-ci bot commented Sep 22, 2022

Uh oh!

sadasu commented Sep 22, 2022

Uh oh!

sadasu commented Sep 22, 2022

Uh oh!

openshift-ci bot commented Sep 22, 2022

Uh oh!

openshift-ci-robot commented Sep 22, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants