azure: validation: avoid specifying capabilities twice #5952
Conversation
|
/test e2e-azure |
|
/cc barbacbd |
r4f4
force-pushed
the
azure-validation-test-dedup
branch
from
518ef96 to
2878e13
Compare
|
/test e2e-azure |
|
/retest-required |
1 similar comment
|
/retest-required |
|
/assign @patrickdillon |
openshift-merge-robot
added
the
needs-rebase
Instead, use the capabilities map to generate Azure types. It's much easier to add capabilities to a simple string map and then have that automatically converted to Azure API types. We also make sure that both vmCapabilities and instanceTypeSku are always in sync.
r4f4
force-pushed
the
azure-validation-test-dedup
branch
from
2878e13 to
d39739d
Compare
openshift-merge-robot
removed
the
needs-rebase
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sadasu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest |
|
/skip This PR only touches on the Azure unit tests. |
|
@r4f4: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
5 participants
Instead, use the capabilities map to generate Azure types. It's much
easier to add capabilities to a simple string map and then have that
automatically converted to Azure API types. We also make sure that both
vmCapabilities and instanceTypeSku are always in sync.