Bug 2098072: vsphere: fix default disk type when not speficied #6233
Conversation
During the terraform decoupling work [1], a fix for the default value for the disk provisioning type [2] ended up being lost. This commit bring those changes back, fixing a regression where the default disk type would be set to "thick" instead of the default storage policy of vsphere. [1] openshift@9c77d6a [2] openshift@f3c9bfa
openshift-ci
bot
added
bugzilla/severity-unspecified
|
@r4f4: This pull request references Bugzilla bug 2098072, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
openshift-ci
bot
added
bugzilla/valid-bug
|
@r4f4: This pull request references Bugzilla bug 2098072, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test golint |
|
/test tf-fmt |
|
/approve @rvanderp3 @jcpowermac PTAL. Wanted to make sure you're aware of this regression. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: patrickdillon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/bugzilla refresh |
openshift-ci
bot
added
bugzilla/severity-high
|
@r4f4: This pull request references Bugzilla bug 2098072, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test okd-verify-codegen |
|
/test aro-unit |
|
/test e2e-ovirt |
|
/test okd-unit |
|
@r4f4: /override requires a failed status context, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override ci/prow/e2e-libvirt |
|
@r4f4: Overrode contexts on behalf of r4f4: ci/prow/e2e-libvirt DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test okd-unit |
|
@r4f4: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@r4f4: All pull requests linked via external trackers have merged: Bugzilla bug 2098072 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.11 |
|
@r4f4: new pull request created: #6256 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Bug 2098072: vsphere: fix default disk type when not speficied
7 participants
During the terraform decoupling work [1], a fix for the default value
for the disk provisioning type [2] ended up being lost.
This commit bring those changes back, fixing a regression where the
default disk type would be set to "thick" instead of the default storage
policy of vsphere.
[1] 9c77d6a
[2] f3c9bfa