AGENT-1388: Adding TechPreview Budge for Assisted installer and agent

[ElayAharoni]

https://issues.redhat.com/browse/AGENT-1388

this pr fixes several requirements:

1. changing the shown version on the above sea level for OVE to 4.20 from 4.19
2. changing the label from Developer preview to Tech preview in the local ui and on saas
3. changing the cluster support level for OVE to be limited from fully supported

Summary by CodeRabbit

• New Features

  • Support-level logic now respects the single-cluster feature flag, improving guidance and warnings.
  • Inline AI-enabled informational text added for disconnected/air‑gapped installs.

• Refactor

  • Branding updated from "DeveloperPreview" to "TechnologyPreview" across the UI.
  • Layout simplified to a horizontal flex arrangement.
  • OpenShift version display/usage updated to 4.20.

• Other

  • Disconnected-install toggle label text removed.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[openshift-ci-robot]

@ElayAharoni: This pull request references AGENT-1388 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

https://issues.redhat.com/browse/AGENT-1388

this pr fixes several requirements:

1. changing the shown version on the above sea level for OVE to 4.20 from 4.19
2. changing the label from Developer preview to Tech preview in the local ui and on saas
3. changing the cluster support level for OVE to be limited from fully supported

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Walkthrough

Replaces DeveloperPreview with TechnologyPreview across cluster-wizard UI, updates OpenShift references from 4.19 → 4.20 (and uses dynamic cluster.openshiftVersion), replaces PatternFly Split layouts with Flex for disconnected rows, removes the Switch label prop, and threads ASSISTED_INSTALLER_SINGLE_CLUSTER_FEATURE via useFeature into support-level logic.

Changes

Cohort / File(s)	Change Summary
Preview component migration libs/ui-lib/lib/ocm/components/clusterWizard/ClusterDetailsForm.tsx, libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/BasicStep.tsx, libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/OptionalConfigurationsStep.tsx, libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/ReviewStep.tsx, libs/ui-lib/lib/ocm/components/clusters/AssistedInstallerHeader.tsx	Replaced DeveloperPreview imports/usages with TechnologyPreview from common exports; updated JSX references.
Layout changes (disconnected rows / headers) libs/ui-lib/lib/ocm/components/clusterWizard/ClusterDetailsForm.tsx, libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/BasicStep.tsx	Removed PatternFly Split/SplitItem usage; introduced Flex-based inline containers aligning TechnologyPreview, InstallDisconnectedSwitch, and a translated informational span describing disconnected environments.
OpenShift version updates libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/BasicStep.tsx, libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/ReviewStep.tsx	Updated hardcoded OpenShift references from 4.19 → 4.20.
Dynamic cluster version & typing libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/OptionalConfigurationsStep.tsx	Added Cluster import; changed local state type to `Cluster
Switch API change libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/InstallDisconnectedSwitch.tsx	Removed label prop from the Switch component; other props/behavior unchanged.
Feature-flag propagation & support-level logic libs/ui-lib/lib/ocm/components/featureSupportLevels/ReviewClusterFeatureSupportLevels.tsx	Added useFeature for ASSISTED_INSTALLER_SINGLE_CLUSTER_FEATURE; threaded isSingleClusterFeatureEnabled into getSupportLevelInfo signature and memoization; updated rendering and version-warning logic accordingly.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

• Verify all DeveloperPreview → TechnologyPreview replacements and imports are correct and compiled.
• Review layout/spacing changes in ClusterDetailsForm.tsx and BasicStep.tsx for visual regressions.
• Confirm OpenShift version updates and dynamic cluster.openshiftVersion usage are consistent across flows.
• Inspect ReviewClusterFeatureSupportLevels.tsx for correct useFeature usage and proper threading of isSingleClusterFeatureEnabled into memoization and getSupportLevelInfo.
• Check accessibility after removing the label prop from InstallDisconnectedSwitch.tsx.

Possibly related PRs

• Add dev preview badge to disconnected switch #3132 — earlier change adding a preview badge next to InstallDisconnectedSwitch using Split/SplitItem; overlaps layout/preview area changes.
• MGMT-22204: add new fields to above sea level ABI #3274 — overlapping modifications to disconnected flow and DeveloperPreview→TechnologyPreview swaps and OpenShift version updates.
• Remove back button from first page #3120 — edits to BasicStep.tsx in the disconnected wizard that touch similar UI/components.

Suggested labels

lgtm, approved

Suggested reviewers

• batzionb
• ammont82

Poem

🐰 A rabbit hops through code with care,
Swapping badges, stretching rows to share,
Versions hop up to four-point-twenty,
Flags blink softly — small changes plenty,
A tiny patch, a joyful flare.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title mentions 'TechPreview Badge' but the main changes include OpenShift version updates (4.19→4.20), component rebranding (DeveloperPreview→TechnologyPreview), UI layout refactoring, and support level modifications. The title captures only one aspect of a multi-faceted change.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci-robot]

@ElayAharoni: This pull request references AGENT-1388 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

https://issues.redhat.com/browse/AGENT-1388

this pr fixes several requirements:

1. changing the shown version on the above sea level for OVE to 4.20 from 4.19
2. changing the label from Developer preview to Tech preview in the local ui and on saas
3. changing the cluster support level for OVE to be limited from fully supported

Summary by CodeRabbit

• New Features

• Added Tech Preview badge indicator to highlight experimental features across the application

• Enhanced support level display with improved awareness for single-cluster deployments

• UI Improvements

• Streamlined cluster configuration wizard layouts and messaging

• Improved OpenShift version handling for disconnected installation scenarios

_{✏️ Tip: You can customize this high-level summary in your review settings.}

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Actionable comments posted: 2

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/OptionalConfigurationsStep.tsx (1)

4-11: Align infraEnv openshiftVersion with the cluster’s version

The visual swap from DeveloperPreview to TechPreview looks fine.

However, in the disconnected flow you now register the cluster in BasicStep using a dynamic openshiftVersion (4.20 when installDisconnected is true, otherwise 4.19), while here the infraEnv is still created with a hard‑coded '4.19':

const createParams = {
  name: `disconnected-cluster_infra-env`,
  pullSecret: values.pullSecret || pullSecret,
  clusterId: cluster.id,
  openshiftVersion: '4.19', // <- always 4.19
  ...
};

This can leave you with a 4.20 cluster backed by a 4.19 infraEnv, which is likely not what the backend expects and may break OVE/disconnected behavior.

Consider instead deriving the infraEnv version from the actual cluster:

-              openshiftVersion: '4.19',
+              openshiftVersion: cluster.openshiftVersion,

(or, if you prefer, pass the same openshiftVersion constant you compute in BasicStep via context and reuse it here and in ReviewStep so all three stay in sync).

Also applies to: 120-127

🧹 Nitpick comments (6)

libs/ui-lib/lib/ocm/components/featureSupportLevels/ReviewClusterFeatureSupportLevels.tsx (1)

26-27: Clarify semantics of single‑cluster flag on support level and warning copy

You now treat ASSISTED_INSTALLER_SINGLE_CLUSTER_FEATURE as an additional reason for a cluster to be “limited” (isFullySupported is forced false and showVersionWarning becomes true) even when the OpenShift version is supported and limitedClusterFeatures is empty. The inline message still states “The installed OpenShift version is not production-ready”, which no longer matches the actual cause when only the single‑cluster feature is enabled.

Consider either:

• Updating the warning text to explicitly mention the single‑cluster tech preview/limited support status, or
• Using a separate flag/message for the tech‑preview case and reserving this text for genuinely unsupported versions.

This will avoid confusing users about why their cluster shows as limited.

Also applies to: 126-147, 155-172, 185-188

libs/locales/lib/en/translation.json (1)

244-247: Confirm consistency between Tech preview label and disclaimer text

The new key "ai:Tech Preview": "Tech preview" aligns the badge label with the requested wording. However, the TechPreview component still uses the existing long string that talks about “Developer preview features…” for its popover content.

If product wants to fully move to “Tech preview” terminology (including disclaimers), consider adding/updating a dedicated string for the tech‑preview description and pointing TechPreview at it; otherwise the badge and tooltip will mix “Tech preview” and “Developer preview” wording.

libs/ui-lib/lib/ocm/components/clusters/AssistedInstallerHeader.tsx (1)

3-8: Header TechPreview badge wiring looks good

Swapping to <TechPreview /> behind the existing ASSISTED_INSTALLER_SINGLE_CLUSTER_FEATURE flag keeps behavior consistent while updating the branding. Just double‑check spacing between the title and badge in the UI; if they appear cramped, a small margin utility class might help.

Also applies to: 11-19

libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/BasicStep.tsx (1)

3-11: Dynamic OCP version in BasicStep works, but consider centralizing it

Using installDisconnected ? '4.20' : '4.19' and wiring that into registerDisconnected lines up with the Review step’s display and fits the “bump OVE to 4.20” requirement.

Given the same version is now referenced here, in ReviewStep, and (after fixing) in OptionalConfigurationsStep, consider centralizing the logic to avoid future drift—for example:

• Compute the disconnected‑wizard openshiftVersion once in the wizard context and expose it, or
• Extract a small helper like getDisconnectedOpenshiftVersion(installDisconnected: boolean) and reuse it in all three places.

That will make the next OVE version bump a one‑liner instead of a multi‑file edit.

Also applies to: 27-38, 90-105, 108-110

libs/ui-lib/lib/ocm/components/clusterWizard/ClusterDetailsForm.tsx (1)

8-15: Cluster details TechPreview row swap is consistent

Replacing DeveloperPreview with TechPreview in the disconnected row (alongside InstallDisconnectedSwitch and the localized text) preserves existing feature‑flag gating and behavior while updating the branding. The inline flex layout matches the disconnected Basic step, which is nice for consistency.

No functional issues spotted here.

Also applies to: 71-72, 168-183

libs/ui-lib/lib/common/components/ui/TechPreview.tsx (1)

6-18: Consider preventing callers from overriding the tech preview docs link

Right now TechPreviewProps still includes externalLink, and because {...props} is spread after externalLink={TECH_SUPPORT_LEVEL_LINK}, callers can silently replace the canonical tech preview documentation URL.

If the intent is to always point to TECH_SUPPORT_LEVEL_LINK, consider tightening the type:

-export type TechPreviewProps = Omit<PreviewBadgeProps, 'text' | 'popoverContent'>;
+export type TechPreviewProps = Omit<
+  PreviewBadgeProps,
+  'text' | 'popoverContent' | 'externalLink'
+>;

This keeps the runtime JSX as‑is but makes overriding the link impossible at the type level.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 10193ff and 93f5401.

📒 Files selected for processing (10)

• libs/locales/lib/en/translation.json (1 hunks)
• libs/ui-lib/lib/common/components/ui/TechPreview.tsx (1 hunks)
• libs/ui-lib/lib/common/components/ui/index.ts (1 hunks)
• libs/ui-lib/lib/ocm/components/clusterWizard/ClusterDetailsForm.tsx (2 hunks)
• libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/BasicStep.tsx (4 hunks)
• libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/InstallDisconnectedSwitch.tsx (0 hunks)
• libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/OptionalConfigurationsStep.tsx (2 hunks)
• libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/ReviewStep.tsx (4 hunks)
• libs/ui-lib/lib/ocm/components/clusters/AssistedInstallerHeader.tsx (2 hunks)
• libs/ui-lib/lib/ocm/components/featureSupportLevels/ReviewClusterFeatureSupportLevels.tsx (4 hunks)

💤 Files with no reviewable changes (1)

• libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/InstallDisconnectedSwitch.tsx

🧰 Additional context used

🧠 Learnings (2)

📚 Learning: 2025-10-21T04:40:36.292Z

Learnt from: linoyaslan
Repo: openshift-assisted/assisted-installer-ui PR: 3190
File: libs/ui-lib/lib/ocm/components/clusterConfiguration/networkConfiguration/AdvancedNetworkFields.tsx:55-63
Timestamp: 2025-10-21T04:40:36.292Z
Learning: In libs/ui-lib/lib/ocm/components/clusterConfiguration/networkConfiguration/AdvancedNetworkFields.tsx, the network reordering logic in the useEffect (swapping clusterNetworks and serviceNetworks based on the primary machine network's IP family) is for UI consistency only. Validation of empty or invalid CIDRs is handled separately by validation schemas, not by the reordering logic.

Applied to files:

• libs/ui-lib/lib/ocm/components/clusterWizard/ClusterDetailsForm.tsx
• libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/OptionalConfigurationsStep.tsx

📚 Learning: 2025-05-22T07:31:16.062Z

Learnt from: rawagner
Repo: openshift-assisted/assisted-installer-ui PR: 2826
File: libs/ui-lib/lib/cim/components/YamlEditor/YamlEditor.tsx:50-61
Timestamp: 2025-05-22T07:31:16.062Z
Learning: The YamlEditor component in libs/ui-lib/lib/cim/components/YamlEditor/YamlEditor.tsx already handles YAML validation through the submitYamls function in utils.ts, which validates YAML syntax and throws user-friendly error messages if parsing fails.

Applied to files:

• libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/OptionalConfigurationsStep.tsx

🧬 Code graph analysis (5)

libs/ui-lib/lib/common/components/ui/TechPreview.tsx (2)

libs/ui-lib/lib/common/components/ui/PreviewBadge.tsx (2)

• PreviewBadgeProps (14-20)
• PreviewBadge (22-65)

libs/ui-lib/lib/common/config/docs_links.ts (1)

• TECH_SUPPORT_LEVEL_LINK (34-34)

libs/ui-lib/lib/ocm/components/clusters/AssistedInstallerHeader.tsx (1)

libs/ui-lib/lib/common/components/ui/TechPreview.tsx (1)

• TechPreview (8-20)

libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/BasicStep.tsx (3)

libs/ui-lib/lib/ocm/components/clusterWizard/ClusterWizardContext.tsx (1)

• useClusterWizardContext (30-36)

libs/ui-lib/lib/ocm/components/clusterWizard/index.ts (1)

• useClusterWizardContext (5-5)

libs/ui-lib/lib/common/components/ui/TechPreview.tsx (1)

• TechPreview (8-20)

libs/ui-lib/lib/ocm/components/clusterWizard/ClusterDetailsForm.tsx (1)

libs/ui-lib/lib/common/components/ui/TechPreview.tsx (1)

• TechPreview (8-20)

libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/ReviewStep.tsx (3)

libs/ui-lib/lib/ocm/components/clusterWizard/ClusterWizardContext.tsx (1)

• useClusterWizardContext (30-36)

libs/ui-lib/lib/ocm/components/clusterWizard/index.ts (1)

• useClusterWizardContext (5-5)

libs/ui-lib/lib/common/components/ui/TechPreview.tsx (1)

• TechPreview (8-20)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)

• GitHub Check: unit-tests
• GitHub Check: translation-files
• GitHub Check: tests
• GitHub Check: format
• GitHub Check: lint
• GitHub Check: circular-deps

🔇 Additional comments (2)

libs/ui-lib/lib/common/components/ui/index.ts (1)

11-15: TechPreview re‑export looks correct

Adding export * from './TechPreview'; is consistent with how other UI badges are exposed and enables the new component to be imported via ../../../common as used elsewhere.

libs/ui-lib/lib/common/components/ui/TechPreview.tsx (1)

6-21: Nice, focused wrapper around PreviewBadge

Good use of Omit<PreviewBadgeProps, 'text' | 'popoverContent'> to centralize the label, description, and link while still allowing layout/testID customization. The displayName assignment is also helpful for debugging.

[openshift-ci-robot]

@ElayAharoni: This pull request references AGENT-1388 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

https://issues.redhat.com/browse/AGENT-1388

this pr fixes several requirements:

1. changing the shown version on the above sea level for OVE to 4.20 from 4.19
2. changing the label from Developer preview to Tech preview in the local ui and on saas
3. changing the cluster support level for OVE to be limited from fully supported

Summary by CodeRabbit

• New Features

• Added a Tech Preview badge with explanatory popover and support link

• Support-level logic updated to respect single-cluster feature flag

• UI Improvements

• Streamlined cluster wizard layouts and inline controls for disconnected flows

• OpenShift version updated to 4.20 in disconnected scenarios

• Localization

• Added English translations for Tech Preview text and messaging

• Behavioral

• Removed inline label from the disconnected install switch

_{✏️ Tip: You can customize this high-level summary in your review settings.}

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Actionable comments posted: 0

♻️ Duplicate comments (1)

libs/ui-lib/lib/common/components/ui/TechPreview.tsx (1)

6-21: Popover copy still mentions “developer preview features” while label is “Tech Preview”

The badge text has been updated to “Tech Preview”, but the popover string still refers to “the developer preview features”. That mismatch is small but visible; consider updating the sentence to consistently say “tech preview features” (and adjust the corresponding i18n resource value) so the label and description align. Non‑English locale updates can follow the usual separate translation workflow.

🧹 Nitpick comments (2)

libs/ui-lib/lib/ocm/components/featureSupportLevels/ReviewClusterFeatureSupportLevels.tsx (1)

126-147: Single-cluster feature now globally forces “limited” support and reuses version-only warning copy

Wiring the ASSISTED_INSTALLER_SINGLE_CLUSTER_FEATURE flag into getSupportLevelInfo makes any cluster “not fully supported” whenever the flag is enabled, even if hasSupportedVersion is true and there are no limited features (limitedClusterFeatures is empty). On top of that, showVersionWarning is now also true whenever the flag is enabled, so users will always see “The installed OpenShift version is not production-ready”, even when the version check says it is supported.

If that’s intentional (OVE is considered tech‑preview and all clusters in this mode are limited), it might still be worth:

• Distinguishing between “version‑is‑preview” vs “single‑cluster tech preview” in the copy, so we don’t always blame the version; and/or
• Providing some explanation when limitedClusterFeatures is empty but the cluster is still limited due to the feature flag.

Otherwise, consider scoping the isSingleClusterFeatureEnabled condition more narrowly (e.g. only when the preview version itself is unsupported, or when a specific preview feature is present) and/or adjusting the warning text accordingly.

Also applies to: 149-172, 187-187

libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/BasicStep.tsx (1)

4-11: 4.20 wiring for disconnected OVE is consistent here; consider centralizing the constant

The disconnected flow now consistently uses '4.20' for both cluster registration (registerDisconnected) and OcmOpenShiftVersion, and the new header layout (TechPreview + switch + translated label) looks coherent.

If 4.20 is expected to change again with future OVE bumps, it might be worth hoisting this into a shared constant/config so BasicStep and downstream consumers stay in sync automatically.

Also applies to: 44-47, 88-103, 107-107

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 93f5401 and e9fe6a2.

📒 Files selected for processing (10)

• libs/locales/lib/en/translation.json (1 hunks)
• libs/ui-lib/lib/common/components/ui/TechPreview.tsx (1 hunks)
• libs/ui-lib/lib/common/components/ui/index.ts (1 hunks)
• libs/ui-lib/lib/ocm/components/clusterWizard/ClusterDetailsForm.tsx (2 hunks)
• libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/BasicStep.tsx (3 hunks)
• libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/InstallDisconnectedSwitch.tsx (0 hunks)
• libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/OptionalConfigurationsStep.tsx (3 hunks)
• libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/ReviewStep.tsx (3 hunks)
• libs/ui-lib/lib/ocm/components/clusters/AssistedInstallerHeader.tsx (2 hunks)
• libs/ui-lib/lib/ocm/components/featureSupportLevels/ReviewClusterFeatureSupportLevels.tsx (4 hunks)

💤 Files with no reviewable changes (1)

• libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/InstallDisconnectedSwitch.tsx

🚧 Files skipped from review as they are similar to previous changes (3)

• libs/locales/lib/en/translation.json
• libs/ui-lib/lib/common/components/ui/index.ts
• libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/ReviewStep.tsx

🧰 Additional context used

🧠 Learnings (4)

📓 Common learnings

Learnt from: jgyselov
Repo: openshift-assisted/assisted-installer-ui PR: 3151
File: libs/ui-lib/lib/cim/components/ClusterDeployment/constants.ts:25-25
Timestamp: 2025-09-02T08:03:57.204Z
Learning: In the openshift-assisted/assisted-installer-ui repository, non-English translations are handled separately from the main development process. When adding new translation keys to English locale files, it's expected that non-English locale files (es, fr, ja, ko, zh) may not immediately contain the corresponding translations, as these are managed through a different workflow.

📚 Learning: 2025-10-21T04:40:36.292Z

Learnt from: linoyaslan
Repo: openshift-assisted/assisted-installer-ui PR: 3190
File: libs/ui-lib/lib/ocm/components/clusterConfiguration/networkConfiguration/AdvancedNetworkFields.tsx:55-63
Timestamp: 2025-10-21T04:40:36.292Z
Learning: In libs/ui-lib/lib/ocm/components/clusterConfiguration/networkConfiguration/AdvancedNetworkFields.tsx, the network reordering logic in the useEffect (swapping clusterNetworks and serviceNetworks based on the primary machine network's IP family) is for UI consistency only. Validation of empty or invalid CIDRs is handled separately by validation schemas, not by the reordering logic.

Applied to files:

• libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/OptionalConfigurationsStep.tsx
• libs/ui-lib/lib/ocm/components/clusterWizard/ClusterDetailsForm.tsx
• libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/BasicStep.tsx

📚 Learning: 2025-05-22T07:31:16.062Z

Learnt from: rawagner
Repo: openshift-assisted/assisted-installer-ui PR: 2826
File: libs/ui-lib/lib/cim/components/YamlEditor/YamlEditor.tsx:50-61
Timestamp: 2025-05-22T07:31:16.062Z
Learning: The YamlEditor component in libs/ui-lib/lib/cim/components/YamlEditor/YamlEditor.tsx already handles YAML validation through the submitYamls function in utils.ts, which validates YAML syntax and throws user-friendly error messages if parsing fails.

Applied to files:

• libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/OptionalConfigurationsStep.tsx

📚 Learning: 2025-10-20T08:57:04.935Z

Learnt from: linoyaslan
Repo: openshift-assisted/assisted-installer-ui PR: 3190
File: libs/ui-lib/lib/ocm/components/clusterDetail/ClusterProperties.tsx:43-45
Timestamp: 2025-10-20T08:57:04.935Z
Learning: In the file `libs/ui-lib/lib/ocm/components/clusterDetail/ClusterProperties.tsx`, the `getStackTypeLabel` function returns 'Dual-stack' or 'IPv4' because the system currently only supports IPv4 single-stack clusters. IPv6-only single-stack clusters are not supported.

Applied to files:

• libs/ui-lib/lib/ocm/components/clusterWizard/ClusterDetailsForm.tsx

🧬 Code graph analysis (6)

libs/ui-lib/lib/ocm/components/featureSupportLevels/ReviewClusterFeatureSupportLevels.tsx (3)

libs/types/assisted-installer-service.d.ts (1)

• SupportLevel (2642-2647)

libs/ui-lib/lib/common/components/newFeatureSupportLevels/NewFeatureSupportLevelContext.tsx (1)

• useNewFeatureSupportLevel (17-25)

libs/ui-lib/lib/ocm/components/clusterWizard/OpenShiftVersionsContext.tsx (1)

• useOpenShiftVersionsContext (125-131)

libs/ui-lib/lib/common/components/ui/TechPreview.tsx (3)

libs/ui-lib/lib/common/components/ui/PreviewBadge.tsx (2)

• PreviewBadgeProps (14-20)
• PreviewBadge (22-65)

libs/ui-lib/lib/common/hooks/index.ts (1)

• useTranslation (3-3)

libs/ui-lib/lib/common/config/docs_links.ts (1)

• TECH_SUPPORT_LEVEL_LINK (34-34)

libs/ui-lib/lib/ocm/components/clusters/AssistedInstallerHeader.tsx (1)

libs/ui-lib/lib/common/components/ui/TechPreview.tsx (1)

• TechPreview (8-20)

libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/OptionalConfigurationsStep.tsx (1)

libs/ui-lib/lib/common/components/ui/TechPreview.tsx (1)

• TechPreview (8-20)

libs/ui-lib/lib/ocm/components/clusterWizard/ClusterDetailsForm.tsx (1)

libs/ui-lib/lib/common/components/ui/TechPreview.tsx (1)

• TechPreview (8-20)

libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/BasicStep.tsx (1)

libs/ui-lib/lib/common/components/ui/TechPreview.tsx (1)

• TechPreview (8-20)

🔇 Additional comments (3)

libs/ui-lib/lib/ocm/components/clusters/AssistedInstallerHeader.tsx (1)

3-8: TechPreview header usage looks correct and aligned with the feature flag

The new <TechPreview /> badge is correctly imported and rendered conditionally on ASSISTED_INSTALLER_SINGLE_CLUSTER_FEATURE, and the inline placement after the H1 should work well with PreviewBadge’s default styling. No issues from a logic/layout perspective.

Also applies to: 11-19

libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/OptionalConfigurationsStep.tsx (1)

5-11: Disconnected infra-env now aligned on 4.20 and TechPreview badge

Updating openshiftVersion to '4.20' in the infra-env createParams keeps it consistent with the disconnected cluster registration and OVE display, and swapping in <TechPreview /> for the header badge matches the new tech‑preview branding used elsewhere. No functional issues spotted here.

Also applies to: 120-127, 170-177

libs/ui-lib/lib/ocm/components/clusterWizard/ClusterDetailsForm.tsx (1)

8-15: Cluster details header TechPreview/disconnected strip looks consistent with the new pattern

The new flex container with <TechPreview />, InstallDisconnectedSwitch, and the translated disconnected-environment label under the “Cluster details” header mirrors the BasicStep UX and is correctly gated on !isSingleClusterFeatureEnabled. This keeps the tech‑preview signaling and switch visible in multi‑cluster flows without affecting the single‑cluster path.

Also applies to: 168-183

[openshift-ci-robot]

@ElayAharoni: This pull request references AGENT-1388 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

https://issues.redhat.com/browse/AGENT-1388

this pr fixes several requirements:

1. changing the shown version on the above sea level for OVE to 4.20 from 4.19
2. changing the label from Developer preview to Tech preview in the local ui and on saas
3. changing the cluster support level for OVE to be limited from fully supported

Summary by CodeRabbit

• New Features

• Added a Tech Preview badge with explanatory popover and support link

• Support-level logic now respects the single-cluster feature flag

• UI Improvements

• Streamlined cluster wizard layouts and inline controls for disconnected flows

• OpenShift version updated to 4.20 in disconnected scenarios

• Localization

• Added English translations for Tech Preview title and messaging

• Behavioral

• Removed inline label from the disconnected install switch

_{✏️ Tip: You can customize this high-level summary in your review settings.}

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Actionable comments posted: 0

♻️ Duplicate comments (2)

libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/ReviewStep.tsx (1)

131-133: Still hard‑coded OCP version; consider centralizing

DescriptionListDescription hard‑codes 4.20, so any future version bump requires touching this component separately from the creation logic in BasicStep (and infra/env steps). Prefer deriving this from a shared helper or cluster/context prop so all disconnected steps surface the same OVE from a single source.

libs/ui-lib/lib/common/components/ui/TechPreview.tsx (1)

12-15: Popover copy still references “developer preview” instead of Tech preview

The badge text is localized as “Tech Preview”, but the popover string/key still talks about “developer preview features”. That mismatch can be confusing and undermines the rebranding in AGENT‑1388. Consider updating the copy (and corresponding i18n entry) so it consistently uses Tech preview terminology, for example:

-      popoverContent={t(
-        'ai:Tech preview features are not intended to be used in production environments. The clusters deployed with the developer preview features are considered to be development clusters and are not supported through the Red Hat Customer Portal case management system.',
-      )}
+      popoverContent={t(
+        'ai:Tech preview features are not intended to be used in production environments. The clusters deployed with the Tech preview features are considered to be development clusters and are not supported through the Red Hat Customer Portal case management system.',
+      )}

(and update the matching translation resource).

🧹 Nitpick comments (1)

libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/BasicStep.tsx (1)

46-47: Avoid repeating the hard‑coded OVE string in multiple places

registerDisconnected and OcmOpenShiftVersion both hard‑code openshiftVersion as "4.20". This works for AGENT‑1388 but increases maintenance cost for the next bump. Consider a shared constant or deriving the version from cluster/context so BasicStep, ReviewStep, and infraEnv creation all read from the same source.

Also applies to: 107-107

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e9fe6a2 and db214e4.

📒 Files selected for processing (10)

• libs/locales/lib/en/translation.json (1 hunks)
• libs/ui-lib/lib/common/components/ui/TechPreview.tsx (1 hunks)
• libs/ui-lib/lib/common/components/ui/index.ts (1 hunks)
• libs/ui-lib/lib/ocm/components/clusterWizard/ClusterDetailsForm.tsx (3 hunks)
• libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/BasicStep.tsx (3 hunks)
• libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/InstallDisconnectedSwitch.tsx (0 hunks)
• libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/OptionalConfigurationsStep.tsx (3 hunks)
• libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/ReviewStep.tsx (3 hunks)
• libs/ui-lib/lib/ocm/components/clusters/AssistedInstallerHeader.tsx (2 hunks)
• libs/ui-lib/lib/ocm/components/featureSupportLevels/ReviewClusterFeatureSupportLevels.tsx (4 hunks)

💤 Files with no reviewable changes (1)

• libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/InstallDisconnectedSwitch.tsx

🚧 Files skipped from review as they are similar to previous changes (5)

• libs/ui-lib/lib/ocm/components/clusterWizard/ClusterDetailsForm.tsx
• libs/locales/lib/en/translation.json
• libs/ui-lib/lib/common/components/ui/index.ts
• libs/ui-lib/lib/ocm/components/featureSupportLevels/ReviewClusterFeatureSupportLevels.tsx
• libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/OptionalConfigurationsStep.tsx

🧰 Additional context used

🧠 Learnings (1)

📚 Learning: 2025-10-21T04:40:36.292Z

Learnt from: linoyaslan
Repo: openshift-assisted/assisted-installer-ui PR: 3190
File: libs/ui-lib/lib/ocm/components/clusterConfiguration/networkConfiguration/AdvancedNetworkFields.tsx:55-63
Timestamp: 2025-10-21T04:40:36.292Z
Learning: In libs/ui-lib/lib/ocm/components/clusterConfiguration/networkConfiguration/AdvancedNetworkFields.tsx, the network reordering logic in the useEffect (swapping clusterNetworks and serviceNetworks based on the primary machine network's IP family) is for UI consistency only. Validation of empty or invalid CIDRs is handled separately by validation schemas, not by the reordering logic.

Applied to files:

• libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/BasicStep.tsx

🧬 Code graph analysis (3)

libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/BasicStep.tsx (1)

libs/ui-lib/lib/common/components/ui/TechPreview.tsx (1)

• TechPreview (8-20)

libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/ReviewStep.tsx (1)

libs/ui-lib/lib/common/components/ui/TechPreview.tsx (1)

• TechPreview (8-20)

libs/ui-lib/lib/common/components/ui/TechPreview.tsx (2)

libs/ui-lib/lib/common/components/ui/PreviewBadge.tsx (2)

• PreviewBadgeProps (14-20)
• PreviewBadge (22-65)

libs/ui-lib/lib/common/config/docs_links.ts (1)

• TECH_SUPPORT_LEVEL_LINK (34-34)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)

• GitHub Check: translation-files
• GitHub Check: unit-tests
• GitHub Check: circular-deps
• GitHub Check: tests
• GitHub Check: lint
• GitHub Check: format

🔇 Additional comments (4)

libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/ReviewStep.tsx (1)

6-6: TechPreview swap looks consistent

Importing and rendering <TechPreview /> here lines up with the rest of the wizard and keeps the preview indicator consistent across flows.

Also applies to: 100-100

libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/BasicStep.tsx (1)

4-5: Header refactor and TechPreview usage look good

Using Content for the title plus an inline flex row with <TechPreview />, InstallDisconnectedSwitch, and the translated helper text provides a clear, compact summary of the disconnected Tech preview flow.

Also applies to: 10-10, 88-88, 91-103

libs/ui-lib/lib/ocm/components/clusters/AssistedInstallerHeader.tsx (1)

5-5: Assisted installer header TechPreview badge is wired correctly

Conditionally rendering <TechPreview /> behind isSingleClusterFeatureEnabled preserves the existing feature‑flag behavior while aligning the badge text with the new Tech preview terminology.

Also applies to: 18-18

libs/ui-lib/lib/common/components/ui/TechPreview.tsx (1)

1-7: Component structure and typing are solid

Wrapping PreviewBadge with TechPreviewProps = Omit<PreviewBadgeProps, 'text' | 'popoverContent'> cleanly locks down the label and popover while still exposing layout/testing props, and the displayName is a nice touch for debugging.

Also applies to: 8-11, 16-20

[openshift-ci-robot]

@ElayAharoni: This pull request references AGENT-1388 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

https://issues.redhat.com/browse/AGENT-1388

this pr fixes several requirements:

1. changing the shown version on the above sea level for OVE to 4.20 from 4.19
2. changing the label from Developer preview to Tech preview in the local ui and on saas
3. changing the cluster support level for OVE to be limited from fully supported

Summary by CodeRabbit

• New Features

• Added feature flag integration for single-cluster feature scenarios with improved support level indicators.

• Enhanced UI support messaging for disconnected and air-gapped environments.

• Refactor

• Updated OpenShift version support from 4.19 to 4.20.

• Improved UI layout with flex-based container redesign.

• Updated component branding from DeveloperPreview to TechnologyPreview.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Actionable comments posted: 0

♻️ Duplicate comments (1)

libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/ReviewStep.tsx (1)

130-135: Avoid hard‑coding the OpenShift version here; derive from a single source

<DescriptionListDescription>4.20</DescriptionListDescription> meets the current OVE bump requirement, but it reintroduces a hard‑coded version in this step. That makes future bumps error‑prone and risks divergence from whatever source BasicStep/other steps use for the disconnected OpenShift version. If there is a canonical value (cluster data, wizard context, or a shared constant/helper), consider reading the version from that instead so all steps stay in sync.

🧹 Nitpick comments (2)

libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/BasicStep.tsx (2)

46-47: Avoid repeating the OpenShift version literal in this component

'4.20' is now hardcoded in both the registerDisconnected payload and OcmOpenShiftVersion. To reduce the chance of drift on the next bump (e.g., to 4.21), consider hoisting this into a single constant and reusing it in both places (while still keeping it hardcoded for now, per the earlier discussion about not having a dynamic source yet).

Example refactor:

-import { Cluster } from '@openshift-assisted/types//assisted-installer-service';
-
-const BasicStep = () => {
+import { Cluster } from '@openshift-assisted/types//assisted-installer-service';
+
+const DISCONNECTED_OCP_VERSION = '4.20';
+
+const BasicStep = () => {
@@
-        await ClustersService.registerDisconnected({
-          name: 'disconnected-cluster',
-          openshiftVersion: '4.20',
-        });
+        await ClustersService.registerDisconnected({
+          name: 'disconnected-cluster',
+          openshiftVersion: DISCONNECTED_OCP_VERSION,
+        });
@@
-                <OcmOpenShiftVersion openshiftVersion="4.20" withPreviewText withMultiText>
+                <OcmOpenShiftVersion
+                  openshiftVersion={DISCONNECTED_OCP_VERSION}
+                  withPreviewText
+                  withMultiText
+                >

Also applies to: 107-107

---

88-103: Verify switch labelling/accessibility after moving the text outside the Switch

The new inline layout with TechnologyPreview, InstallDisconnectedSwitch, and the explanatory <span> reads well visually, but moving the text out of the underlying <Switch>’s label prop can drop the control’s accessible name if InstallDisconnectedSwitch does not explicitly wire it up.

Please double‑check that:

• InstallDisconnectedSwitch still exposes an accessible label (e.g., via aria-label, aria-labelledby, or a proper <label htmlFor> association), and
• Screen readers announce something equivalent to the new string {t("ai:I'm installing on a disconnected/air-gapped/secured environment")} when focusing the switch.

If that wiring is already handled inside InstallDisconnectedSwitch, this layout is fine. Otherwise, consider associating the <span> text with the switch via aria-labelledby or a wrapping <label>. The inline style usage for the flex row is fine; if you later want to standardize layout, you could replace it with a PatternFly Flex + utility classes, but that’s purely optional.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between db214e4 and a2253ab.

📒 Files selected for processing (7)

• libs/ui-lib/lib/ocm/components/clusterWizard/ClusterDetailsForm.tsx (3 hunks)
• libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/BasicStep.tsx (3 hunks)
• libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/InstallDisconnectedSwitch.tsx (0 hunks)
• libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/OptionalConfigurationsStep.tsx (5 hunks)
• libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/ReviewStep.tsx (3 hunks)
• libs/ui-lib/lib/ocm/components/clusters/AssistedInstallerHeader.tsx (2 hunks)
• libs/ui-lib/lib/ocm/components/featureSupportLevels/ReviewClusterFeatureSupportLevels.tsx (4 hunks)

💤 Files with no reviewable changes (1)

• libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/InstallDisconnectedSwitch.tsx

🚧 Files skipped from review as they are similar to previous changes (3)

• libs/ui-lib/lib/ocm/components/clusters/AssistedInstallerHeader.tsx
• libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/OptionalConfigurationsStep.tsx
• libs/ui-lib/lib/ocm/components/clusterWizard/ClusterDetailsForm.tsx

🧰 Additional context used

🧠 Learnings (1)

📚 Learning: 2025-10-21T04:40:36.292Z

Learnt from: linoyaslan
Repo: openshift-assisted/assisted-installer-ui PR: 3190
File: libs/ui-lib/lib/ocm/components/clusterConfiguration/networkConfiguration/AdvancedNetworkFields.tsx:55-63
Timestamp: 2025-10-21T04:40:36.292Z
Learning: In libs/ui-lib/lib/ocm/components/clusterConfiguration/networkConfiguration/AdvancedNetworkFields.tsx, the network reordering logic in the useEffect (swapping clusterNetworks and serviceNetworks based on the primary machine network's IP family) is for UI consistency only. Validation of empty or invalid CIDRs is handled separately by validation schemas, not by the reordering logic.

Applied to files:

• libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/BasicStep.tsx

🧬 Code graph analysis (3)

libs/ui-lib/lib/ocm/components/featureSupportLevels/ReviewClusterFeatureSupportLevels.tsx (3)

libs/types/assisted-installer-service.d.ts (1)

• SupportLevel (2642-2647)

libs/ui-lib/lib/common/components/newFeatureSupportLevels/NewFeatureSupportLevelContext.tsx (1)

• useNewFeatureSupportLevel (17-25)

libs/ui-lib/lib/ocm/components/clusterWizard/OpenShiftVersionsContext.tsx (1)

• useOpenShiftVersionsContext (125-131)

libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/ReviewStep.tsx (1)

libs/ui-lib/lib/common/components/ui/TechnologyPreview.tsx (1)

• TechnologyPreview (11-24)

libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/BasicStep.tsx (1)

libs/ui-lib/lib/common/components/ui/TechnologyPreview.tsx (1)

• TechnologyPreview (11-24)

🔇 Additional comments (8)

libs/ui-lib/lib/ocm/components/featureSupportLevels/ReviewClusterFeatureSupportLevels.tsx (6)

155-172: Memoization correctly updated with new dependency.

The useMemo hook properly includes isSingleClusterFeatureEnabled in its dependency array, ensuring the support level is recalculated when the feature flag changes. The function call correctly passes all required parameters.

---

142-145: Logic correctly implements limited support for single-cluster feature.

The isFullySupported flag now correctly returns false when isSingleClusterFeatureEnabled is true, aligning with the PR objective to change the support level from "fully supported" to "limited" when this feature is active.

---

187-187: Version warning appropriately shown for single-cluster feature.

The showVersionWarning prop now includes the isSingleClusterFeatureEnabled condition, ensuring users are notified when the cluster has limited support due to this feature. This is consistent with the updated isFullySupported logic.

---

153-153: Verify the feature flag name is registered in the system.

The feature flag ASSISTED_INSTALLER_SINGLE_CLUSTER_FEATURE should be defined in the feature flag registry or configuration. Confirm this flag exists in your feature flag definitions, type exports, or configuration files.

---

126-147: Verify all call sites of getSupportLevelInfo are updated with the new isSingleClusterFeatureEnabled parameter.

The function signature has been modified to include the isSingleClusterFeatureEnabled parameter. Search the codebase for all usages of getSupportLevelInfo and ensure each call site provides this parameter.

---

26-26: Verify the useFeature hook import path and availability.

Ensure that the useFeature hook exists at ../../hooks/use-feature and is properly typed to return a boolean value. The relative path from libs/ui-lib/lib/ocm/components/featureSupportLevels/ReviewClusterFeatureSupportLevels.tsx should resolve to libs/ui-lib/lib/ocm/hooks/use-feature. Confirm the hook is properly exported and returns a boolean type.

libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/ReviewStep.tsx (1)

5-9: Tech Preview badge wiring looks correct

Importing TechnologyPreview from ../../../../common and rendering <TechnologyPreview /> alongside the “Review and download ISO” header cleanly reuses the shared badge component and aligns this step with the new Tech Preview branding used elsewhere.

Also applies to: 95-102

libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/BasicStep.tsx (1)

4-4: TechnologyPreview import/use looks consistent with the shared preview badge

Importing TechnologyPreview from the common bundle here aligns with the rest of the PR’s migration away from DeveloperPreview; no issues from this change in this file.

[openshift-ci-robot]

@ElayAharoni: This pull request references AGENT-1388 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

https://issues.redhat.com/browse/AGENT-1388

this pr fixes several requirements:

1. changing the shown version on the above sea level for OVE to 4.20 from 4.19
2. changing the label from Developer preview to Tech preview in the local ui and on saas
3. changing the cluster support level for OVE to be limited from fully supported

Summary by CodeRabbit

• New Features

• Support-level logic now respects the single-cluster feature flag, improving guidance and warnings.

• Improved messaging for disconnected/air‑gapped installs (inline informational text added).

• Refactor

• Updated branding from "DeveloperPreview" to "TechnologyPreview" across UI.

• UI layout simplified to a horizontal flex-based arrangement.

• OpenShift version display/usage updated to 4.20.

• Other

• Streamlined disconnected-install toggle UI (label text removed).

_{✏️ Tip: You can customize this high-level summary in your review settings.}

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

libs/ui-lib/lib/ocm/components/clusters/AssistedInstallerHeader.tsx (1)

3-8: TechnologyPreview swap looks correct; verify copy matches product wording

The import and conditional rendering of <TechnologyPreview /> mirror the previous DeveloperPreview usage and stay correctly gated on ASSISTED_INSTALLER_SINGLE_CLUSTER_FEATURE, so behaviorally this looks good.

One thing to double‑check: the shared TechnologyPreview component’s copy is “Technology Preview”, while the PR/JIRA description mentions “Tech preview”. If UX or docs expect the shorter label everywhere, you may want to align the translation string or confirm that the longer form is intended here.

Also applies to: 18-18

libs/ui-lib/lib/ocm/components/clusterWizard/ClusterDetailsForm.tsx (1)

168-183: Disconnected row flex layout: verify a11y labeling and token, consider minor refactor

The new flex row cleanly groups TechnologyPreview, InstallDisconnectedSwitch, and the explanatory text, and the gating on !isSingleClusterFeatureEnabled remains intact.

A couple of follow‑ups to consider:

• The visible description is now in a separate <span> that isn’t obviously associated with InstallDisconnectedSwitch. If InstallDisconnectedSwitch doesn’t set its own accessible name (e.g., via aria-label/aria-labelledby), the switch may be effectively unlabeled for assistive technologies. Please verify that the switch still has a meaningful accessible name and, if not, wire the span and switch together (for example, via aria-labelledby on the underlying control).
• Double‑check the spacing token var(--pf-t--global--spacer--sm) matches the design system’s actual CSS variables; if the project already uses PatternFly tokens elsewhere (e.g., --pf-global--spacer--sm / v5+ equivalents), it’s safer to reuse the same pattern rather than a potentially custom prefix.
• Optional: to avoid recreating the style object on every render and to make the layout reusable, you could hoist the style into a const disconnectedRowStyle (or use PatternFly’s <Flex> component) and reference it here.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a2253ab and a124b16.

📒 Files selected for processing (7)

• libs/ui-lib/lib/ocm/components/clusterWizard/ClusterDetailsForm.tsx (3 hunks)
• libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/BasicStep.tsx (3 hunks)
• libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/InstallDisconnectedSwitch.tsx (0 hunks)
• libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/OptionalConfigurationsStep.tsx (5 hunks)
• libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/ReviewStep.tsx (3 hunks)
• libs/ui-lib/lib/ocm/components/clusters/AssistedInstallerHeader.tsx (2 hunks)
• libs/ui-lib/lib/ocm/components/featureSupportLevels/ReviewClusterFeatureSupportLevels.tsx (4 hunks)

💤 Files with no reviewable changes (1)

• libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/InstallDisconnectedSwitch.tsx

🚧 Files skipped from review as they are similar to previous changes (4)

• libs/ui-lib/lib/ocm/components/featureSupportLevels/ReviewClusterFeatureSupportLevels.tsx
• libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/ReviewStep.tsx
• libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/BasicStep.tsx
• libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/OptionalConfigurationsStep.tsx

🧰 Additional context used

🧠 Learnings (2)

📚 Learning: 2025-10-21T04:40:36.292Z

Learnt from: linoyaslan
Repo: openshift-assisted/assisted-installer-ui PR: 3190
File: libs/ui-lib/lib/ocm/components/clusterConfiguration/networkConfiguration/AdvancedNetworkFields.tsx:55-63
Timestamp: 2025-10-21T04:40:36.292Z
Learning: In libs/ui-lib/lib/ocm/components/clusterConfiguration/networkConfiguration/AdvancedNetworkFields.tsx, the network reordering logic in the useEffect (swapping clusterNetworks and serviceNetworks based on the primary machine network's IP family) is for UI consistency only. Validation of empty or invalid CIDRs is handled separately by validation schemas, not by the reordering logic.

Applied to files:

• libs/ui-lib/lib/ocm/components/clusterWizard/ClusterDetailsForm.tsx

📚 Learning: 2025-10-20T08:57:04.935Z

Learnt from: linoyaslan
Repo: openshift-assisted/assisted-installer-ui PR: 3190
File: libs/ui-lib/lib/ocm/components/clusterDetail/ClusterProperties.tsx:43-45
Timestamp: 2025-10-20T08:57:04.935Z
Learning: In the file `libs/ui-lib/lib/ocm/components/clusterDetail/ClusterProperties.tsx`, the `getStackTypeLabel` function returns 'Dual-stack' or 'IPv4' because the system currently only supports IPv4 single-stack clusters. IPv6-only single-stack clusters are not supported.

Applied to files:

• libs/ui-lib/lib/ocm/components/clusterWizard/ClusterDetailsForm.tsx

🧬 Code graph analysis (2)

libs/ui-lib/lib/ocm/components/clusters/AssistedInstallerHeader.tsx (1)

libs/ui-lib/lib/common/components/ui/TechnologyPreview.tsx (1)

• TechnologyPreview (11-24)

libs/ui-lib/lib/ocm/components/clusterWizard/ClusterDetailsForm.tsx (1)

libs/ui-lib/lib/common/components/ui/TechnologyPreview.tsx (1)

• TechnologyPreview (11-24)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)

• GitHub Check: tests
• GitHub Check: translation-files
• GitHub Check: unit-tests
• GitHub Check: format
• GitHub Check: circular-deps
• GitHub Check: lint

🔇 Additional comments (2)

libs/ui-lib/lib/ocm/components/clusterWizard/ClusterDetailsForm.tsx (2)

4-4: PatternFly Grid import matches existing layout usage

Grid and GridItem are correctly imported and used for the wizard layout; no issues here.

---

14-14: TechnologyPreview import correctly replaces DeveloperPreview usage

Importing TechnologyPreview from the common UI library is consistent with the shared implementation and aligns this screen with the new Tech Preview badge behavior.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ElayAharoni, rawagner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [rawagner]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@ElayAharoni: This pull request references AGENT-1388 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

https://issues.redhat.com/browse/AGENT-1388

this pr fixes several requirements:

1. changing the shown version on the above sea level for OVE to 4.20 from 4.19
2. changing the label from Developer preview to Tech preview in the local ui and on saas
3. changing the cluster support level for OVE to be limited from fully supported

Summary by CodeRabbit

• New Features

• Support-level logic now respects the single-cluster feature flag, improving guidance and warnings.

• Inline AI-enabled informational text added for disconnected/air‑gapped installs.

• Refactor

• Branding updated from "DeveloperPreview" to "TechnologyPreview" across the UI.

• Layout simplified to a horizontal flex arrangement.

• OpenShift version display/usage updated to 4.20.

• Other

• Disconnected-install toggle label text removed.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Actionable comments posted: 1

♻️ Duplicate comments (3)

libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/ReviewStep.tsx (1)

133-133: Hard-coded version contradicts the stated dynamic approach.

The OpenShift version is still hard-coded as 4.20 rather than being derived from cluster.openshiftVersion or a shared helper, as mentioned in the AI summary. This creates inconsistency across BasicStep, ReviewStep, and OptionalConfigurationsStep, making future version updates error-prone.

Consider extracting the cluster object from useClusterWizardContext() and displaying cluster.openshiftVersion, or use a centralized helper that computes the version based on installDisconnected.

Based on past review comments, this issue was previously flagged but remains unresolved.

libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/BasicStep.tsx (1)

46-46: Hardcoded OpenShift version remains.

The version is still hardcoded to '4.20' in both the cluster creation and the UI display. While the developer acknowledged in past comments that no alternative extraction method exists currently, consider documenting this limitation or creating a constant to centralize the version value.

Consider extracting to a constant:

const DISCONNECTED_OPENSHIFT_VERSION = '4.20';

// Then use it:
openshiftVersion: DISCONNECTED_OPENSHIFT_VERSION,
// and
<OcmOpenShiftVersion openshiftVersion={DISCONNECTED_OPENSHIFT_VERSION} ...>

Also applies to: 101-101

libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/OptionalConfigurationsStep.tsx (1)

125-125: Add fallback for optional openshiftVersion field.

According to the Cluster interface (libs/types/assisted-installer-service.d.ts), openshiftVersion is optional. If it's undefined, the infraEnv creation will fail or pass an invalid value.

Apply this diff to add a fallback:

             const createParams = {
               name: `disconnected-cluster_infra-env`,
               pullSecret: values.pullSecret || pullSecret,
               clusterId: cluster.id,
-              openshiftVersion: cluster.openshiftVersion,
+              openshiftVersion: cluster.openshiftVersion || '4.20',
               cpuArchitecture: 'x86_64' as const,
               ...(values.sshPublicKey && { sshAuthorizedKey: values.sshPublicKey }),
             };

🧹 Nitpick comments (1)

libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/OptionalConfigurationsStep.tsx (1)

159-159: Remove or clarify outdated comment.

The comment "Changed from moveNext" is confusing. The actual change is using handleNext (which delegates to submitForm) instead of directly calling moveNext. Either remove the comment or clarify what was changed.

               <ClusterWizardFooter
                 disconnectedClusterId={clusterId}
-                onNext={handleNext} // Changed from moveNext
+                onNext={handleNext}
                 onBack={moveBack}
                 isNextDisabled={!isValid}

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a124b16 and 308bd1f.

📒 Files selected for processing (7)

• libs/ui-lib/lib/ocm/components/clusterWizard/ClusterDetailsForm.tsx (3 hunks)
• libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/BasicStep.tsx (3 hunks)
• libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/InstallDisconnectedSwitch.tsx (0 hunks)
• libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/OptionalConfigurationsStep.tsx (5 hunks)
• libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/ReviewStep.tsx (3 hunks)
• libs/ui-lib/lib/ocm/components/clusters/AssistedInstallerHeader.tsx (2 hunks)
• libs/ui-lib/lib/ocm/components/featureSupportLevels/ReviewClusterFeatureSupportLevels.tsx (4 hunks)

💤 Files with no reviewable changes (1)

• libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/InstallDisconnectedSwitch.tsx

🚧 Files skipped from review as they are similar to previous changes (2)

• libs/ui-lib/lib/ocm/components/clusterWizard/ClusterDetailsForm.tsx
• libs/ui-lib/lib/ocm/components/clusters/AssistedInstallerHeader.tsx

🧰 Additional context used

🧠 Learnings (2)

📚 Learning: 2025-10-21T04:40:36.292Z

Learnt from: linoyaslan
Repo: openshift-assisted/assisted-installer-ui PR: 3190
File: libs/ui-lib/lib/ocm/components/clusterConfiguration/networkConfiguration/AdvancedNetworkFields.tsx:55-63
Timestamp: 2025-10-21T04:40:36.292Z
Learning: In libs/ui-lib/lib/ocm/components/clusterConfiguration/networkConfiguration/AdvancedNetworkFields.tsx, the network reordering logic in the useEffect (swapping clusterNetworks and serviceNetworks based on the primary machine network's IP family) is for UI consistency only. Validation of empty or invalid CIDRs is handled separately by validation schemas, not by the reordering logic.

Applied to files:

• libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/OptionalConfigurationsStep.tsx

📚 Learning: 2025-05-22T07:31:16.062Z

Learnt from: rawagner
Repo: openshift-assisted/assisted-installer-ui PR: 2826
File: libs/ui-lib/lib/cim/components/YamlEditor/YamlEditor.tsx:50-61
Timestamp: 2025-05-22T07:31:16.062Z
Learning: The YamlEditor component in libs/ui-lib/lib/cim/components/YamlEditor/YamlEditor.tsx already handles YAML validation through the submitYamls function in utils.ts, which validates YAML syntax and throws user-friendly error messages if parsing fails.

Applied to files:

• libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/OptionalConfigurationsStep.tsx

🧬 Code graph analysis (4)

libs/ui-lib/lib/ocm/components/featureSupportLevels/ReviewClusterFeatureSupportLevels.tsx (3)

libs/types/assisted-installer-service.d.ts (1)

• SupportLevel (2642-2647)

libs/ui-lib/lib/common/components/newFeatureSupportLevels/NewFeatureSupportLevelContext.tsx (1)

• useNewFeatureSupportLevel (17-25)

libs/ui-lib/lib/ocm/components/clusterWizard/OpenShiftVersionsContext.tsx (1)

• useOpenShiftVersionsContext (125-131)

libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/ReviewStep.tsx (1)

libs/ui-lib/lib/common/components/ui/TechnologyPreview.tsx (1)

• TechnologyPreview (11-24)

libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/OptionalConfigurationsStep.tsx (2)

libs/types/assisted-installer-service.d.ts (1)

• Cluster (110-407)

libs/ui-lib/lib/common/components/ui/TechnologyPreview.tsx (1)

• TechnologyPreview (11-24)

libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/BasicStep.tsx (1)

libs/ui-lib/lib/common/components/ui/TechnologyPreview.tsx (1)

• TechnologyPreview (11-24)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)

• GitHub Check: circular-deps
• GitHub Check: unit-tests
• GitHub Check: translation-files
• GitHub Check: tests
• GitHub Check: lint
• GitHub Check: format

🔇 Additional comments (11)

libs/ui-lib/lib/ocm/components/featureSupportLevels/ReviewClusterFeatureSupportLevels.tsx (3)

26-26: LGTM!

The useFeature hook import is correctly added and used within the SupportLevel component.

---

126-147: LGTM!

The optional isSingleClusterFeatureEnabled parameter maintains backward compatibility while correctly implementing the support-level logic. When the single-cluster feature is enabled, isFullySupported is forced to false, aligning with the PR objective to change the cluster support level to "limited" for this feature.

---

149-172: LGTM!

The useFeature hook is correctly called at the component's top level, and all dependencies for useMemo are properly included. The feature flag is correctly threaded through to getSupportLevelInfo.

libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/ReviewStep.tsx (2)

4-9: LGTM—Import update aligns with PR objectives.

The import change from DeveloperPreview to TechnologyPreview correctly reflects the PR's goal to rebrand the feature status indicator.

---

100-100: LGTM—TechnologyPreview component correctly integrated.

The component replacement is implemented correctly and displays the updated Tech Preview badge as intended.

libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/OptionalConfigurationsStep.tsx (3)

6-6: LGTM: Import updates align with PR objectives.

The transition from DeveloperPreview to TechnologyPreview and the addition of the Cluster type import support the rebranding and dynamic version handling.

Also applies to: 27-27

---

49-49: Good improvement: Properly typed cluster state.

Changing from { id: string } | null to Cluster | null provides full type safety and access to all cluster properties.

---

176-176: LGTM: TechnologyPreview component usage.

The replacement of DeveloperPreview with TechnologyPreview is consistent with the PR objectives.

libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/BasicStep.tsx (3)

4-4: LGTM: Import updates support layout and branding changes.

The transition to TechnologyPreview and the addition of Flex (while removing Split/SplitItem) align with the PR's layout refactoring and rebranding objectives.

Also applies to: 10-10

---

88-97: Good refactor: Flex-based layout improves structure.

The migration from Split/SplitItem to Flex with proper alignment and gap properties creates a cleaner, more maintainable layout for the header row containing the preview badge, switch, and descriptive text.

---

92-92: LGTM: TechnologyPreview component usage.

The replacement of DeveloperPreview with TechnologyPreview is consistent with the PR objectives and properly integrated into the new Flex layout.

[ElayAharoni]

/cherry-pick release-4.20

[openshift-cherrypick-robot]

@ElayAharoni: #3293 failed to apply on top of branch "release-4.20":

Applying: Adding TechPreview Budge for Assisted installer and agent
Using index info to reconstruct a base tree...
M	libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/BasicStep.tsx
A	libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/OptionalConfigurationsStep.tsx
M	libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/ReviewStep.tsx
M	libs/ui-lib/lib/ocm/components/clusters/AssistedInstallerHeader.tsx
M	libs/ui-lib/lib/ocm/components/featureSupportLevels/ReviewClusterFeatureSupportLevels.tsx
Falling back to patching base and 3-way merge...
Auto-merging libs/ui-lib/lib/ocm/components/featureSupportLevels/ReviewClusterFeatureSupportLevels.tsx
Auto-merging libs/ui-lib/lib/ocm/components/clusters/AssistedInstallerHeader.tsx
CONFLICT (content): Merge conflict in libs/ui-lib/lib/ocm/components/clusters/AssistedInstallerHeader.tsx
Auto-merging libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/ReviewStep.tsx
CONFLICT (modify/delete): libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/OptionalConfigurationsStep.tsx deleted in HEAD and modified in Adding TechPreview Budge for Assisted installer and agent. Version Adding TechPreview Budge for Assisted installer and agent of libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/OptionalConfigurationsStep.tsx left in tree.
Auto-merging libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/BasicStep.tsx
CONFLICT (content): Merge conflict in libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/BasicStep.tsx
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Adding TechPreview Budge for Assisted installer and agent

Details

In response to this:

/cherry-pick release-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ElayAharoni]

/cherry-pick releases/v2.48

[openshift-cherrypick-robot]

@ElayAharoni: new pull request created: #3328

Details

In response to this:

/cherry-pick releases/v2.48

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.