Add dev preview badge to disconnected switch#3132
Add dev preview badge to disconnected switch#3132openshift-merge-bot[bot] merged 1 commit intoopenshift-assisted:masterfrom
Conversation
WalkthroughThe UI in ClusterDetailsForm.tsx now wraps InstallDisconnectedSwitch and a newly added DeveloperPreview component in a PatternFly Split layout when the single-cluster feature flag is disabled. Imports were updated to include Split, SplitItem, and DeveloperPreview. DeveloperPreview is newly exported from the common module. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant User
participant ClusterDetailsForm
participant InstallDisconnectedSwitch
participant DeveloperPreview
User->>ClusterDetailsForm: Open form
alt single-cluster feature disabled
ClusterDetailsForm->>ClusterDetailsForm: Render PatternFly Split
ClusterDetailsForm->>InstallDisconnectedSwitch: Render switch (left)
ClusterDetailsForm->>DeveloperPreview: Render badge/info (right)
else enabled
ClusterDetailsForm->>InstallDisconnectedSwitch: Render switch only
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
openshift-ci
bot
added
approved
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
libs/ui-lib/lib/ocm/components/clusterWizard/ClusterDetailsForm.tsx (1)
170-177: Add Split spacing so the switch and badge aren’t flush.PatternFly Split renders items adjacent by default. Adding hasGutter improves readability and matches PF guidelines. Optionally, insert a filled spacer to push the badge to the far right if desired.
Minimal spacing improvement:
- <Split> + <Split hasGutter> <SplitItem> <InstallDisconnectedSwitch isDisabled={!!cluster} /> </SplitItem> <SplitItem> <DeveloperPreview /> </SplitItem> - </Split> + </Split>Optional right-align the badge (if that’s the intended layout):
- <Split hasGutter> - <SplitItem> + <Split hasGutter> + <SplitItem> <InstallDisconnectedSwitch isDisabled={!!cluster} /> </SplitItem> + <SplitItem isFilled /> <SplitItem> <DeveloperPreview /> </SplitItem> </Split>
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
libs/ui-lib/lib/ocm/components/clusterWizard/ClusterDetailsForm.tsx(3 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
libs/ui-lib/lib/ocm/components/clusterWizard/ClusterDetailsForm.tsx (1)
libs/ui-lib/lib/common/components/ui/DeveloperPreview.tsx (1)
DeveloperPreview(8-20)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
- GitHub Check: translation-files
- GitHub Check: circular-deps
- GitHub Check: tests
- GitHub Check: unit-tests
- GitHub Check: lint
- GitHub Check: format
🔇 Additional comments (2)
libs/ui-lib/lib/ocm/components/clusterWizard/ClusterDetailsForm.tsx (2)
4-4: LGTM: PatternFly Split/SplitItem imports look correct.The additional imports from '@patternfly/react-core' match the usage below. No issues here.
15-15: DeveloperPreview barrel export verified – no action neededDeveloperPreview is defined in
libs/ui-lib/lib/common/components/ui/DeveloperPreview.tsxand re-exported in the common barrel (libs/ui-lib/lib/common/index.ts), so importing it from../../../commonwill work as expected.
|
/cherry-pick releases/v2.44 |
|
@rawagner: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: celdrake, rawagner The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 3e1f97f
into
openshift-assisted:master
|
@rawagner: new pull request created: #3135 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
3 participants
Summary by CodeRabbit