Skip to content

Remove back button from first page#3120

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift-assisted:masterfrom
rawagner:remove_back
Aug 14, 2025
Merged

Remove back button from first page#3120
openshift-merge-bot[bot] merged 1 commit intoopenshift-assisted:masterfrom
rawagner:remove_back

Conversation

@rawagner
Copy link
Copy Markdown
Member

@rawagner rawagner commented Aug 14, 2025

Summary by CodeRabbit

  • Refactor
    • Simplified navigation in the Cluster Wizard’s Disconnected Basic step: the Back action has been removed.
    • The footer now only presents a Next action for forward progression on this step.
    • Users can no longer navigate backward from this specific step, resulting in a more streamlined flow.
    • No other steps are affected; standard navigation remains elsewhere in the wizard.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 14, 2025
@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Aug 14, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Aug 14, 2025

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these settings in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 134a52a and 67d5f5b.

📒 Files selected for processing (1)
  • libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/BasicStep.tsx (2 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/BasicStep.tsx (1)
libs/ui-lib/lib/ocm/components/clusterWizard/ClusterWizardContext.tsx (1)
  • useClusterWizardContext (27-33)
🔇 Additional comments (2)
libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/BasicStep.tsx (2)

30-30: Context destructuring updated to drop moveBack — aligns with PR objective

Only pulling installDisconnected, setInstallDisconnected, and moveNext is correct for removing back navigation on this step.


41-41: ClusterWizardFooter hides Back when onBack is omitted — confirmed

WizardFooter only renders the Back button when onBack is truthy; ClusterWizardFooter forwards props via {...rest}, and the BasicStep call passes only onNext — so the Back button will be hidden. No change required.

  • libs/ui-lib/lib/common/components/ui/WizardFooter.tsx — Back is rendered guarded by {onBack && (...)}.
  • libs/ui-lib/lib/ocm/components/clusterWizard/ClusterWizardFooter.tsx — forwards {...rest} into <WizardFooter ... />.
  • libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/BasicStep.tsx — call site: footer={<ClusterWizardFooter onNext={moveNext} />} (no onBack).
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 14, 2025
@rawagner rawagner marked this pull request as ready for review August 14, 2025 11:56
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 14, 2025
@openshift-ci openshift-ci bot requested review from batzionb and jgyselov August 14, 2025 11:56
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 14, 2025
@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Aug 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ammont82, rawagner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 2f66f10 into openshift-assisted:master Aug 14, 2025
18 checks passed
@rawagner
Copy link
Copy Markdown
Member Author

/cherry-pick releases/v2.44

@openshift-cherrypick-robot
Copy link
Copy Markdown
Contributor

@rawagner: new pull request created: #3121

Details

In response to this:

/cherry-pick releases/v2.44

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants