Skip to content

MGMT-22579: Tech Preview badge should appear at the end of the line#3461

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift-assisted:masterfrom
ElayAharoni:Tech-Preview-badge-should-appear-at-the-end-of-the-line
Mar 18, 2026
Merged

MGMT-22579: Tech Preview badge should appear at the end of the line#3461
openshift-merge-bot[bot] merged 1 commit intoopenshift-assisted:masterfrom
ElayAharoni:Tech-Preview-badge-should-appear-at-the-end-of-the-line

Conversation

@ElayAharoni
Copy link
Contributor

@ElayAharoni ElayAharoni commented Mar 17, 2026

https://redhat.atlassian.net/browse/MGMT-22579

this is after the fix

image image

Summary by CodeRabbit

  • Improvements
    • Expanded OpenShift platform compatibility to support versions starting from 4.19 and later.
    • Refined cluster configuration wizard layout: moved the Technology Preview element to follow the explanatory text and the disconnected install switch for clearer visual flow in the Cluster Details and Basic disconnected steps.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 17, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 17, 2026

@ElayAharoni: This pull request references MGMT-22579 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

https://redhat.atlassian.net/browse/MGMT-22579

this is after the fix

image image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from LiorSoffer and asmasarw March 17, 2026 15:18
@coderabbitai
Copy link

coderabbitai bot commented Mar 17, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: dfa06c69-1e62-42da-aeee-ca210494abf4

📥 Commits

Reviewing files that changed from the base of the PR and between c60fa86 and 229901b.

📒 Files selected for processing (2)
  • libs/ui-lib/lib/ocm/components/clusterWizard/ClusterDetailsForm.tsx
  • libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/BasicStep.tsx
🚧 Files skipped from review as they are similar to previous changes (1)
  • libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/BasicStep.tsx

📝 Walkthrough

Walkthrough

Reorders the TechnologyPreview component placement within two cluster wizard form files (ClusterDetailsForm.tsx and disconnected/BasicStep.tsx); no other logic or conditional rendering changes detected. (≤50 words)

Changes

Cohort / File(s) Summary
Cluster Details Form Layout
libs/ui-lib/lib/ocm/components/clusterWizard/ClusterDetailsForm.tsx
Moved TechnologyPreview within the same Flex row to render after the explanatory text/span instead of before InstallDisconnectedSwitch.
Disconnected Basic Step Layout
libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/BasicStep.tsx
Reordered TechnologyPreview to follow the InstallDisconnectedSwitch and its descriptive text inside the Flex row; no conditional logic changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested labels

lgtm, approved

Suggested reviewers

  • rawagner
  • ammont82

Poem

🐰 I nudged a preview, hopped aside with cheer,
Rows align tidier, the layout's clear,
A tiny shuffle, no fuss, no fright,
Components settle snug and light,
Hooray for small hops that make things right!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: repositioning the Tech Preview badge to appear at the end of the line, which matches the file summaries showing TechnologyPreview component reordering.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 17, 2026
Signed-off-by: Elay Aharoni <elayaha@gmail.com>
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 17, 2026

@ElayAharoni: This pull request references MGMT-22579 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

https://redhat.atlassian.net/browse/MGMT-22579

this is after the fix

image image

Summary by CodeRabbit

  • Improvements
  • Expanded OpenShift platform compatibility to support versions starting from 4.19 and later.
  • Enhanced cluster configuration wizard interface layout for improved visual clarity and user experience.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ElayAharoni ElayAharoni force-pushed the Tech-Preview-badge-should-appear-at-the-end-of-the-line branch from c60fa86 to 229901b Compare March 17, 2026 15:21
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 17, 2026

@ElayAharoni: This pull request references MGMT-22579 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

https://redhat.atlassian.net/browse/MGMT-22579

this is after the fix

image image

Summary by CodeRabbit

  • Improvements
  • Expanded OpenShift platform compatibility to support versions starting from 4.19 and later.
  • Refined cluster configuration wizard layout: moved the Technology Preview element to follow the explanatory text and the disconnected install switch for clearer visual flow in the Cluster Details and Basic disconnected steps.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 18, 2026
@openshift-ci
Copy link

openshift-ci bot commented Mar 18, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ElayAharoni, rawagner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2026
@openshift-merge-bot openshift-merge-bot bot merged commit 07034c3 into openshift-assisted:master Mar 18, 2026
14 checks passed
@ElayAharoni
Copy link
Contributor Author

/cherry-pick release-4.21

@openshift-cherrypick-robot
Copy link
Contributor

@ElayAharoni: #3461 failed to apply on top of branch "release-4.21":

Applying: Tech Preview badge should appear at the end of the line
Using index info to reconstruct a base tree...
M	libs/ui-lib/lib/ocm/components/clusterWizard/ClusterDetailsForm.tsx
M	libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/BasicStep.tsx
Falling back to patching base and 3-way merge...
Auto-merging libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/BasicStep.tsx
CONFLICT (content): Merge conflict in libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/BasicStep.tsx
Auto-merging libs/ui-lib/lib/ocm/components/clusterWizard/ClusterDetailsForm.tsx
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 Tech Preview badge should appear at the end of the line

Details

In response to this:

/cherry-pick release-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants