OCPBUGS-65657: Display OpenShift AI GPU validation message from API

[yoavsc0302]

Fix UI to show the friendly label and detailed message from the API instead of displaying the technical validation ID when OpenShift AI operator is selected without GPU support.

Summary by CodeRabbit

• New Features
  • Added UI support and label text for validating OpenShift AI GPU requirements during cluster configuration and review.
• Bug Fixes / Improvements
  • Validation review suggestions updated so GPU requirement checks trigger the same fix guidance as related platform requirements.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[openshift-ci-robot]

@yoavsc0302: This pull request references Jira Issue OCPBUGS-65657, which is invalid:

• expected the bug to target the "4.21.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Fix UI to show the friendly label and detailed message from the API instead of displaying the technical validation ID when OpenShift AI operator is selected without GPU support.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Walkthrough

Adds support for a new cluster validation ID openshift-ai-gpu-requirements-satisfied: a translation entry was added, review validation logic was extended to recognize the new ID, and a label mapping was added to cluster validation constants.

Changes

Cohort / File(s)	Summary
Translation Addition libs/locales/lib/en/translation.json	Inserted translation key ai:OpenShift AI GPU requirements with value "OpenShift AI GPU requirements".
Validation Logic libs/ui-lib/lib/common/components/clusterWizard/ReviewValidations.tsx	Extended failing-validation fix suggestion to also match openshift-ai-gpu-requirements-satisfied alongside the existing platform-requirements-satisfied ID.
Validation Configuration libs/ui-lib/lib/common/config/constants.ts	Added openshift-ai-gpu-requirements-satisfied entry to clusterValidationLabels, using t('ai:OpenShift AI GPU requirements') for its label.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

• Files are localized and configuration additions with a small, consistent pattern.
• Pay attention to:
  • Consistent usage of the new validation ID string across files.
  • Proper i18n key formatting and placement in translation.json.
  • Any linter/type errors after adding the constant and UI change.

Possibly related PRs

• MGMT-20897: Add new Openshift AI - no GPU validation #3055 — Adds and wires the same openshift-ai-gpu-requirements-satisfied validation ID across translations, labels, and validation handling.
• MGMT-22279: add loki and logging operators #3285 — Modifies localization and validation-label infrastructure; touches similar files (translation.json, validation label constants).

Suggested labels

lgtm, approved, size/M, jira/valid-bug

Suggested reviewers

• ammont82
• jgyselov
• ElayAharoni

Poem

🐰 A tiny change hopped into place with delight,
Labels and words joined the validation light,
GPUs now whispered their careful demand,
Translated and mapped by a busy little hand,
Hooray — cluster checks snug for their flight! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and specifically describes the main change: displaying OpenShift AI GPU validation messages from the API instead of technical IDs.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c8c9adf and 21ef864.

📒 Files selected for processing (2)

• libs/locales/lib/en/translation.json (1 hunks)
• libs/ui-lib/lib/common/config/constants.ts (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• libs/locales/lib/en/translation.json

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)

• GitHub Check: unit-tests
• GitHub Check: translation-files
• GitHub Check: tests
• GitHub Check: circular-deps
• GitHub Check: format
• GitHub Check: lint

🔇 Additional comments (1)

libs/ui-lib/lib/common/config/constants.ts (1)

254-254: New OpenShift AI GPU cluster validation label is wired correctly

Mapping openshift-ai-gpu-requirements-satisfied to t('ai:OpenShift AI GPU requirements') is consistent with existing operator validation labels and will ensure the UI shows a friendly label instead of the raw ID, assuming the backend validation ID and translation key match exactly.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

libs/ui-lib/lib/common/components/clusterWizard/ReviewValidations.tsx (1)

111-116: Logic correctly extended to support new validation ID.

The change properly enables the API message to be displayed for the new openshift-ai-gpu-requirements-satisfied validation ID, alongside the existing platform-requirements-satisfied.

Consider extracting the hardcoded validation IDs into a constant array for better maintainability:

+const VALIDATIONS_WITH_API_MESSAGE: Array<ClusterValidationId> = [
+  'platform-requirements-satisfied',
+  'openshift-ai-gpu-requirements-satisfied',
+];
+
 ...
-  if (
-    validation.id === 'platform-requirements-satisfied' ||
-    validation.id === 'openshift-ai-gpu-requirements-satisfied'
-  ) {
+  if (VALIDATIONS_WITH_API_MESSAGE.includes(validation.id as ClusterValidationId)) {
     fix = validation.message;
   }

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 713ce38 and c8c9adf.

📒 Files selected for processing (3)

• libs/locales/lib/en/translation.json (1 hunks)
• libs/ui-lib/lib/common/components/clusterWizard/ReviewValidations.tsx (1 hunks)
• libs/ui-lib/lib/common/config/constants.ts (1 hunks)

🧰 Additional context used

🧠 Learnings (2)

📚 Learning: 2025-09-02T08:03:57.204Z

Learnt from: jgyselov
Repo: openshift-assisted/assisted-installer-ui PR: 3151
File: libs/ui-lib/lib/cim/components/ClusterDeployment/constants.ts:25-25
Timestamp: 2025-09-02T08:03:57.204Z
Learning: In the openshift-assisted/assisted-installer-ui repository, non-English translations are handled separately from the main development process. When adding new translation keys to English locale files, it's expected that non-English locale files (es, fr, ja, ko, zh) may not immediately contain the corresponding translations, as these are managed through a different workflow.

Applied to files:

• libs/locales/lib/en/translation.json

📚 Learning: 2025-10-21T04:40:36.292Z

Learnt from: linoyaslan
Repo: openshift-assisted/assisted-installer-ui PR: 3190
File: libs/ui-lib/lib/ocm/components/clusterConfiguration/networkConfiguration/AdvancedNetworkFields.tsx:55-63
Timestamp: 2025-10-21T04:40:36.292Z
Learning: In libs/ui-lib/lib/ocm/components/clusterConfiguration/networkConfiguration/AdvancedNetworkFields.tsx, the network reordering logic in the useEffect (swapping clusterNetworks and serviceNetworks based on the primary machine network's IP family) is for UI consistency only. Validation of empty or invalid CIDRs is handled separately by validation schemas, not by the reordering logic.

Applied to files:

• libs/ui-lib/lib/common/components/clusterWizard/ReviewValidations.tsx

🔇 Additional comments (2)

libs/locales/lib/en/translation.json (1)

636-636: LGTM! Translation entry properly added.

The new translation key for OpenShift AI GPU requirements is correctly formatted and appropriately placed. As per learnings, non-English locale files will be updated through a separate workflow.

libs/ui-lib/lib/common/config/constants.ts (1)

250-250: LGTM! Validation label mapping correctly added.

The new cluster validation label mapping for openshift-ai-gpu-requirements-satisfied is properly formatted and consistently references the translation key added in the locales file. The placement near related validation entries enhances code organization.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ammont82, yoavsc0302

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [ammont82]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[yoavsc0302]

/jira refresh

[openshift-ci-robot]

@yoavsc0302: This pull request references Jira Issue OCPBUGS-65657, which is invalid:

• expected the bug to target the "4.21.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[yoavsc0302]

/jira refresh

[openshift-ci-robot]

@yoavsc0302: This pull request references Jira Issue OCPBUGS-65657, which is invalid:

• expected the bug to target the "4.21.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[yoavsc0302]

/jira refresh

[openshift-ci-robot]

@yoavsc0302: This pull request references Jira Issue OCPBUGS-65657, which is invalid:

• expected the bug to target the "4.21.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[yoavsc0302]

/jira refresh

[openshift-ci-robot]

@yoavsc0302: This pull request references Jira Issue OCPBUGS-65657, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.21.0) matches configured target version for branch (4.21.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (mburman@redhat.com), skipping review request.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@yoavsc0302: Jira Issue OCPBUGS-65657: All pull requests linked via external trackers have merged:

• openshift-assisted/assisted-installer-ui#3279

Jira Issue OCPBUGS-65657 has been moved to the MODIFIED state.

Details

In response to this:

Fix UI to show the friendly label and detailed message from the API instead of displaying the technical validation ID when OpenShift AI operator is selected without GPU support.

Summary by CodeRabbit

• New Features
• Added UI support and label text for validating OpenShift AI GPU requirements during cluster configuration and review.
• Bug Fixes / Improvements
• Validation review suggestions updated so GPU requirement checks trigger the same fix guidance as related platform requirements.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.