Different bugs related with dual-stack with ipv4/ipv6

[ammont82]

• https://issues.redhat.com/browse/MGMT-22057 :Primary IPv6 should be Tech Preview
• https://issues.redhat.com/browse/MGMT-22045: Change style of Dualstack - IPv4 / IPv6 section headers in subnet dropdown
• When we change the primary machine network IP to ipv6 we have to select the seconday machine network IP to ipv4

changes_dualstack.mp4

Summary by CodeRabbit

• New Features

  • Visual divider between IPv4 and IPv6 subnet groups for clearer organization.
  • Technology Preview badge for IPv6 subnets to signal preview status.
  • Default subnet display now prefers the second item when available for more relevant selection.

• Bug Fixes

  • Badge clicks no longer toggle the menu, preventing accidental menu opens.

• Style

  • Improved inline alignment of the badge within the menu toggle.

[coderabbitai]

Walkthrough

SubnetsDropdown: adds a visual divider between IPv4/IPv6 groups, relabels IPv6 as "IPv6 (Technology Preview)", adjusts display-value initialization, and shows a TechnologyPreview badge on the MenuToggle when an IPv6 subnet is selected (badge click does not toggle the menu).

Changes

Cohort / File(s)

Summary

SubnetsDropdown component libs/ui-lib/lib/ocm/components/clusterConfiguration/networkConfiguration/SubnetsDropdown.tsx

Imported Divider, TechnologyPreview, and PreviewBadgePosition; inserted a Divider between IPv4 and IPv6 groups when both exist; updated IPv6 group label to "IPv6 (Technology Preview)"; changed initial currentDisplayValue selection to prefer the second item when present; added currentItem and showBadge logic to detect IPv6 selection; rendered a TechnologyPreview badge inline in the MenuToggle and stopped click propagation on the badge to avoid toggling.

Sequence Diagram(s)

sequenceDiagram
  participant UI as SubnetsDropdown
  participant Menu as MenuToggle
  participant List as SubnetMenuList

  UI->>List: render groups (IPv4, Divider?, IPv6 label "IPv6 (Technology Preview)")
  List-->>UI: items
  UI->>Menu: compute currentDisplayValue / currentItem
  alt currentItem is IPv6
    UI->>Menu: render MenuToggle with TechnologyPreview badge (stopPropagation on badge)
    Menu->>User: shows badge and selected IPv6 label
  else currentItem is IPv4 or none
    UI->>Menu: render MenuToggle without badge
    Menu->>User: shows selected IPv4 label
  end

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

• Check the index change for currentDisplayValue correctly accounts for any placeholder items.
• Verify showBadge reliably detects IPv6 subnets across edge cases (empty lists, single-item lists).
• Confirm click propagation is stopped on the badge and MenuToggle behavior remains correct.
• Validate PatternFly component imports and props match the project version.

Possibly related PRs

• MGMT-20895: Use humanized label for displaying the selected subnet #3015 — modifies SubnetsDropdown current display value derivation; directly related to the display-value logic changes.
• MGMT-21835: Dual-stack: duplicate data-testid on subnet dropdown toggles #3199 — modifies MenuToggle usage in SubnetsDropdown; related to toggle rendering/props alongside the badge/divider changes.

Suggested labels

lgtm, jira/valid-reference

Suggested reviewers

• jgyselov
• rawagner
• celdrake

Poem

🐰 I hopped into code with a twitch of my nose,
Split IPv4 and IPv6 with a soft little pose.
A preview badge gleams on the toggle so bright,
Divider and label—now everything's right.
🥕✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title "Different bugs related with dual-stack with ipv4/ipv6" is partially related to the changeset. It accurately refers to dual-stack IPv4/IPv6 as the problem domain, which aligns with the actual changes addressing multiple dual-stack related issues (Technology Preview badge for IPv6, Divider between IPv4/IPv6 sections, label updates, and subnet selection behavior changes). While the title could be more specific about what particular issues are being fixed or what UI improvements are being implemented, it does correctly identify the main technical area being addressed rather than being misleading or off-topic.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a663327 and 65ad5c5.

📒 Files selected for processing (1)

• libs/ui-lib/lib/ocm/components/clusterConfiguration/networkConfiguration/SubnetsDropdown.tsx (6 hunks)

🧰 Additional context used

🧠 Learnings (3)

📚 Learning: 2025-10-21T04:40:36.292Z

Learnt from: linoyaslan
Repo: openshift-assisted/assisted-installer-ui PR: 3190
File: libs/ui-lib/lib/ocm/components/clusterConfiguration/networkConfiguration/AdvancedNetworkFields.tsx:55-63
Timestamp: 2025-10-21T04:40:36.292Z
Learning: In libs/ui-lib/lib/ocm/components/clusterConfiguration/networkConfiguration/AdvancedNetworkFields.tsx, the network reordering logic in the useEffect (swapping clusterNetworks and serviceNetworks based on the primary machine network's IP family) is for UI consistency only. Validation of empty or invalid CIDRs is handled separately by validation schemas, not by the reordering logic.

Applied to files:

• libs/ui-lib/lib/ocm/components/clusterConfiguration/networkConfiguration/SubnetsDropdown.tsx

📚 Learning: 2025-10-21T04:53:07.362Z

Learnt from: linoyaslan
Repo: openshift-assisted/assisted-installer-ui PR: 3190
File: libs/ui-lib/lib/ocm/components/clusterConfiguration/networkConfiguration/StackTypeControl.tsx:71-91
Timestamp: 2025-10-21T04:53:07.362Z
Learning: In libs/ui-lib/lib/ocm/components/clusterConfiguration/networkConfiguration/StackTypeControl.tsx, dual-stack mode requires both IPv4 and IPv6 networks (machineNetworks must have at least 2 entries: one IPv4 and one IPv6). Dual-stack with only IPv6 is not supported—dual-stack must have both IP families present.

Applied to files:

• libs/ui-lib/lib/ocm/components/clusterConfiguration/networkConfiguration/SubnetsDropdown.tsx

📚 Learning: 2025-10-20T08:57:04.935Z

Learnt from: linoyaslan
Repo: openshift-assisted/assisted-installer-ui PR: 3190
File: libs/ui-lib/lib/ocm/components/clusterDetail/ClusterProperties.tsx:43-45
Timestamp: 2025-10-20T08:57:04.935Z
Learning: In the file `libs/ui-lib/lib/ocm/components/clusterDetail/ClusterProperties.tsx`, the `getStackTypeLabel` function returns 'Dual-stack' or 'IPv4' because the system currently only supports IPv4 single-stack clusters. IPv6-only single-stack clusters are not supported.

Applied to files:

• libs/ui-lib/lib/ocm/components/clusterConfiguration/networkConfiguration/SubnetsDropdown.tsx

🧬 Code graph analysis (1)

libs/ui-lib/lib/ocm/components/clusterConfiguration/networkConfiguration/SubnetsDropdown.tsx (1)

libs/ui-lib/lib/common/components/ui/TechnologyPreview.tsx (1)

• TechnologyPreview (11-24)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)

• GitHub Check: format
• GitHub Check: tests
• GitHub Check: lint
• GitHub Check: unit-tests

🔇 Additional comments (3)

libs/ui-lib/lib/ocm/components/clusterConfiguration/networkConfiguration/SubnetsDropdown.tsx (3)

72-73: Confirmed: Array index bounds issue resolved.

The conditional check correctly prevents the out-of-bounds error flagged in the previous review. When no subnets are available (itemsSubnets.length === 1), index 0 is used; otherwise, index 1 (the first actual subnet) is used as the initial display value.

---

111-111: Visual improvements look good.

The Divider at the end of the IPv4 group and the "IPv6 (Technology Preview)" label correctly implement the style changes outlined in MGMT-22045 and MGMT-22057. The structure provides clear visual separation between IP stack types in dual-stack mode.

Also applies to: 127-132

---

149-150: Technology Preview badge implementation is correct.

The logic properly detects IPv6 subnet selection and displays the badge. The stopPropagation on line 165 correctly prevents the badge from triggering the dropdown toggle, maintaining expected UX.

Also applies to: 164-168

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[ammont82]

/cherry-pick releases/v2.47

[openshift-cherrypick-robot]

@ammont82: once the present PR merges, I will cherry-pick it on top of releases/v2.47 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick releases/v2.47

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[coderabbitai]

Actionable comments posted: 2

🧹 Nitpick comments (1)

libs/ui-lib/lib/ocm/components/clusterConfiguration/networkConfiguration/SubnetsDropdown.tsx (1)

149-153: LGTM with optional simplification.

The logic correctly determines whether to show the Technology Preview badge by checking if the current subnet is IPv6.

The Boolean() wrapper is redundant since Address6.isValid() already returns a boolean:

-  const showBadge = Boolean(currentItem && Address6.isValid(currentItem.value));
+  const showBadge = !!currentItem && Address6.isValid(currentItem.value);

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4c95b55 and a663327.

📒 Files selected for processing (1)

• libs/ui-lib/lib/ocm/components/clusterConfiguration/networkConfiguration/SubnetsDropdown.tsx (7 hunks)

🧰 Additional context used

🧠 Learnings (3)

📚 Learning: 2025-10-21T04:40:36.292Z

Learnt from: linoyaslan
Repo: openshift-assisted/assisted-installer-ui PR: 3190
File: libs/ui-lib/lib/ocm/components/clusterConfiguration/networkConfiguration/AdvancedNetworkFields.tsx:55-63
Timestamp: 2025-10-21T04:40:36.292Z
Learning: In libs/ui-lib/lib/ocm/components/clusterConfiguration/networkConfiguration/AdvancedNetworkFields.tsx, the network reordering logic in the useEffect (swapping clusterNetworks and serviceNetworks based on the primary machine network's IP family) is for UI consistency only. Validation of empty or invalid CIDRs is handled separately by validation schemas, not by the reordering logic.

Applied to files:

• libs/ui-lib/lib/ocm/components/clusterConfiguration/networkConfiguration/SubnetsDropdown.tsx

📚 Learning: 2025-10-21T04:53:07.362Z

Learnt from: linoyaslan
Repo: openshift-assisted/assisted-installer-ui PR: 3190
File: libs/ui-lib/lib/ocm/components/clusterConfiguration/networkConfiguration/StackTypeControl.tsx:71-91
Timestamp: 2025-10-21T04:53:07.362Z
Learning: In libs/ui-lib/lib/ocm/components/clusterConfiguration/networkConfiguration/StackTypeControl.tsx, dual-stack mode requires both IPv4 and IPv6 networks (machineNetworks must have at least 2 entries: one IPv4 and one IPv6). Dual-stack with only IPv6 is not supported—dual-stack must have both IP families present.

Applied to files:

• libs/ui-lib/lib/ocm/components/clusterConfiguration/networkConfiguration/SubnetsDropdown.tsx

📚 Learning: 2025-10-20T08:57:04.935Z

Learnt from: linoyaslan
Repo: openshift-assisted/assisted-installer-ui PR: 3190
File: libs/ui-lib/lib/ocm/components/clusterDetail/ClusterProperties.tsx:43-45
Timestamp: 2025-10-20T08:57:04.935Z
Learning: In the file `libs/ui-lib/lib/ocm/components/clusterDetail/ClusterProperties.tsx`, the `getStackTypeLabel` function returns 'Dual-stack' or 'IPv4' because the system currently only supports IPv4 single-stack clusters. IPv6-only single-stack clusters are not supported.

Applied to files:

• libs/ui-lib/lib/ocm/components/clusterConfiguration/networkConfiguration/SubnetsDropdown.tsx

🧬 Code graph analysis (1)

libs/ui-lib/lib/ocm/components/clusterConfiguration/networkConfiguration/SubnetsDropdown.tsx (1)

libs/ui-lib/lib/common/components/ui/TechnologyPreview.tsx (1)

• TechnologyPreview (11-24)

🔇 Additional comments (5)

libs/ui-lib/lib/ocm/components/clusterConfiguration/networkConfiguration/SubnetsDropdown.tsx (5)

10-10: LGTM!

The new imports are properly used: Divider for visual separation between IPv4/IPv6 groups, and TechnologyPreview/PreviewBadgePosition for the badge when IPv6 is selected.

Also applies to: 13-19

---

111-111: LGTM!

The divider provides clear visual separation between IPv4 and IPv6 subnet groups, aligning with the PR objective to improve the dual-stack dropdown style.

---

130-130: LGTM!

The label correctly identifies IPv6 as a Technology Preview feature, aligning with the MGMT-22057 requirement.

---

167-171: LGTM!

The badge is properly rendered inline when an IPv6 subnet is selected, and stopPropagation correctly prevents the dropdown from toggling when the badge is clicked.

---

51-187: No additional changes needed for dual-stack IPv4/IPv6 enforcement.

The PR objective regarding IPv4/IPv6 selection is already implemented. When switching to dual-stack mode, StackTypeControl automatically enforces IPv4 as primary: if the first machine network is IPv6, it adds IPv4 as secondary; if first is IPv4, it adds IPv6 as secondary. Additionally, AvailableSubnetsControl implements smart filtering where the secondary machine network subnet dropdown only shows IPv4 options if the primary is IPv6, and vice versa. SubnetsDropdown receives pre-filtered subnets from its parent component and correctly displays them with IP family grouping.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ammont82, rawagner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [ammont82,rawagner]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-cherrypick-robot]

@ammont82: new pull request created: #3236

Details

In response to this:

/cherry-pick releases/v2.47

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.