MGMT-17220: dual-stack with second machine network not populates

[ammont82]

Related to https://issues.redhat.com/browse/MGMT-22120
When we switch machine network primary to ipv6 , machine network changed and the seconday updated (as expected)

But there is an error message after modifying api and ingress related to the seconday .. while the addresses are valid.
To solve the error in UI we must refresh the seconday machine network.

dual_stack_changes.mp4

Summary by CodeRabbit

• Improvements
  • Enhanced IP and VIP validation to enforce address family, uniqueness, and subnet alignment across machine networks (including stricter checks for IPv4/IPv6 and dual-stack scenarios).
  • Dual-stack behavior improved to prevent duplicate subnet assignments by auto-selecting or clearing secondary subnets when needed.

[openshift-ci-robot]

@ammont82: This pull request references MGMT-17220 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

Related to https://issues.redhat.com/browse/MGMT-22120
When we switch machine network primary to ipv6 , machine network changed and the seconday updated (as expected)

But there is an error message after modifying api and ingress related to the seconday .. while the addresses are valid.
To solve the error in UI we must refresh the seconday machine network.

dual_stack_changes.mp4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Walkthrough

Adds IP-family classification helpers and strengthens IP/VIP and dual‑stack CIDR validation; updates hostPrefix and dualStack validation to use isCIDR checks; and adds a React effect to AvailableSubnetsControl to prevent duplicate primary/secondary machine network CIDRs in dual-stack mode.

Changes

Cohort / File(s)	Summary
Validation Schema Enhancements libs/ui-lib/lib/common/components/ui/formik/validationSchemas.ts	Adds isIPv4Address/isIPv6Address helpers; updates ipNoSuffixValidationSchema, vipNoSuffixValidationSchema, and vipArrayValidationSchema with per-item and per-family VIP/IP checks; replaces Address4/Address6.isValid with isCIDR.v4/v6 in hostPrefixValidationSchema and dualStackValidationSchema; adds dual-stack-unique-cidrs and dual-stack-opposite-families tests.
Dual-Stack Subnet Selection libs/ui-lib/lib/ocm/components/clusterConfiguration/networkConfiguration/AvailableSubnetsControl.tsx	Adds a React effect that detects identical primary and secondary machine network CIDRs in dual-stack mode and auto-selects an opposite-family replacement (or sets NO_SUBNET_SET if none available).

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Form as Form/State
    participant Validator as ValidationSchemas
    participant Subnets as AvailableSubnetsControl
    participant Fields as FormFields

    User->>Form: Edit machine network CIDRs / VIPs
    Form->>Validator: Validate CIDRs and VIPs
    activate Validator
    Validator->>Validator: Check dual-stack-unique-cidrs
    alt CIDRs identical
        Validator->>Validator: Flag error (duplicate CIDRs)
    else
        Validator->>Validator: Check dual-stack-opposite-families
        alt One IPv4 + One IPv6
            Validator->>Validator: Pass
        else
            Validator->>Validator: Flag family mismatch
        end
    end
    deactivate Validator

    Form->>Subnets: isDualStack or machineNetworks changed
    activate Subnets
    alt Primary == Secondary
        Subnets->>Subnets: Determine primary family
        Subnets->>Subnets: Select replacement from opposite-family pool
        alt Replacement found
            Subnets->>Fields: set secondary = replacement
        else
            Subnets->>Fields: set secondary = NO_SUBNET_SET
        end
    end
    deactivate Subnets

    Validator->>Form: Validation result
    Form->>User: Display validation feedback

Loading

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

• Pay attention to new per-item VIP checks and cross-field uniqueness tests in validationSchemas.ts.
• Verify behavior changes from Address4/Address6 -> isCIDR.v4/v6 for CIDR parsing across edge cases.
• Review AvailableSubnetsControl effect dependency array and replacement-selection logic to avoid unintended clearing or loops.

Possibly related PRs

• #3231: Related dual-stack subnet selection logic — also selects opposite-family replacement when primary/secondary collide.
• #3190: Touches the same validation schemas and AvailableSubnetsControl file; likely overlaps in dual-stack/CIDR checks.
• #3246: Modifies VIP validation behavior and arrays, overlapping with vipNoSuffix/vipArray schema changes.

Suggested labels

lgtm

Suggested reviewers

• celdrake
• batzionb

Poem

🐰 A rabbit hops through network trees,

matching IPv4 with IPv6 breeze.
No duplicate CIDRs in sight,
VIPs and subnets now sit right.
Hooray — the dual-stack dreams take flight!

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'MGMT-17220: dual-stack with second machine network not populates' is specific and directly related to the main changes, which address dual-stack network population issues.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between dabd207 and 17e3239.

📒 Files selected for processing (2)

• libs/ui-lib/lib/common/components/ui/formik/validationSchemas.ts (5 hunks)
• libs/ui-lib/lib/ocm/components/clusterConfiguration/networkConfiguration/AvailableSubnetsControl.tsx (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• libs/ui-lib/lib/ocm/components/clusterConfiguration/networkConfiguration/AvailableSubnetsControl.tsx

🧰 Additional context used

🧠 Learnings (3)

📓 Common learnings

Learnt from: linoyaslan
Repo: openshift-assisted/assisted-installer-ui PR: 3190
File: libs/ui-lib/lib/ocm/components/clusterConfiguration/networkConfiguration/AdvancedNetworkFields.tsx:55-63
Timestamp: 2025-10-21T04:40:36.292Z
Learning: In libs/ui-lib/lib/ocm/components/clusterConfiguration/networkConfiguration/AdvancedNetworkFields.tsx, the network reordering logic in the useEffect (swapping clusterNetworks and serviceNetworks based on the primary machine network's IP family) is for UI consistency only. Validation of empty or invalid CIDRs is handled separately by validation schemas, not by the reordering logic.

Learnt from: linoyaslan
Repo: openshift-assisted/assisted-installer-ui PR: 3190
File: libs/ui-lib/lib/ocm/components/clusterConfiguration/networkConfiguration/StackTypeControl.tsx:71-91
Timestamp: 2025-10-21T04:53:07.362Z
Learning: In libs/ui-lib/lib/ocm/components/clusterConfiguration/networkConfiguration/StackTypeControl.tsx, dual-stack mode requires both IPv4 and IPv6 networks (machineNetworks must have at least 2 entries: one IPv4 and one IPv6). Dual-stack with only IPv6 is not supported—dual-stack must have both IP families present.

📚 Learning: 2025-10-21T04:40:36.292Z

Learnt from: linoyaslan
Repo: openshift-assisted/assisted-installer-ui PR: 3190
File: libs/ui-lib/lib/ocm/components/clusterConfiguration/networkConfiguration/AdvancedNetworkFields.tsx:55-63
Timestamp: 2025-10-21T04:40:36.292Z
Learning: In libs/ui-lib/lib/ocm/components/clusterConfiguration/networkConfiguration/AdvancedNetworkFields.tsx, the network reordering logic in the useEffect (swapping clusterNetworks and serviceNetworks based on the primary machine network's IP family) is for UI consistency only. Validation of empty or invalid CIDRs is handled separately by validation schemas, not by the reordering logic.

Applied to files:

• libs/ui-lib/lib/common/components/ui/formik/validationSchemas.ts

📚 Learning: 2025-10-21T04:53:07.362Z

Learnt from: linoyaslan
Repo: openshift-assisted/assisted-installer-ui PR: 3190
File: libs/ui-lib/lib/ocm/components/clusterConfiguration/networkConfiguration/StackTypeControl.tsx:71-91
Timestamp: 2025-10-21T04:53:07.362Z
Learning: In libs/ui-lib/lib/ocm/components/clusterConfiguration/networkConfiguration/StackTypeControl.tsx, dual-stack mode requires both IPv4 and IPv6 networks (machineNetworks must have at least 2 entries: one IPv4 and one IPv6). Dual-stack with only IPv6 is not supported—dual-stack must have both IP families present.

Applied to files:

• libs/ui-lib/lib/common/components/ui/formik/validationSchemas.ts

🧬 Code graph analysis (1)

libs/ui-lib/lib/common/components/ui/formik/validationSchemas.ts (1)

libs/types/assisted-installer-service.d.ts (1)

• MachineNetwork (2182-2191)

🪛 Biome (2.1.2)

libs/ui-lib/lib/common/components/ui/formik/validationSchemas.ts

[error] 316-316: Do not add then to an object.

(lint/suspicious/noThenProperty)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)

• GitHub Check: translation-files
• GitHub Check: unit-tests
• GitHub Check: circular-deps
• GitHub Check: tests
• GitHub Check: format
• GitHub Check: lint

🔇 Additional comments (5)

libs/ui-lib/lib/common/components/ui/formik/validationSchemas.ts (5)

176-185: LGTM! Robust IP family classification helpers.

The new isIPv4Address and isIPv6Address helpers provide clear and reliable IP family detection by checking both format markers (. and :) and validity. These are used effectively in the VIP validation logic to ensure IP family consistency with machine networks.

---

316-360: LGTM! Per-item VIP family validation is correctly implemented.

The new vipFamilyMatchSchema ensures that each VIP's IP family matches its corresponding machine network's CIDR family at the same index. The path parsing, validation guards, and use of the new IP family helpers are all well-structured.

Note: The static analysis warning about then on line 316 is a false positive—then is part of Yup's conditional schema API (when/then/otherwise), not a problematic object property.

---

376-408: LGTM! Cross-VIP family validation is well-structured.

The new vips-match-machine-networks test correctly validates that primary and secondary VIPs align with their corresponding machine network families. The validateIndex helper provides clean, reusable validation logic with appropriate guards for incomplete form states.

---

520-529: LGTM! Correct use of CIDR validators.

Switching from Address4/6.isValid to isCIDR.v4/v6 is the right choice here since clusterNetworkCidr is a CIDR notation (network/prefix), not a bare IP address. This aligns with how CIDRs are validated elsewhere in the file.

---

795-841: LGTM! Dual-stack validation correctly enhanced.

The updates to dualStackValidationSchema are well-implemented:

1. Primary network validation (lines 795, 798): Correctly uses isCIDR.v4/v6 for CIDR validation.

2. Uniqueness check (lines 801-819): The dual-stack-unique-cidrs test now properly handles sentinel values. Lines 813-817 validate that both values are real CIDRs before comparing them, preventing false errors when dropdowns are at their NO_SUBNET_SET default state. This addresses the previous review concern.

3. Opposite families check (lines 821-841): The dual-stack-opposite-families test correctly enforces that dual-stack requires one IPv4 and one IPv6 subnet, aligning with the retrieved learnings about dual-stack requirements.

Based on learnings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[ammont82]

/cherry-pick releases/v2.47

[openshift-cherrypick-robot]

@ammont82: once the present PR merges, I will cherry-pick it on top of releases/v2.47 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick releases/v2.47

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci-robot]

@ammont82: This pull request references MGMT-17220 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

Related to https://issues.redhat.com/browse/MGMT-22120
When we switch machine network primary to ipv6 , machine network changed and the seconday updated (as expected)

But there is an error message after modifying api and ingress related to the seconday .. while the addresses are valid.
To solve the error in UI we must refresh the seconday machine network.

dual_stack_changes.mp4

Summary by CodeRabbit

• Improvements
• Enhanced IP address and VIP validation to ensure compliance with network configuration requirements.
• Improved dual-stack network mode to automatically prevent duplicate subnet assignments and maintain proper IP family alignment across network configurations.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a478afd and dabd207.

📒 Files selected for processing (2)

• libs/ui-lib/lib/common/components/ui/formik/validationSchemas.ts (5 hunks)
• libs/ui-lib/lib/ocm/components/clusterConfiguration/networkConfiguration/AvailableSubnetsControl.tsx (1 hunks)

🧰 Additional context used

🧠 Learnings (4)

📓 Common learnings

Learnt from: linoyaslan
Repo: openshift-assisted/assisted-installer-ui PR: 3190
File: libs/ui-lib/lib/ocm/components/clusterConfiguration/networkConfiguration/AdvancedNetworkFields.tsx:55-63
Timestamp: 2025-10-21T04:40:36.292Z
Learning: In libs/ui-lib/lib/ocm/components/clusterConfiguration/networkConfiguration/AdvancedNetworkFields.tsx, the network reordering logic in the useEffect (swapping clusterNetworks and serviceNetworks based on the primary machine network's IP family) is for UI consistency only. Validation of empty or invalid CIDRs is handled separately by validation schemas, not by the reordering logic.

Learnt from: linoyaslan
Repo: openshift-assisted/assisted-installer-ui PR: 3190
File: libs/ui-lib/lib/ocm/components/clusterConfiguration/networkConfiguration/StackTypeControl.tsx:71-91
Timestamp: 2025-10-21T04:53:07.362Z
Learning: In libs/ui-lib/lib/ocm/components/clusterConfiguration/networkConfiguration/StackTypeControl.tsx, dual-stack mode requires both IPv4 and IPv6 networks (machineNetworks must have at least 2 entries: one IPv4 and one IPv6). Dual-stack with only IPv6 is not supported—dual-stack must have both IP families present.

📚 Learning: 2025-10-21T04:40:36.292Z

Learnt from: linoyaslan
Repo: openshift-assisted/assisted-installer-ui PR: 3190
File: libs/ui-lib/lib/ocm/components/clusterConfiguration/networkConfiguration/AdvancedNetworkFields.tsx:55-63
Timestamp: 2025-10-21T04:40:36.292Z
Learning: In libs/ui-lib/lib/ocm/components/clusterConfiguration/networkConfiguration/AdvancedNetworkFields.tsx, the network reordering logic in the useEffect (swapping clusterNetworks and serviceNetworks based on the primary machine network's IP family) is for UI consistency only. Validation of empty or invalid CIDRs is handled separately by validation schemas, not by the reordering logic.

Applied to files:

• libs/ui-lib/lib/common/components/ui/formik/validationSchemas.ts
• libs/ui-lib/lib/ocm/components/clusterConfiguration/networkConfiguration/AvailableSubnetsControl.tsx

📚 Learning: 2025-10-21T04:53:07.362Z

Learnt from: linoyaslan
Repo: openshift-assisted/assisted-installer-ui PR: 3190
File: libs/ui-lib/lib/ocm/components/clusterConfiguration/networkConfiguration/StackTypeControl.tsx:71-91
Timestamp: 2025-10-21T04:53:07.362Z
Learning: In libs/ui-lib/lib/ocm/components/clusterConfiguration/networkConfiguration/StackTypeControl.tsx, dual-stack mode requires both IPv4 and IPv6 networks (machineNetworks must have at least 2 entries: one IPv4 and one IPv6). Dual-stack with only IPv6 is not supported—dual-stack must have both IP families present.

Applied to files:

• libs/ui-lib/lib/common/components/ui/formik/validationSchemas.ts
• libs/ui-lib/lib/ocm/components/clusterConfiguration/networkConfiguration/AvailableSubnetsControl.tsx

📚 Learning: 2025-10-20T08:57:04.935Z

Learnt from: linoyaslan
Repo: openshift-assisted/assisted-installer-ui PR: 3190
File: libs/ui-lib/lib/ocm/components/clusterDetail/ClusterProperties.tsx:43-45
Timestamp: 2025-10-20T08:57:04.935Z
Learning: In the file `libs/ui-lib/lib/ocm/components/clusterDetail/ClusterProperties.tsx`, the `getStackTypeLabel` function returns 'Dual-stack' or 'IPv4' because the system currently only supports IPv4 single-stack clusters. IPv6-only single-stack clusters are not supported.

Applied to files:

• libs/ui-lib/lib/ocm/components/clusterConfiguration/networkConfiguration/AvailableSubnetsControl.tsx

🧬 Code graph analysis (2)

libs/ui-lib/lib/common/components/ui/formik/validationSchemas.ts (1)

libs/types/assisted-installer-service.d.ts (1)

• MachineNetwork (2182-2191)

libs/ui-lib/lib/ocm/components/clusterConfiguration/networkConfiguration/AvailableSubnetsControl.tsx (2)

libs/ui-lib/lib/common/components/clusterConfiguration/utils.ts (1)

• isDualStack (204-212)

libs/ui-lib/lib/common/config/constants.ts (1)

• NO_SUBNET_SET (294-294)

🪛 Biome (2.1.2)

libs/ui-lib/lib/common/components/ui/formik/validationSchemas.ts

[error] 316-316: Do not add then to an object.

(lint/suspicious/noThenProperty)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)

• GitHub Check: tests
• GitHub Check: circular-deps
• GitHub Check: unit-tests
• GitHub Check: translation-files
• GitHub Check: format
• GitHub Check: lint

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ammont82, rawagner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [ammont82,rawagner]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@ammont82: This pull request references MGMT-17220 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

Related to https://issues.redhat.com/browse/MGMT-22120
When we switch machine network primary to ipv6 , machine network changed and the seconday updated (as expected)

But there is an error message after modifying api and ingress related to the seconday .. while the addresses are valid.
To solve the error in UI we must refresh the seconday machine network.

dual_stack_changes.mp4

Summary by CodeRabbit

• Improvements
• Enhanced IP and VIP validation to enforce address family, uniqueness, and subnet alignment across machine networks (including stricter checks for IPv4/IPv6 and dual-stack scenarios).
• Dual-stack behavior improved to prevent duplicate subnet assignments by auto-selecting or clearing secondary subnets when needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-cherrypick-robot]

@ammont82: new pull request created: #3258

Details

In response to this:

/cherry-pick releases/v2.47

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.