NO-ISSUE: Button text is not an icon

[jgyselov]

Summary by CodeRabbit

• Style
  • About button now displays a text label (“About”) instead of an icon.
  • Feedback button now shows the “Provide feedback” label alongside the external link icon.
  • Both buttons retain their existing placement and behavior; clicking About still opens the About dialog, and Feedback triggers the same action as before.
  • Visual presentation updated to emphasize clear, text-labeled controls without altering underlying interactions.

[openshift-ci-robot]

@jgyselov: This pull request explicitly references no jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Walkthrough

Updated two UI buttons in the assisted UI: replaced icon-only About button with a text-labeled button and adjusted Feedback button to display text alongside the ExternalLinkAltIcon. No changes to handlers, variants, IDs, or modal state management. No exported/public API changes.

Changes

Cohort / File(s)	Summary
UI button label/icon adjustments apps/assisted-ui/src/components/AboutButton.tsx, apps/assisted-ui/src/components/FeedbackButton.tsx	Convert icon-only buttons to include visible text labels. AboutButton: move "About" to children, remove icon prop. FeedbackButton: keep ExternalLinkAltIcon in icon prop and add "Provide feedback" as children. Preserve onClick, id, variant, and modal logic.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

lgtm, size/S

Suggested reviewers

• ammont82
• celdrake

Poem

A hop and a tap, I tweak the UI,
Buttons now speak, not only imply.
About says “About,” feedback’s in view,
Icons still shine, but words carry through.
Thump-thump! I ship with tidy delight—
Small nibble changes, crisp and bright. 🐇✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title "NO-ISSUE: Button text is not an icon" succinctly and accurately reflects the main change in the PR—converting icon-only buttons into text-labeled buttons—so it is relevant and clear to reviewers scanning the history. It is concise and directly tied to the AboutButton and FeedbackButton modifications described in the summary.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (2)

apps/assisted-ui/src/components/AboutButton.tsx (1)

12-14: Localize label and add aria-haspopup for dialog trigger.
Wrap “About” in i18n and add aria-haspopup="dialog".

-      <Button variant={ButtonVariant.plain} onClick={handleClick} id="button-about">
-        About
+      <Button variant={ButtonVariant.plain} onClick={handleClick} id="button-about" aria-haspopup="dialog">
+        {t('aboutButton.label', 'About')}
       </Button>

Add outside this hunk:

import { useTranslation } from 'react-i18next';
...
const { t } = useTranslation();

apps/assisted-ui/src/components/FeedbackButton.tsx (1)

7-14: Prefer link semantics for navigation + localize label.
This navigates off-site; render as an anchor for native link behavior (middle‑click, context menu) and correct rel attributes. Also wrap the label in i18n.

-  <Button
-    icon={<ExternalLinkAltIcon />}
-    variant={'plain'}
-    onClick={() => window.open(Constants.FEEDBACK_FORM_LINK, '_blank', 'noopener noreferrer')}
-    id="button-feedback"
-  >
-    Provide feedback
-  </Button>
+  <Button
+    component="a"
+    href={Constants.FEEDBACK_FORM_LINK}
+    target="_blank"
+    rel="noopener noreferrer"
+    icon={<ExternalLinkAltIcon />}
+    variant="plain"
+    id="button-feedback"
+  >
+    {t('feedbackButton.label', 'Provide feedback')}
+  </Button>

Add outside this hunk if not already present:

import { useTranslation } from 'react-i18next';
const { t } = useTranslation();

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 94cc72b and f3ec247.

📒 Files selected for processing (2)

• apps/assisted-ui/src/components/AboutButton.tsx (1 hunks)
• apps/assisted-ui/src/components/FeedbackButton.tsx (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)

• GitHub Check: tests
• GitHub Check: lint
• GitHub Check: translation-files
• GitHub Check: circular-deps
• GitHub Check: unit-tests
• GitHub Check: format

🔇 Additional comments (2)

apps/assisted-ui/src/components/AboutButton.tsx (1)

12-14: LGTM: Text label improves a11y and discoverability.

apps/assisted-ui/src/components/FeedbackButton.tsx (1)

8-14: LGTM: Icon + text pattern is consistent and accessible.

[jgyselov]

/cherry-pick releases/v2.46

[openshift-cherrypick-robot]

@jgyselov: once the present PR merges, I will cherry-pick it on top of releases/v2.46 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick releases/v2.46

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ammont82, jgyselov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [ammont82,jgyselov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-cherrypick-robot]

@jgyselov: new pull request created: #3176

Details

In response to this:

/cherry-pick releases/v2.46

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.