-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v9.11.0 proposal #19799
v9.11.0 proposal #19799
Commits on Mar 30, 2018
-
test: http2 errors on req.close()
Backport-PR-URL: #19579 PR-URL: #18854 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 6bc49f0 - Browse repository at this point
Copy the full SHA 6bc49f0View commit details -
test: add more asserts to
test-internal-errors
Backport-PR-URL: #19579 PR-URL: #13686 Fixes: #13682 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for cc68bc2 - Browse repository at this point
Copy the full SHA cc68bc2View commit details -
The function should strictly test for the error class and only accept the correct one. Any other error class should fail. Backport-PR-URL: #19579 PR-URL: #13686 Fixes: #13682 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 44b12c1 - Browse repository at this point
Copy the full SHA 44b12c1View commit details -
test: fix wrong error classes passed in as type
Backport-PR-URL: #19579 PR-URL: #13686 Fixes: #13682 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for ca97be5 - Browse repository at this point
Copy the full SHA ca97be5View commit details -
test: http2 stream.respond() error checks
Backport-PR-URL: #19579 PR-URL: #18861 Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 4caf536 - Browse repository at this point
Copy the full SHA 4caf536View commit details -
http2: refer to stream errors by name
Display the constant name instead of a stream error code in the error message, because the numerical codes give absolutely no clue about what happened when an error is emitted. Backport-PR-URL: #19579 PR-URL: #18966 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 441175c - Browse repository at this point
Copy the full SHA 441175cView commit details -
test: fix test-tty-get-color-depth
If getTTYfd returns 0, and stdin is not writable (like on Windows), trying to create WriteStream will fail. This commit fixes that by skipping fd 0. PR-URL: #18478 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 21e69d1 - Browse repository at this point
Copy the full SHA 21e69d1View commit details -
src: fix upcoming V8 deprecation warnings
PR-URL: #19490 Fixes: #18909 Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for cae9ff2 - Browse repository at this point
Copy the full SHA cae9ff2View commit details -
repl: fix tab completion of inspector module
Correctly check for the presence of the inspector module before adding it to the builtin libs list. PR-URL: #19505 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for ee4390a - Browse repository at this point
Copy the full SHA ee4390aView commit details -
url: refactor "escapeParam" function to make it common
PR-URL: #19076 Reviewed-By: Ruben Bridgewater <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 99e3c77 - Browse repository at this point
Copy the full SHA 99e3c77View commit details -
url: remove redundant function
PR-URL: #19076 Reviewed-By: Ruben Bridgewater <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for fdc51a1 - Browse repository at this point
Copy the full SHA fdc51a1View commit details -
fs,net: emit 'ready' for fs streams and sockets
... in addition to the event names they currently use. Currently, various internal streams have different events that indicate that the underlying resource has successfully been established. This commit adds ready event for fs and net sockets to standardize on emitting ready for all of these streams. PR-URL: #19408 Fixes: #19304 Reviewed-By: Anna Henningsen <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 8a8b43e - Browse repository at this point
Copy the full SHA 8a8b43eView commit details -
http: support server options on createServer
PR-URL: #19461 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for dac5f67 - Browse repository at this point
Copy the full SHA dac5f67View commit details
Commits on Apr 2, 2018
-
http2: destroy() stream, upon errnoException
First steps towards #19060 PR-URL: #19389 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7b850a7 - Browse repository at this point
Copy the full SHA 7b850a7View commit details -
lib: add internal check macros
PR-URL: #18852 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d3d1ee7 - Browse repository at this point
Copy the full SHA d3d1ee7View commit details -
lib: document nextTick queue internals
Make this code (a bit more) comprehensible by adding some internals docs. With diagrams and everything! 🎉 PR-URL: #19469 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Weijia Wang <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Gus Caplan <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a45f3f8 - Browse repository at this point
Copy the full SHA a45f3f8View commit details -
src: remove unused 'ares.h' include from env.h
PR-URL: #19557 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 1a38b9b - Browse repository at this point
Copy the full SHA 1a38b9bView commit details -
src: name all builtin init functions Initialize
This commit renames a few of the builtin modules init functions to Initialize for consistency. PR-URL: #19550 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 6c46681 - Browse repository at this point
Copy the full SHA 6c46681View commit details -
n-api: bump version of n-api supported
Bump the version due to additions to the api. PR-URL: #19497 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 94a10ba - Browse repository at this point
Copy the full SHA 94a10baView commit details -
test: update link according to NIST bibliography
According to NIST SP 800 38D, this is the document the link orginally pointed to. Fixes: #17619 PR-URL: #19593 Reviewed-By: Weijia Wang <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 274eff5 - Browse repository at this point
Copy the full SHA 274eff5View commit details -
doc: improve zero-fill-buffers text
* improve text for easier comprehension * clarify that performance impact is *negative* * remove superfluous "either" (should only be used when there are 2 options anyway) * remove superfluous italics * line wrap at 80 chars PR-URL: #19623 Reviewed-By: Shingo Inoue <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7555dee - Browse repository at this point
Copy the full SHA 7555deeView commit details -
n-api: ensure in-module exceptions are propagated
Whenever we call into an addon, whether it is for a callback, for module init, or for async work-related reasons, we should make sure that * the last error is cleared, * the scopes before the call are the same as after, and * if an exception was thrown and captured inside the module, then it is re-thrown after the call. Therefore we should call into the module in a unified fashion. This change introduces the macro NAPI_CALL_INTO_MODULE() which should be used whenever invoking a callback provided by the module. Fixes: #19437 PR-URL: #19537 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b0a3a44 - Browse repository at this point
Copy the full SHA b0a3a44View commit details -
doc: fix grammar error in process.md
PR-URL: #19641 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 2ea7f90 - Browse repository at this point
Copy the full SHA 2ea7f90View commit details -
test: amplify and optimize doctool/test-make-doc
PR-URL: #19581 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0daa063 - Browse repository at this point
Copy the full SHA 0daa063View commit details -
tools: fix nits in tools/doc/type-parser.js
PR-URL: #19612 Reviewed-By: Shingo Inoue <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Khaidi Chu <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 2c5d53f - Browse repository at this point
Copy the full SHA 2c5d53fView commit details -
deps: turn in std::string for ICU
- node and v8 did not call into std::string previously, so that access was shut off. - this fixes compilation for ICU 58.2 (backlevel) but may be expressed in other versions also. Fixes: #19151 PR-URL: #19624 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 97a92c4 - Browse repository at this point
Copy the full SHA 97a92c4View commit details -
doc: guard against md list parsing edge case
PR-URL: #19647 Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Chen Gang <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0786161 - Browse repository at this point
Copy the full SHA 0786161View commit details -
test: rename tests with descriptive filenames
Refs: #19105 Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure PR-URL: #19608 Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 278e8af - Browse repository at this point
Copy the full SHA 278e8afView commit details -
lib: fix a typo in lib/timers "read through"
PR-URL: #19666 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 889a3b4 - Browse repository at this point
Copy the full SHA 889a3b4View commit details -
test: refactor test-http-expect-continue
Use common.mustCall() where appropriate. Remove some logic that is not required when common.mustCall() is used (incrementor/decrementor to make sure everything is called the same number of times). PR-URL: #19625 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 2f09ee7 - Browse repository at this point
Copy the full SHA 2f09ee7View commit details -
test: fix assert.throws error in test-http-parser
The third argument of `assert.throws()` is a message that is used by the AssertionError, not the message to check in the thrown error. It appears that there is an assert.throws() in test-http-parser that expects the latter behavior. Rewrite the call to check the error message. Even if this wasn't a mistake, this change results in a more robust check. PR-URL: #19626 Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 806bc0d - Browse repository at this point
Copy the full SHA 806bc0dView commit details -
test: fix typo in test-tls-cnnic-whitelist
PR-URL: #19662 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 677b613 - Browse repository at this point
Copy the full SHA 677b613View commit details -
test: refactor test-net-dns-error
- Use `common.mustCall()` and `common.mustNotCall()`. - Use ternary operator. PR-URL: #19640 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a89ba21 - Browse repository at this point
Copy the full SHA a89ba21View commit details -
test: removed default message from assert.strictEqual
Use the `assert.strictEqual()` default message instead of a static message to include the actual and expected value. PR-URL: #19660 Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7ae2ca4 - Browse repository at this point
Copy the full SHA 7ae2ca4View commit details -
test: use createReadStream instead of ReadStream
This commit updates test-fs-read-stream to use fs.createReadStream instead of using fs.ReadStream. All other places in this test use the former. PR-URL: #19636 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Weijia Wang <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 94b28aa - Browse repository at this point
Copy the full SHA 94b28aaView commit details -
doc: shorten character encoding introduction
Keep the introduction for Buffers and character encodings short and to the point. The current introduction doesn't provide much in the way of useful additional information, but it is a bit confusing in its wording. ("such as" seems like it ought to refer to "encoded characters" but it actually refers to character encodings, which are not mentioned in the sentence. It may be arguable as to whether "hex-encoded" is in fact a character encoding, whether it should be stylized as "Hex-encoded" or not, and whether it should be spelled out as "Hexadecimal-encoded". None of that information is particularly useful to the end user at this point in the text. Omitting it simplifies and improves the documentation.) Additionally, the section is now wrapped to 80 characters. PR-URL: #19648 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 9f20534 - Browse repository at this point
Copy the full SHA 9f20534View commit details -
src: general C++ cleanup in node_url.cc
- Merge `domain` and `opaque` storage in URL parser: This just simplifies the code a bit, having multiple fields in an union with the same type is usually just overhead. - Add move variant of `URLHost::ToString()`: This helps avoid unnecessary string copy operations, especially since we control the lifetime of `URLHost` objects pretty well. - Use const refs in node_url.cc where appropriate - Remove or reduce overly generous `.reserve()` calls: These would otherwise keep a lot of unused memory lying around. - Return return values instead of unnecessary pointer arguments - Use more common/expressive variable names - Avoid macro use, reduce number of unnecessary JS strings: There’s no reason for `GET`, `GET_AND_SET` and `UTF8STRING` to be macros. Also, `GET` would previously create a JS string instance for each single call, even though the strings it was called with were compile-time constants. - Avoid unnecessary JS casts when the type of a value is known - Avoid (commonly unnecessary) copy for whitespace stripping PR-URL: #19598 Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 01e3190 - Browse repository at this point
Copy the full SHA 01e3190View commit details -
tools: fix comment nits in tools/doc/*.js files
* Unify first letters case. * Unify periods. * Delete excess spaces. * Add some blank lines as logical delimiters. * Remove obvious comments. * Combine short lines, rewrap lines more logically. * Fix typos. * "XXX" -> "TODO:", OSX -> macOS. PR-URL: #19696 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Shingo Inoue <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 140611b - Browse repository at this point
Copy the full SHA 140611bView commit details -
tools: dry utility function in tools/doc/json.js
Also, move a declaration of unrelated variable closer to its only context. PR-URL: #19692 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7043e95 - Browse repository at this point
Copy the full SHA 7043e95View commit details -
test: make test-http-expect-continue more strict
In test-http-expect-continue, verify that the request listener is not called. PR-URL: #19669 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0b27416 - Browse repository at this point
Copy the full SHA 0b27416View commit details -
src: fix warnings in aliased_buffer
* Unary minus usages on unsigned type * Implicit casts to/from input parameters PR-URL: #19665 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Khaidi Chu <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 75d23ab - Browse repository at this point
Copy the full SHA 75d23abView commit details -
doc: remove ES6/ECMAScript 2015 from buffer.md
As the introduction of ES6 features recedes further into the past, it is less and less relevant (and more and more distracting) to cite it in documentation text. Remove mention in buffer.md. PR-URL: #19685 Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for c8fa8f1 - Browse repository at this point
Copy the full SHA c8fa8f1View commit details -
test: remove 3rd argument from assert.strictEqual
If there is an AssertionError, the string literal is printed and not the value of `r`. For debugging purposes, it is good to know if `r` is false or null or something else. PR-URL: #19707 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for ff7f28c - Browse repository at this point
Copy the full SHA ff7f28cView commit details -
test: rename regression tests more expressively
- Rename test-fs-truncate-GH-6233 to test-fs-truncate-clear-file-zero - Rename test-process-exit-GH-12322 to test-process-exit-handler PR-URL: #19668 Refs: #19105 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 90c8546 - Browse repository at this point
Copy the full SHA 90c8546View commit details -
doc: fix quotes mistypes in inline code blocks
This fixes trivial invalid quotes mistypes in inline code blocks, e.g. forgotten quotes or mixed order. Whether this could be easily automatically checked in lint is a separate question: e.g. `'` is valid. PR-URL: #19713 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 44361bd - Browse repository at this point
Copy the full SHA 44361bdView commit details -
* Replace absolute link with relative link. * Fix sorting in bottom references. PR-URL: #19721 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for bb32bc8 - Browse repository at this point
Copy the full SHA bb32bc8View commit details -
module: skip preserveSymlinks for main
PR-URL: #19388 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 859b719 - Browse repository at this point
Copy the full SHA 859b719View commit details -
tools: remove src dir from JS editorconfig rule
The src directory does not contain any JavaScript files, so there is no need to match it. PR-URL: #19521 Reviewed-By: Shingo Inoue <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 239a036 - Browse repository at this point
Copy the full SHA 239a036View commit details -
tools: apply editorconfig rules to tools also
PR-URL: #19521 Reviewed-By: Shingo Inoue <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b80d169 - Browse repository at this point
Copy the full SHA b80d169View commit details -
buffer: remove "new" from deprecation message
This change removes "new" as a description for `Buffer` construction methods. They are arguably not "new" anymore and they certainly won't be "new" anymore at some point. PR-URL: #19687 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Nikolai Vavilov <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 54b84f3 - Browse repository at this point
Copy the full SHA 54b84f3View commit details -
doc: favor utf16le over ucs2 in buffer.md
Favor 'utf16le' over its alias 'ucs2' in `buffer.md`. Ref: #19648 (comment) PR-URL: #19688 Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d111037 - Browse repository at this point
Copy the full SHA d111037View commit details -
doc: do not identify string as "JavaScript string"
A parameter that is explicitly identified as a string does not need to be further specified in the text as a "JavaScript string". Remove the type altogether as it is indicated in the argument description. PR-URL: #19689 Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 3a3ae01 - Browse repository at this point
Copy the full SHA 3a3ae01View commit details -
doc: remove "if provided" for optional arguments
Remove "if provided" when discussing arguments that are explicitly indicated to be optional and have default values. PR-URL: #19690 Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Shingo Inoue <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for c5469bb - Browse repository at this point
Copy the full SHA c5469bbView commit details -
inspector: report client-visible host and port
Node instance may not know the real host and port user sees when debug frontend connects through the SSH tunnel. This change fixes '/json/list' response by using the value client provided in the host header. PR-URL: #19664 Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0bcad33 - Browse repository at this point
Copy the full SHA 0bcad33View commit details
Commits on Apr 3, 2018
-
test: fix flaky test-cluster-send-handle-twice
Use `common.mustCall()` to make sure connection callback runs exactly once. Use `connect` event instead of `setTimeout` to avoid test failing if timer runs before client is connected. Remove `cluster.worker.disconnect()` after `assert.fail()`. It is unreachable code that is unnecessary. PR-URL: #19700 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for e44b777 - Browse repository at this point
Copy the full SHA e44b777View commit details -
lib: make isStackOverflowError() engine-agnostic
Assumption that stack overflow exception has name == "RangeError" is v8-specific. Updated logic to dynamically capture error name when capturing error message. PR-URL: #19705 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 152a86c - Browse repository at this point
Copy the full SHA 152a86cView commit details -
doc: deprecation clarifications
PR-URL: #19522 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 5149e18 - Browse repository at this point
Copy the full SHA 5149e18View commit details -
doc: fix lint nits in COLLABORATOR_GUIDE.md
PR-URL: #19762 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Jan Krems <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 1aaad92 - Browse repository at this point
Copy the full SHA 1aaad92View commit details -
- Update to released ICU 61.1, including: - CLDR 33 (many new languages and data improvements) - Many small API additions, improvements, and bug fixes - note: 'icu::' namespace is no longer used by default (Necessated #18667 ) PR-URL: #19621 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 58f61db - Browse repository at this point
Copy the full SHA 58f61dbView commit details -
lint: change require-buffer rule message
PR-URL: #19701 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for e0c7d78 - Browse repository at this point
Copy the full SHA e0c7d78View commit details -
doc: update to adding listens on SIGUSR1
Updated the doc/api/process.md documentation to reflect that listening on SIGUSR1 could impact the debugger. Fixes: #19619 PR-URL: #19709 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for c1b83fc - Browse repository at this point
Copy the full SHA c1b83fcView commit details -
n-api: back up env before finalize
Heed the comment to not use fields of a Reference after calling its finalize callback, because such a call may destroy the Reference. Fixes: #19673 PR-URL: #19718 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a0a5873 - Browse repository at this point
Copy the full SHA a0a5873View commit details -
tools: don’t emit illegal utf-8 from icutrim/iculslocs
- argv[0] was being emitted into a utf-8 stream, but argv[0] may not be legal utf-8 - fix by not emitting argv[0] (was only for a source comment) - partially resolves #17077 PR-URL: #19756 Fixes: #17077 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Nikolai Vavilov <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 53d7fbb - Browse repository at this point
Copy the full SHA 53d7fbbView commit details -
doc: add mafintosh to collaborators
PR-URL: #19773 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 42671f2 - Browse repository at this point
Copy the full SHA 42671f2View commit details
Commits on Apr 4, 2018
-
http: fix
request
whensetHost
istrue
Fixes: #19457 PR-URL: #19502 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for e1f44a6 - Browse repository at this point
Copy the full SHA e1f44a6View commit details -
test: remove third argument from call to assert.strictEqual()
Remove the message argument from call to assert.strictEqual so that the AssertionError will report the value of er.code, and add a comment with the message. PR-URL: #19659 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 46569d6 - Browse repository at this point
Copy the full SHA 46569d6View commit details -
Use the default assert.strictEqual() message so that unequal values are shown in the event of an AssertionError. PR-URL: #19629 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f379167 - Browse repository at this point
Copy the full SHA f379167View commit details -
test: update test to comply with lint rule
Ref: #19502 (comment) PR-URL: #19784 Reviewed-By: Teddy Katz <[email protected]> Reviewed-By: Matheus Marchini <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 4df3377 - Browse repository at this point
Copy the full SHA 4df3377View commit details -
doc: improve Buffer.allocUnsafeSlow() and related
* Fixed "cleanup" being misused as a verb * "Use of Foo should only be used" construction changed to "Foo should only be used..." * Otherwise-unmentioned "`Persistent`" changed to more understandable "persistent" * remove an instance of unnecessary italics * wrap at 80 characters Change all "initialize a...instance to zeroes" to say "with zeroes" instead. Previously, both formulations appeared. PR-URL: #19742 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 041f6cd - Browse repository at this point
Copy the full SHA 041f6cdView commit details -
test: test process.setuid for bad argument types
Test process.setuid with an object as an argument. An equivalent test exists for process.seteuid. PR-URL: #19703 Fixes: #19591 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 92e9ed0 - Browse repository at this point
Copy the full SHA 92e9ed0View commit details -
Add a `make jstest` target that runs tests written in JavaScript (excluding documentation tests which are run in `make test-doc`). PR-URL: #19324 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matheus Marchini <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0127712 - Browse repository at this point
Copy the full SHA 0127712View commit details -
buffer: use v8::TypedArray::kMaxLength as buffer::kMaxLength
This was added in v8 6.2, looks like a safe replacement for our own buffer::kMaxLength. PR-URL: #19738 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0bd78dc - Browse repository at this point
Copy the full SHA 0bd78dcView commit details -
* Replace 2 hyphens (--) by spaced m-dashes (—) as per STYLE_GUIDE.md. * Space infix operators. * Unify quotes in inline code spans (use only single quotes). * Unify `* Returns:` (eliminate deviations). * Dedupe spaces. PR-URL: #19743 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for ae86adc - Browse repository at this point
Copy the full SHA ae86adcView commit details -
fs: use fs.access in fs.exists
Uses fs.access to implement fs.exists functionality. Fixes a issue, when a file exists but user does not have privileges to do stat on the file. Fixes: #17921 Backport-PR-URL: #19654 PR-URL: #18618 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Weijia Wang <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 5e90fc6 - Browse repository at this point
Copy the full SHA 5e90fc6View commit details -
src: move internal loaders out of bootstrap_node.js
- Moves the creation of `process.binding()`, `process._linkedBinding()` `internalBinding()` and `NativeModule` into a separate file `lib/internal/bootstrap_loaders.js`, and documents them there. This file will be compiled and run before `bootstrap_node.js`, which means we now bootstrap the internal module & binding system before actually bootstrapping Node.js. - Rename the special ID that can be used to require `NativeModule` as `internal/bootstrap_loaders` since it is setup there. Also put `internalBinding` in the object exported by `NativeModule.require` instead of putting it inside the `NativeModule.wrapper` - Use the original `getBinding()` to get the source code of native modules instead of getting it from `process.binding('native')` so that users cannot fake native modules by modifying the binding object. - Names the bootstrapping functions so their names show up in the stack trace. Backport-PR-URL: #19374 PR-URL: #19112 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gus Caplan <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for ff7a116 - Browse repository at this point
Copy the full SHA ff7a116View commit details -
src: put bootstrappers in lib/internal/bootstrap/
Create `lib/internal/bootstrap/` and put bootstrappers there: Before: ``` lib/internal ├── ... ├── bootstrap_loaders.js └── bootstrap_node.js ``` After: ``` lib/internal ├── ... └── bootstrap ├── loaders.js └── node.js ``` Backport-PR-URL: #19374 PR-URL: #19177 Refs: #19112 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for ebdcf91 - Browse repository at this point
Copy the full SHA ebdcf91View commit details -
test: remove NODE_DEBUG in global module loading test
Otherwise the debug log output might be mixed up with the expected errors and the assertion matching the error message would fail. Backport-PR-URL: #19374 PR-URL: #19177 Refs: #19112 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 83ebaf0 - Browse repository at this point
Copy the full SHA 83ebaf0View commit details -
lib: restructure cjs and esm loaders
Create `lib/internal/modules` and restructure the module loaders to make the purpose of those files clearer. Also make it clear in the code that the object exported by `lib/internal/modules/cjs/loader.js` is `CJSModule` instead of the ambiguous `Module`. Before: ``` lib ├── ... ├── internal │ ├── loaders │ │ ├── CreateDynamicModule.js │ │ ├── DefaultResolve.js │ │ ├── Loader.js │ │ ├── ModuleJob.js │ │ ├── ModuleMap.js │ │ ├── ModuleWrap.js │ │ └── Translators.js │ └── module.js └── module.js ``` After: ``` lib ├── ... ├── internal │ ├── ... │ └── modules │ ├── cjs │ │ ├── helpers.js │ │ └── loader.js │ └── esm │ ├── CreateDynamicModule.js │ ├── DefaultResolve.js │ ├── Loader.js │ ├── ModuleJob.js │ ├── ModuleMap.js │ └── Translators.js └── module.js # deleted in this commit to work with git file mode ``` Backport-PR-URL: #19374 PR-URL: #19177 Refs: #19112 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 45c477c - Browse repository at this point
Copy the full SHA 45c477cView commit details -
lib: add back lib/module.js redirection
The previous commit deleted lib/module.js so that git recognize the file move `lib/module.js` -> `lib/internal/modules/cjs/loader.js`. This commit add the redirection back. Backport-PR-URL: #19374 PR-URL: #19177 Refs: #19112 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 8e44011 - Browse repository at this point
Copy the full SHA 8e44011View commit details -
http2: callback valid check before closing request
Do not close the request if callback is not a function, and throw ERR_INVALID_CALLBACK TypeError Backport-PR-URL: #19229 PR-URL: #19061 Fixes: #18855 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Shingo Inoue <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 2bdf3ca - Browse repository at this point
Copy the full SHA 2bdf3caView commit details -
2018-04-04, Version 9.11.0 (Current)
Notable changes: * deps: - Updated ICU to 61.1 (Steven R. Loomis) [#19621](#19621) Includes CLDR 33 (many new languages and data improvements). * fs: - Emit 'ready' event for `ReadStream` and `WriteStream` (Sameer Srivastava) [#19408](#19408) * n-api: - Bump version of n-api supported (Michael Dawson) [#19497](#19497) * net: - Emit 'ready' event for `Socket` (Sameer Srivastava) [#19408](#19408) * Added new collaborators - [mafintosh](https://github.com/mafintosh) Mathias Buus
Configuration menu - View commit details
-
Copy full SHA for 11c8db4 - Browse repository at this point
Copy the full SHA 11c8db4View commit details