module: skip preserveSymlinks for main #19388
Conversation
guybedford
force-pushed
the
main-skip-preserve-symlinks
branch
from
81003ef
to
292c7bd
Compare
|
Not sure if this is due to flaky CI or not... will try again once other CI jobs are looking greener. |
guybedford
force-pushed
the
main-skip-preserve-symlinks
branch
from
292c7bd
to
a9dc4f8
Compare
|
Turns out there was an issue with symlinks on Windows in fixtures, which should be resolved now. Latest CI: https://ci.nodejs.org/job/node-test-pull-request/13773/ |
|
for the commit name, should the subsystem be esmodule or loader or something? module makes me think it touches the cjs module stuff |
|
CI error this time seems to be completely unrelated, so I believe this is good to merge. |
|
@devsnek |
guybedford
force-pushed
the
main-skip-preserve-symlinks
branch
from
8991bcb
to
994ed4e
Compare
|
Rebased, latest CI: https://ci.nodejs.org/job/node-test-pull-request/13962/ Will actually merge this time. |
|
@guybedford forgot to merge :D ? |
PR-URL: #19388 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Merged in 141be92. |
PR-URL: #19388 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]>
The CommonJS module resolver specifically skips --preserveSymlinks for the main entry point into Node.
From discussion in #19383, it seems like this should probably be carried over into the ES module resolver in order to ensure full backwards-compatibility.
The alternative here might be to have --preserveSymlinks act on the main in the CJS resolver too instead of this PR.
//cc @nodejs/modules
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes