Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buffer: use v8::TypedArray::kMaxLength as buffer::kMaxLength #19738

Closed
wants to merge 1 commit into from
Closed

buffer: use v8::TypedArray::kMaxLength as buffer::kMaxLength #19738

wants to merge 1 commit into from

Conversation

joyeecheung
Copy link
Member

This was added in v8 6.2 by v8/v8@19fee8b, looks like a safe replacement for our own buffer::kMaxLength

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. c++ Issues and PRs that require attention from people who are familiar with C++. labels Apr 2, 2018
@joyeecheung
Copy link
Member Author

cc @bnoordhuis

@joyeecheung
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/13979/

@joyeecheung joyeecheung mentioned this pull request Apr 2, 2018
Closed
4 tasks
@joyeecheung
Copy link
Member Author

Landed in 30fe55e, thanks!

@joyeecheung joyeecheung closed this Apr 4, 2018
joyeecheung added a commit that referenced this pull request Apr 4, 2018
@joyeecheung
buffer: use v8::TypedArray::kMaxLength as buffer::kMaxLength
30fe55e 
This was added in v8 6.2, looks like a safe replacement for
our own buffer::kMaxLength.

PR-URL: #19738
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
targos pushed a commit that referenced this pull request Apr 4, 2018
@joyeecheung @targos
buffer: use v8::TypedArray::kMaxLength as buffer::kMaxLength
0bd78dc 
This was added in v8 6.2, looks like a safe replacement for
our own buffer::kMaxLength.

PR-URL: #19738
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@targos targos mentioned this pull request Apr 4, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
buffer Issues and PRs related to the buffer subsystem. c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@joyeecheung @jasnell @addaleax @cjihrig @targos @nodejs-github-bot