Rename regression tests with descriptive file names #19105

joyeecheung · 2018-03-03T11:31:31Z

(I vaguely remember there was a similar issue but could not find it..if it is a duplicate, please leave a pointer, thanks!)

There are currently a couple of tests named test-regress-* and many of them are referring to really old regressions in the v0.x repo. I think it's time to rename them with something more descriptive now.

cc @nodejs/collaborators

The text was updated successfully, but these errors were encountered:

BridgeAR · 2018-03-03T11:32:54Z

+1 from me.

BridgeAR · 2018-03-03T11:33:42Z

It is especially good to rename them with the appropriate subsystem. It is much easier to run all tests from one subsystem if the names are right.

mcollina · 2018-03-03T11:46:19Z

+1

joyeecheung · 2018-03-03T11:46:32Z

BTW: I am not sure if they count as good first contributions, but this is what I would usually do to find out how to rename an existing test

Look for the test description in the top of the file, if it has one
Take a look at the history of the file (click the "history" button on the top right of the file's page in Github UI), and trace back to the earliest commit to find out what it is testing. Notice that there are a lot of test being moved from test/simple to test/parallel/test-sequential during 0e19476, in that case, search the test using "find file" in the commit prior to that, then look at the history in the original test again.
When you find the commit that created the file, look at the commit log for issue links to read about the context.
Optionally, look at the git blame of the test to find out more about the test.

Of course one can always just look at the code to guess what the test is doing, but I usually find discussions in issues and PRs more informative, and you are less likely to guess wrong with those context.

richardlau · 2018-03-03T13:31:27Z

(I vaguely remember there was a similar issue but could not find it..if it is a duplicate, please leave a pointer, thanks!)

#17948?

richardlau · 2018-03-03T13:44:21Z

Also can see if the matching issue/pull request in the archived v0.x repository looks relevant.

e.g., test/sequential/test-regress-GH-1697.js is testing nodejs/node-v0.x-archive#1697.

Unfortunately some (most?) of these originate from before we started writing metadata into the commit messages linking back to pull requests and issues.

juggernaut451 · 2018-03-05T09:42:54Z

@joyeecheung working on it

tniessen · 2018-03-05T12:57:05Z

(I vaguely remember there was a similar issue but could not find it..if it is a duplicate, please leave a pointer, thanks!)

@joyeecheung I don't remember an issue, but there was #17948 with a similar intention.

Edit: Oops, missed @richardlau's #19105 (comment).

Rename the test appropriately alongside mentioning the subsystem Also, make a few basic changes to make sure the test conforms to the standard test structure Refs: nodejs#19105 Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure

Rename affected tests to remove the "regress" keyword as well as improve naming scheme. Refs: nodejs#19105

Refs: nodejs#19105

Rename the test appropriately alongside mentioning the subsystem Also, make a few basic changes to make sure the test conforms to the standard test structure Refs: nodejs#19105 Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure

Rename the test appropriately alongside mentioning the subsystem Also, make a few basic changes to make sure the test conforms to the standard test structure Refs: #19105 Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure PR-URL: #19161 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>

PR-URL: #19495 Refs: #19105 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>

Rename test-dgram-regress-4496 to test-dgram-typeerror-buffer to test-dgram-send-invalid-msg-type Rename test-http-regr-nodejsgh-2821 to test-http-request-large-payload Rename test-child-process-fork-regr-nodejsgh-2847 to test-child-process-fork-closed-channel-segfault Rename test-http-pipeline-regr-2639 to test-http-pipeline-serverresponse-assertionerror Rename test-http-pipeline-regr-3332 to test-http-pipeline-requests-connection-leak Rename test-http-pipeline-regr-3508 to test-http-pipeline-socket-parser-typeerror Refs: nodejs#19105 Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure

Refs: #19105 Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure PR-URL: #19608 Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>

Rename test-fs-truncate-nodejsGH-6233 to test-fs-truncate-clear-file-zero Rename test-process-exit-nodejsGH-12322 to test-process-exit-flaky-handler Refs: nodejs#19105 Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure

- Rename test-fs-truncate-GH-6233 to test-fs-truncate-clear-file-zero - Rename test-process-exit-GH-12322 to test-process-exit-handler PR-URL: #19668 Refs: #19105 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>

Refs: #19105 Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure PR-URL: #19608 Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>

- Rename test-fs-truncate-GH-6233 to test-fs-truncate-clear-file-zero - Rename test-process-exit-GH-12322 to test-process-exit-handler PR-URL: #19668 Refs: #19105 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>

Rename the test appropriately alongside mentioning the subsystem Also, make a few basic changes to make sure the test conforms to the standard test structure Refs: nodejs#19105 Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure PR-URL: nodejs#19161 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>

Rename affected tests to remove the "regress" keyword as well as improve naming scheme. Refs: nodejs#19105 PR-URL: nodejs#19161 Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>

Refs: nodejs#19105 PR-URL: nodejs#19161 Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>

Rename the test appropriately alongside mentioning the subsystem Also, make a few basic changes to make sure the test conforms to the standard test structure Refs: nodejs#19105 Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure PR-URL: nodejs#19161 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>

Rename the tests appropriately alongside mentioning the subsystem. Also, make a few basic changes to make sure the test conforms to the standard test structure. This renames: - test-regress-nodejsGH-1531 - test-regress-nodejsGH-2245 - test-regress-nodejsGH-3238 - test-regress-nodejsGH-3542 - test-regress-nodejsGH-3739 - test-regress-nodejsGH-4256 PR-URL: nodejs#19212 Refs: nodejs#19105 Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>

Rename the tests appropriately alongside mentioning the subsystem. Also, make a few basic changes to make sure the tests conform to the standard test structure. - Rename test-regress-nodejsGH-9819 to test-crypto-tostring-segfault - Rename test-regress-nodejsGH-5051 to test-http-addrequest-localaddress - Rename test-regress-nodejsGH-5727 to test-net-listen-invalid-port - Rename test-regress-nodejsGH-5927 to test-tty-stdin-pipe - Rename test-regress-nodejsGH-6235 to test-v8-global-setter PR-URL: nodejs#19275 Refs: nodejs#19105 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>

Rename the test appropriately alongside mentioning the subsystem Also, make a few basic changes to make sure the test conforms to the standard test structure Refs: #19105 Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure PR-URL: #19161 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>

Rename affected tests to remove the "regress" keyword as well as improve naming scheme. Refs: #19105 PR-URL: #19161 Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>

Refs: #19105 PR-URL: #19161 Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>

Rename the test appropriately alongside mentioning the subsystem Also, make a few basic changes to make sure the test conforms to the standard test structure Refs: #19105 Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure PR-URL: #19161 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>

Rename the tests appropriately alongside mentioning the subsystem. Also, make a few basic changes to make sure the test conforms to the standard test structure. This renames: - test-regress-GH-1531 - test-regress-GH-2245 - test-regress-GH-3238 - test-regress-GH-3542 - test-regress-GH-3739 - test-regress-GH-4256 PR-URL: #19212 Refs: #19105 Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>

Rename the tests appropriately alongside mentioning the subsystem. Also, make a few basic changes to make sure the tests conform to the standard test structure. - Rename test-regress-GH-io-1068 to test-tty-stdin-end - Rename test-regress-GH-io-1811 to test-zlib-kmaxlength-rangeerror - Rename test-regress-GH-node-9326 to test-kill-segfault-freebsd - Rename test-timers-regress-GH-9765 to test-timers-setimmediate-infinite-loop - Rename test-tls-pfx-gh-5100-regr to test-tls-pfx-authorizationerror - Rename test-tls-regr-gh-5108 to test-tls-tlswrap-segfault PR-URL: #19332 Fixes: #19105 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Weijia Wang <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Shingo Inoue <[email protected]>

- Rename test-fs-truncate-GH-6233 to test-fs-truncate-clear-file-zero - Rename test-process-exit-GH-12322 to test-process-exit-handler PR-URL: #19668 Refs: #19105 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>

joyeecheung added the test Issues and PRs related to the tests. label Mar 3, 2018

ryzokuken mentioned this issue Mar 6, 2018

test: rename regression tests with descriptive file names #19161

Closed

8 tasks

ryzokuken added a commit to ryzokuken/node that referenced this issue Mar 6, 2018

test: rename tests to remove "regress" keyword

24016c4

Rename affected tests to remove the "regress" keyword as well as improve naming scheme. Refs: nodejs#19105

ryzokuken added a commit to ryzokuken/node that referenced this issue Mar 6, 2018

test: address nits and rename the corresponding fixture

5b96920

Refs: nodejs#19105

ryzokuken mentioned this issue Mar 7, 2018

test: rename regression tests with descriptive file names #19212

Closed

6 tasks

targos pushed a commit that referenced this issue Mar 27, 2018

test: rename regression tests more expressively

40be64d

PR-URL: #19495 Refs: #19105 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>

ryzokuken mentioned this issue Mar 29, 2018

test: rename regression tests with descriptive file names (pt. 7) #19668

Closed

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rename regression tests with descriptive file names #19105

Rename regression tests with descriptive file names #19105

joyeecheung commented Mar 3, 2018 •

edited

Loading

BridgeAR commented Mar 3, 2018

BridgeAR commented Mar 3, 2018

mcollina commented Mar 3, 2018

joyeecheung commented Mar 3, 2018 •

edited

Loading

richardlau commented Mar 3, 2018

richardlau commented Mar 3, 2018

juggernaut451 commented Mar 5, 2018

tniessen commented Mar 5, 2018 •

edited

Loading

Rename regression tests with descriptive file names #19105

Rename regression tests with descriptive file names #19105

Comments

joyeecheung commented Mar 3, 2018 • edited Loading

BridgeAR commented Mar 3, 2018

BridgeAR commented Mar 3, 2018

mcollina commented Mar 3, 2018

joyeecheung commented Mar 3, 2018 • edited Loading

richardlau commented Mar 3, 2018

richardlau commented Mar 3, 2018

juggernaut451 commented Mar 5, 2018

tniessen commented Mar 5, 2018 • edited Loading

joyeecheung commented Mar 3, 2018 •

edited

Loading

joyeecheung commented Mar 3, 2018 •

edited

Loading

tniessen commented Mar 5, 2018 •

edited

Loading