src: fix upcoming v8 deprecation warnings #19490
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
TimothyGu
approved these changes
Mar 23, 2018
src/node.cc
Outdated
| @@ -1269,9 +1269,12 @@ void AppendExceptionLine(Environment* env, | |||
| ScriptOrigin origin = message->GetScriptOrigin(); | |||
| node::Utf8Value filename(env->isolate(), message->GetScriptResourceName()); | |||
| const char* filename_string = *filename; | |||
| int linenum = message->GetLineNumber(); | |||
| Maybe<int> line_number_maybe = message->GetLineNumber(env->context()); | |||
| int linenum = line_number_maybe.FromJust(); | |||
There was a problem hiding this comment.
nit: no need for a separate line_number_maybe variable.
SirR4T
force-pushed
the
deprecationUseMaybe
branch
from
84b76a4
to
e0301a9
Compare
danbev
approved these changes
Mar 23, 2018
targos
approved these changes
Mar 23, 2018
|
Landed in c6c957d. Thanks! |
targos
pushed a commit
that referenced
this pull request
Mar 23, 2018
PR-URL: #19490 Fixes: #18909 Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
targos
pushed a commit
that referenced
this pull request
Mar 30, 2018
PR-URL: #19490 Fixes: #18909 Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Merged
blattersturm
pushed a commit
to citizenfx/node
that referenced
this pull request
Nov 3, 2018
PR-URL: nodejs#19490 Fixes: nodejs#18909 Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #18909
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes