-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: http2 stream.respond() error checks #18861
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trivikr
force-pushed
the
test-http2-respond-errors
branch
2 times, most recently
from
February 19, 2018 04:36
5cbb365
to
8b612b1
Compare
trivikr
force-pushed
the
test-http2-respond-errors
branch
from
February 19, 2018 05:22
8b612b1
to
37ec0ce
Compare
jasnell
approved these changes
Feb 20, 2018
BridgeAR
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Feb 21, 2018
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Feb 22, 2018
PR-URL: nodejs#18861 Reviewed-By: James M Snell <[email protected]>
Landed in 5782c51 🎉 |
Should this be backported to |
@MylesBorins These are just unit tests, backport to v9.x-staging is not required |
targos
added
dont-land-on-v9.x
and removed
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
backport-requested-v9.x
labels
Mar 24, 2018
targos
pushed a commit
to targos/node
that referenced
this pull request
Mar 24, 2018
PR-URL: nodejs#18861 Reviewed-By: James M Snell <[email protected]>
targos
pushed a commit
that referenced
this pull request
Mar 30, 2018
Backport-PR-URL: #19579 PR-URL: #18861 Reviewed-By: James M Snell <[email protected]>
Merged
kjin
pushed a commit
to kjin/node
that referenced
this pull request
May 1, 2018
Backport-PR-URL: nodejs#19579 PR-URL: nodejs#18861 Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
May 2, 2018
Backport-PR-URL: #19579 Backport-PR-URL: #20456 PR-URL: #18861 Reviewed-By: James M Snell <[email protected]>
Merged
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
PR-URL: nodejs#18861 Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
May 15, 2018
Backport-PR-URL: #19579 Backport-PR-URL: #20456 PR-URL: #18861 Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
May 15, 2018
Backport-PR-URL: #19579 Backport-PR-URL: #20456 PR-URL: #18861 Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code change adds tests for the following errors in
respond(headers, options)
:node/lib/internal/http2/core.js
Lines 2125 to 2128 in 472cde6
node/lib/internal/http2/core.js
Lines 2147 to 2151 in 472cde6
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAffected core subsystem(s)
http2