Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add mafintosh to collaborators #19773

Closed
wants to merge 1 commit into from
Closed

doc: add mafintosh to collaborators #19773

wants to merge 1 commit into from

Conversation

mafintosh
Copy link
Member

Checklist

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Apr 3, 2018
addaleax
addaleax approved these changes Apr 3, 2018
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

BridgeAR
BridgeAR approved these changes Apr 3, 2018
View reviewed changes
Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@mafintosh mafintosh changed the title Add mafintosh to collaborators doc: add mafintosh to collaborators Apr 3, 2018
@trivikr trivikr added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 3, 2018
@mafintosh
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request-lite/402/

@trivikr trivikr removed the fast-track PRs that do not need to wait for 48 hours to land. label Apr 3, 2018
mcollina
mcollina approved these changes Apr 3, 2018
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vsemozhetbyt vsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 3, 2018
@mafintosh
Copy link
Member Author

Landed in d54f651

@mafintosh mafintosh closed this Apr 3, 2018
@mafintosh mafintosh deleted the add-mafintosh branch April 3, 2018 16:40
mafintosh added a commit that referenced this pull request Apr 3, 2018
@mafintosh
doc: add mafintosh to collaborators
d54f651 
PR-URL: #19773
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
@mcollina mcollina mentioned this pull request Apr 3, 2018
Closed
@Trott Trott added the notable-change PRs with changes that should be highlighted in changelogs. label Apr 3, 2018
targos pushed a commit that referenced this pull request Apr 3, 2018
@mafintosh @targos
doc: add mafintosh to collaborators
42671f2 
PR-URL: #19773
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
@targos targos mentioned this pull request Apr 4, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@gibfahn gibfahn gibfahn approved these changes

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@targos targos targos approved these changes

@addaleax addaleax addaleax approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. notable-change PRs with changes that should be highlighted in changelogs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@mafintosh @mcollina @addaleax @targos @BridgeAR @vsemozhetbyt @gibfahn @trivikr @Trott @nodejs-github-bot