Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal - 7.6.0 (Current) #11185

Merged
merged 121 commits into from
Feb 22, 2017
Merged

Proposal - 7.6.0 (Current) #11185

merged 121 commits into from
Feb 22, 2017

Conversation

italoacasas
Copy link
Contributor

@italoacasas italoacasas commented Feb 5, 2017

Date - 2017/02/21, 7.6.0 (Current)

Thank you to @addaleax for helping in the release proposal.

This release contains v8 5.5, you can read more about this version in the official blog post

Release Candidates

Notable changes

  • deps:
    • update V8 to 5.5 (Michaël Zasso) #11029
    • upgrade libuv to 1.11.0 (cjihrig) #11094
    • add node-inspect 1.10.4 (Jan Krems) #10187
    • upgrade zlib to 1.2.11 (Sam Roberts) #10980
  • lib: build node inspect into node (Anna Henningsen) #10187
  • crypto: Remove expired certs from CNNIC whitelist (Shigeki Ohtsu) #9469
  • inspector: add --inspect-brk (Josh Gavant) #11149
  • fs: allow WHATWG URL objects as paths (James M Snell) #10739
  • src: support UTF-8 in compiled-in JS source files (Ben Noordhuis) #11129
  • url: extend url.format to support WHATWG URL (James M Snell) #10857

Commits

  • [5059b6fcee] - benchmark: fix typos (Nikolai Vavilov) #11287
  • [b4f3a300de] - benchmark: URLSearchParams v.s. querystring (Joyee Cheung) #11170
  • [6d2797bd80] - benchmark: fix first call to URL in useWHATWG (Joyee Cheung) #11170
  • [8f34181b95] - benchmark: add assert.deep[Strict]Equal benchmarks (Joyee Cheung) #11092
  • [94555c949a] - benchmark: simplify URLSearchParams import (Timothy Gu) #11111
  • [599c947276] - benchmarks: add spread operator benchmark (James M Snell) #11227
  • [8fdfa08ed0] - (SEMVER-MINOR) build: add node-inspect integration test (Jan Krems) #10187
  • [67d4dc061c] - build: clear stalled jobs on POSIX CI hosts (Rich Trott) #11246
  • [ae39dcbffb] - build: disable C4267 conversion compiler warning (Ben Noordhuis) #11205
  • [92ed2b5001] - (SEMVER-MINOR) build: support for mips64el (nanxiongchao) #10991
  • [1dc438fd8b] - crypto: remove unused access of tlsext_hostname (David Benjamin) #10882
  • [7af03ba3f6] - crypto: Remove expired certs from CNNIC whitelist (Shigeki Ohtsu) #9469
  • [5e98e34648] - crypto: add cert check issued by StartCom/WoSign (Shigeki Ohtsu) #9469
  • [af0154535c] - deps: upgrade zlib to 1.2.11 (Sam Roberts) #10980
  • [85f54908bf] - (SEMVER-MINOR) deps: add node-inspect 1.10.2 (Jan Krems) #10187
  • [445794e0c9] - deps: upgrade libuv to 1.11.0 (cjihrig) #11094
  • [20127e0c0a] - deps: back-port b049d1a from V8 upstream (Ben Noordhuis) #11204
  • [5446fa7e8c] - (SEMVER-MINOR) deps: work around SmartOS 14 incompatibility (Michaël Zasso) #11029
  • [028bb632b2] - (SEMVER-MINOR) deps: revert breaking UTF-8 decoder changes in V8 (Michaël Zasso) #11029
  • [22e2288f3a] - (SEMVER-MINOR) deps: ensure V8 5.4 ABI compatibility (Michaël Zasso) #11029
  • [53e00e1617] - (SEMVER-MINOR) deps: limit regress/regress-crbug-514081 v8 test (Michael Dawson) #11029
  • [7fea966a1d] - (SEMVER-MINOR) deps: cherry-pick workaround for clang-3.4 ICE (Michaël Zasso) #11029
  • [61870b429a] - (SEMVER-MINOR) deps: update V8 to 5.5.372.40 (Michaël Zasso) #11029
  • [d9ed965ae1] - dgram: remove this aliases (cjihrig) #11243
  • [2f1ce2952d] - doc: update link to V8 Embedder's guide (Franziska Hinkelmann) #11336
  • [3db54c93f8] - doc: update email and add personal pronoun (JungMinu) #11318
  • [1b08f766b1] - doc: drop "and io.js" from release section (Ben Noordhuis) #11054
  • [a5e8176fee] - doc: improve consistency in documentation titles (Vse Mozhet Byt) #11230
  • [5d2ba44fca] - doc: edit maxBuffer/Unicode paragraph for clarity (Rich Trott) #11228
  • [d5b1a4b265] - doc: clarify the behavior of Buffer.byteLength (Nikolai Vavilov) #11238
  • [0d4b0edb56] - doc: add links between cork() and uncork() (Matteo Collina) #11222
  • [266c41c2b1] - doc: add and fix System Error properties (Daiki Arai) #10986
  • [71f8a23da4] - doc: fix typo in dgram doc (Rich Trott) #11186
  • [73b32a31e0] - doc: remove extraneous paragraph from assert doc (Rich Trott) #11174
  • [abae26421e] - doc: improve testing guide (Joyee Cheung) #11150
  • [803f6b3091] - doc: fix linting command for vcbuild (Rich Trott) #11151
  • [177e9797cd] - doc: add common.WPT to test README (Rich Trott) #11127
  • [1fbbcc3c07] - doc: add not-an-aardvark as ESLint contact (Rich Trott) #11169
  • [5649174dda] - doc: typographical fixes in COLLABORATOR_GUIDE.md (Anna Henningsen) #11163
  • [ae33a15d01] - doc: fix "initial delay" link in http.md (Timo Tijhof) #11108
  • [5d58756b41] - doc: remove assertions about assert (Rich Trott) #11113
  • [3ebe306bb0] - doc: edit stability text for clarity and style (Rich Trott) #11112
  • [535492d321] - doc: clarify msg when doc/api/cli.md not updated (Stewart X Addison) #10872
  • [3ae25a0bca] - doc: add personal pronouns option (Rich Trott) #11089
  • [265a59b60f] - doc: replace newlines in deprecation with space (Sakthipriyan Vairamani (thefourtheye)) #11074
  • [598d35c087] - doc: fix confusing example in dns.md (Vse Mozhet Byt) #11022
  • [989d2cdbac] - doc: edit CONTRIBUTING.md for clarity (Rich Trott) #11045
  • [6cf06cf518] - (SEMVER-MINOR) fs: allow WHATWG URL and file: URLs as paths (James M Snell) #10739
  • [9339891b07] - fs: re-enable watch facility in AIX (Gireesh Punathil) #10085
  • [2952512b86] - lib: replace \u2019 with regular ascii quote (Ben Noordhuis) #11129
  • [3596d156c1] - (SEMVER-MINOR) lib: build node inspect into node (Anna Henningsen) #10187
  • [3074c6de7e] - meta: adding Italo A. Casas PGP Fingerprint (Italo A. Casas) #11202
  • [e530b5ae43] - meta: remove Chris Dickinson from CTC (Chris Dickinson) #11267
  • [17314eb9ca] - meta: add explicit deprecation and semver-major policy (James M Snell) #7964
  • [6a45c81edd] - readline: update 6 comparions to strict (Umair Ishaq) #11078
  • [fe2f058f17] - (SEMVER-MINOR) repl: remove workaround for function redefinition (Michaël Zasso) #11029
  • [3380cd5fdb] - src: support UTF-8 in compiled-in JS source files (Ben Noordhuis) #11129
  • [308df11658] - src: fix delete operator on vm context (Franziska Hinkelmann) #11266
  • [af06f62e35] - src: fix -Wunused-result compiler warning (Ben Noordhuis) #11197
  • [44b17a21ad] - src: refactor CopyProperties to remove JS (AnnaMag) #11102
  • [ce3dcca619] - src: update v8_platform.StartInspector signature (Myk Melez) #11157
  • [d8a5e1c37f] - src: don't overwrite non-writable vm globals (Franziska Hinkelmann) #11109
  • [9264131fb3] - src: unconsume stream fix in internal http impl (Roee Kasher) #11015
  • [c5210b203d] - src: remove usage of V8 deprecated API in node_url.cc (Timothy Gu) #11066
  • [0b64f7fc0e] - src, inspector: add --inspect-brk (Josh Gavant) #11149
  • [0d52aced0c] - stream: move legacy to lib/internal dir (yorkie) #8197
  • [0610cc707b] - test: skip IPv6 test on non-IPv6 systems (Rich Trott) #11432
  • [93d3a3a6b5] - test: add coverage for dgram _createSocketHandle() (cjihrig) #11291
  • [b140dec930] - test: refactor test-repl-sigint-nested-eval (Rich Trott) #11303
  • [1085a4675a] - test: skip when openssl CLI doesn't exist (Sota Yamashita) #11095
  • [6f866ae002] - test: improve punycode test coverage (Sebastian Van Sande) #11144
  • [68eb97442d] - test: cover cluster error during dgram socket bind (cjihrig) #11295
  • [5350f04e42] - test: refactor test-repl-sigint (Rich Trott) #11309
  • [1f3eee4f5d] - test: increase setMulticastLoopback() coverage (cjihrig) #11277
  • [6ee11f82b3] - test: refactor test-dgram-address.js (cjihrig) #11271
  • [d2ee7e20b2] - test: refactor test-readline-keys (Rich Trott) #11281
  • [f096235d04] - test: improve test-assert.js (jobala) #11193
  • [b4056994c4] - test: improve test-http-agent-destroyed-socket.js (Shubheksha Jalan) #11201
  • [803be085be] - test: querystring.escape with multibyte characters (Daijiro Wachi) #11251
  • [809aea3081] - test: refactor test-dgram-setBroadcast.js (cjihrig) #11252
  • [69f5a754e2] - test: add vm module edge cases (Franziska Hinkelmann) #11265
  • [2f15efb05b] - test: adapt test-debugger-pid to localized Windows (Vse Mozhet Byt) #11270
  • [5e5d72eb5a] - test: remove nan + weak (Ben Noordhuis) #11239
  • [969b85cdf5] - test: remove dependency on node-weak (Ben Noordhuis) #11239
  • [0cded6aac1] - test: don't call process.exit() in gc tests (Ben Noordhuis) #11239
  • [7ff32bf705] - test: add coverage for dgram send() errors (cjihrig) #11248
  • [e1beb9fbfc] - test: add coverage for string array dgram send() (cjihrig) #11247
  • [2333cd3155] - test: increase dgram ref()/unref() coverage (cjihrig) #11240
  • [480d4cc9df] - test: add coverage to dgram receive error case (cjihrig) #11241
  • [ccd1163b46] - test: refactor test-fs-buffer (Rich Trott) #11232
  • [25226ced6a] - test: improve checks in test-path-parse-format (cjihrig) #11223
  • [540dca1d18] - test: fix incorrect indentation (cjihrig) #11219
  • [f0eba7811d] - test: add common.mustNotCall() (cjihrig) #11152
  • [f6dfc3193a] - test: remove obsolete comment from dgram test (ALJCepeda) #8689
  • [9d5ffa6e49] - test: add test cases to test-readline-keys.js (abouthiroppy) #10772
  • [7ec6a69a7d] - test: add missing initialization in test-assert (Rich Trott) #11191
  • [b766dab81c] - test: increase specificity in dgram test (Rich Trott) #11187
  • [9c729211e4] - test: improve crypto.setEngine coverage to check for errors (Sebastian Van Sande) #11143
  • [3ca483f4cc] - test: throw Error objects instead of literals (Rich Trott) #11168
  • [8612a004a3] - (SEMVER-MINOR) test: move test-vm-function-redefinition to parallel (Franziska Hinkelmann) #11029
  • [fbd495583e] - test: simplify output handling in repl tests (Rich Trott) #11124
  • [7f9b436c4b] - test: make module testing stricter (Rich Trott) #11116
  • [cf098688e4] - test: fix test.py command line options processing (Julien Gilli) #11153
  • [e9f6bc60e9] - test: improve coverage on removeListeners functions (matsuda-koushi) #11140
  • [815e668209] - test: add --abort-on-timeout option to test.py (Julien Gilli) #11086
  • [cf3700b0e8] - test: fix timing sensitivity in debugger test (Ali Ijaz Sheikh) #11008
  • [3d35dcff9a] - test: make test-fs-access stricter (Rich Trott) #11087
  • [e2d9c23e72] - test: use repeat() instead of new Array().join() (Jackson Tian) #11071
  • [ea5bef5efe] - test: add path.join's test (Yuta Hiroto) #11063
  • [8d2a9138fc] - test: improve error messages in test-npm-install (Gonen Dukas) #11027
  • [8ac6a709b9] - test: add fs-assert-encoding's test (abouthiroppy) #10913
  • [e4b139d300] - timer: remove duplicated word in comment (asafdav2) #11323
  • [a2948fbe74] - tools: enable ES2017 syntax support in ESLint (Michaël Zasso) #11211
  • [7e465b9c21] - tools: add compile_commands.json gyp generator (Ben Noordhuis) #7986
  • [2dc8aac1a9] - tools: enable no-throw-literal ESLint rule (Rich Trott) #11168
  • [8547871ea2] - url: fix setting url.search to the empty string (Timothy Gu) #11105
  • [322fc20333] - (SEMVER-MINOR) url: extend url.format to support WHATWG URL (James M Snell) #10857
  • [cfadbc2661] - util: improve inspect for AsyncFunction (Michaël Zasso) #11211

Trott and others added 2 commits February 1, 2017 19:49
PR-URL: #11045
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Michal Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Currently, the example throws 'Error: getHostByAddr ENOTFOUND'
The previous example is edited for consistency.

PR-URL: #11022
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@italoacasas italoacasas added meta Issues and PRs related to the general management of the project. v7.x labels Feb 5, 2017
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. c++ Issues and PRs that require attention from people who are familiar with C++. doc Issues and PRs related to the documentations. dont-land-on-v4.x lib / src Issues and PRs related to general changes in the lib or src directory. whatwg-url Issues and PRs related to the WHATWG URL implementation. labels Feb 5, 2017
@italoacasas italoacasas removed build Issues and PRs related to build files or the CI. c++ Issues and PRs that require attention from people who are familiar with C++. doc Issues and PRs related to the documentations. dont-land-on-v4.x lib / src Issues and PRs related to general changes in the lib or src directory. whatwg-url Issues and PRs related to the WHATWG URL implementation. labels Feb 5, 2017
@Fishrock123
Copy link
Contributor

If a backport of V8 is still in progress, maybe we should let it bake another week? We could do an RC to help ensure its stability and backwards compatibility.

@MylesBorins
Copy link
Contributor

+1 on doing an RC! I should have time today / tomorrow to finish review of the PR

@bricss
Copy link

bricss commented Feb 6, 2017

Let #11094 in :octocat:

@italoacasas
Copy link
Contributor Author

Hi @bricss the PR still open, but I will include the libuv version in a RC later this week/early next one.

@targos
Copy link
Member

targos commented Feb 7, 2017

@italoacasas I just landed #11029 on v7.x-staging.

@evanlucas
Copy link
Contributor

I do think that this release should be blocked by #11094 though as it could break some third party package managers.

@dead-horse dead-horse mentioned this pull request Feb 7, 2017
9 tasks
@italoacasas
Copy link
Contributor Author

Hi everyone, my plan is to release this version as is tomorrow with the help of Evan. Next week 7.7.0 RC is going to include async, libuv and some new stuff for the new URL module if nothing fails in master in the mid time. If someone in the CTC or the release team disagree please rise the hand now.

@evanlucas
Copy link
Contributor

IMO, we shouldn't cut a release until we can fix the OS X build on anything below 10.12.

@italoacasas
Copy link
Contributor Author

italoacasas commented Feb 7, 2017

O ok, I was not aware that we have an issue with the build. I'm on my way back to home, I will get more information tomorrow.

Update: I update the PR description to avoid confusion with the date

@MylesBorins
Copy link
Contributor

+1 on not cutting yet. @evanlucas can you explain more about the breakages on OSX?

One thing I want to mention is that I would like to see releases continue to happen on Tuesdays, would rather push a week than make the release on a Wednesday if we are not in a rush. That being said an RC on a Wednesday seems super reasonable

Notable changes:

* deps:
    * update V8 to 5.5 (Michaël Zasso) [#11029](#11029)
    * upgrade libuv to 1.11.0 (cjihrig) [#11094](#11094)
    * add node-inspect 1.10.4 (Jan Krems) [#10187](#10187)
    * upgrade zlib to 1.2.11 (Sam Roberts) [#10980](#10980)
* lib: build `node inspect` into `node` (Anna Henningsen) [#10187](#10187)
* crypto: Remove expired certs from CNNIC whitelist (Shigeki Ohtsu) [#9469](#9469)
* inspector: add --inspect-brk (Josh Gavant) [#11149](#11149)
* fs: allow WHATWG URL objects as paths (James M Snell) [#10739](#10739)
* src: support UTF-8 in compiled-in JS source files (Ben Noordhuis) [#11129](#11129)
* url: extend url.format to support WHATWG URL (James M Snell) [#10857](#10857)

PR-URL: #11185
@ksmithut
Copy link

I'm guessing it's not making it out today... The guys at the office are going to kill me for reporting that typo, lol :) Thanks for all your hard work!

@MylesBorins
Copy link
Contributor

@ksmithut still quite a bit of time left in the day 😄

@italoacasas italoacasas merged commit bebda6d into v7.x Feb 22, 2017
italoacasas added a commit that referenced this pull request Feb 22, 2017
@ksmithut
Copy link

Yay!

italoacasas added a commit to italoacasas/node that referenced this pull request Feb 22, 2017
Notable changes:

* deps:
    * update V8 to 5.5 (Michaël Zasso) [nodejs#11029](nodejs#11029)
    * upgrade libuv to 1.11.0 (cjihrig) [nodejs#11094](nodejs#11094)
    * add node-inspect 1.10.4 (Jan Krems) [nodejs#10187](nodejs#10187)
    * upgrade zlib to 1.2.11 (Sam Roberts) [nodejs#10980](nodejs#10980)
* lib: build `node inspect` into `node` (Anna Henningsen) [nodejs#10187](nodejs#10187)
* crypto: Remove expired certs from CNNIC whitelist (Shigeki Ohtsu) [nodejs#9469](nodejs#9469)
* inspector: add --inspect-brk (Josh Gavant) [nodejs#11149](nodejs#11149)
* fs: allow WHATWG URL objects as paths (James M Snell) [nodejs#10739](nodejs#10739)
* src: support UTF-8 in compiled-in JS source files (Ben Noordhuis) [nodejs#11129](nodejs#11129)
* url: extend url.format to support WHATWG URL (James M Snell) [nodejs#10857](nodejs#10857)

PR-URL: nodejs#11185
MylesBorins pushed a commit to nodejs/nodejs.org that referenced this pull request Feb 22, 2017
italoacasas added a commit to italoacasas/nodejs.org that referenced this pull request Feb 22, 2017
MylesBorins pushed a commit to nodejs/nodejs.org that referenced this pull request Feb 22, 2017
@sam-github
Copy link
Contributor

@italoacasas The gist in #11185 (comment) was a list of commits in master that aren't in v7.x-staging, but I thought it was a list of commits not getting released in 7.6.0, since it was the 7.6.0 proposal under discussion here.

My mistake, I guess, you didn't use v7.x-staging for the release, you used v7.6.0-proposal, which in retrospect I can see at the top of this PR.

Is this the standard process? That a x.x.x-proposal branch will be built from a the x-staging branch, and it is the proposal branch that should be monitored to ensure commits are making it?

@MylesBorins you use a different system for LTS, right? The commits on an vLTS-staging are literally what goes into the upcoming LTS release?

@italoacasas
Copy link
Contributor Author

italoacasas commented Feb 24, 2017

@sam-github the process for LTS and Current are the same. If something is not landing in staging is not being released then.

The proposal branch is what we merge in the stable branch, but all the commits are coming from staging, and after the release just in case, the staging branch is rebased with the proposal.

staging is what you need to monitor, if something is there is going to be released 99.99% of the time.

Why the confusion?

@italoacasas
Copy link
Contributor Author

Remember I did an RC, I freeze the proposal on 02/14, the only update I did was a security fix (zlib) and the IPv6 fix to avoid getting an error from the CI. Everything else landed in staging after Feb 14 don't make this release.

@sam-github
Copy link
Contributor

@italoacasas the confusion is I asked

I personally would see a list of commits that are NOT landing on 7.x from master (other than semver-major, obviously).

But I asked the wrong question. What I wanted to say was:

I would like to see a list of commits that are NOT going to be released in 7.6.0

I asked wrong question, so got wrong answer. So it goes.

Now I know which branches I have to look at. Since I was looking at the wrong branch, I thought #11345 (comment) meant it was going to be released, but it did not.

I re-suggest that a list of commits NOT landing in the proposed release is at least as useful as the list of commits that are landing. If such a list was in this PR, I would have known that I'd missed the RC cut-off.

@italoacasas
Copy link
Contributor Author

italoacasas commented Feb 24, 2017

@sam-github I understand. I think the issue here is that I did not communicate after doing the RC that I had the intend to freeze the proposal and focus on reliability. IMO was a communication problem from my side

At the same time, if you have something important that need to be landed in 7 because security concerns, performance, etc, you can ping me and I'm going to make sure that the commit is included.

@sam-github
Copy link
Contributor

@italoacasas I thought you and I were talking about getting things into 7.6.0, but we were actually talking about 7.x-staging "sometime". Anyhow, I understand the process better now, I'll be more on top of it for the next one. Any idea when next release will be? v7.x-staging already has tons of stuff on it, 120 commits IIRC, will we RC in about 3 weeks, release in 4? Do we know?

@italoacasas
Copy link
Contributor Author

@sam-github next release Feb 28, I will create the release proposal tomorrow.

I'm going to do a weekly release, every Tuesday.

RC only when necessary, on 7.6.0 was because of v8 and some URL related stuff...

imyller added a commit to imyller/meta-nodejs that referenced this pull request Mar 2, 2017
    Notable changes:

    * deps:
        * update V8 to 5.5 (Michaël Zasso) [#11029](nodejs/node#11029)
        * upgrade libuv to 1.11.0 (cjihrig) [#11094](nodejs/node#11094)
        * add node-inspect 1.10.4 (Jan Krems) [#10187](nodejs/node#10187)
        * upgrade zlib to 1.2.11 (Sam Roberts) [#10980](nodejs/node#10980)
    * lib: build `node inspect` into `node` (Anna Henningsen) [#10187](nodejs/node#10187)
    * crypto: Remove expired certs from CNNIC whitelist (Shigeki Ohtsu) [#9469](nodejs/node#9469)
    * inspector: add --inspect-brk (Josh Gavant) [#11149](nodejs/node#11149)
    * fs: allow WHATWG URL objects as paths (James M Snell) [#10739](nodejs/node#10739)
    * src: support UTF-8 in compiled-in JS source files (Ben Noordhuis) [#11129](nodejs/node#11129)
    * url: extend url.format to support WHATWG URL (James M Snell) [#10857](nodejs/node#10857)

    PR-URL: nodejs/node#11185

Signed-off-by: Ilkka Myller <[email protected]>
@sam-github sam-github deleted the v7.6.0-proposal branch March 6, 2017 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.