Skip to content

Commit

Permalink
doc: typographical fixes in COLLABORATOR_GUIDE.md
Browse files Browse the repository at this point in the history
Fix a typo and add a missing line break.

PR-URL: #11163
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Nikolai Vavilov <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
  • Loading branch information
addaleax authored and italoacasas committed Feb 14, 2017
1 parent ae33a15 commit 5649174
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions COLLABORATOR_GUIDE.md
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ followed to determine which aspects of the Node.js API are considered

Exception to each of these points can be made if use or behavior of a given
internal API can be demonstrated to be sufficiently relied upon by the Node.js
ecosystem such that any changes would cause too much breakage. The threshhold
ecosystem such that any changes would cause too much breakage. The threshold
for what qualifies as "too much breakage" is to be decided on a case-by-case
basis by the CTC.

Expand Down Expand Up @@ -161,7 +161,8 @@ sufficient review by collaborators and approval of at least two CTC members.

Examples of breaking changes include, but are not necessarily limited to,
removal or redefinition of existing API arguments, changing return values
(except when return values do not currently exist), removing or modifying existing properties on an options argument, adding or removing errors,
(except when return values do not currently exist), removing or modifying
existing properties on an options argument, adding or removing errors,
changing error messages in any way, altering expected timing of an event (e.g.
moving from sync to async responses or vice versa), and changing the
non-internal side effects of using a particular API.
Expand Down

0 comments on commit 5649174

Please sign in to comment.