test: skip when openssl CLI doesn't exist #11095
Conversation
|
@sam-github I changed the commit message |
sotayamashita
changed the title
|
@abouthiroppy |
|
@sotayamashita I think these failures are not caused by code🙃 CC @nodejs/testing |
|
@sotayamashita those look like infrastructure problems. |
|
@gibfahn Thanks. |
|
@sam-github I changed the commit message. Is it ok ? |
|
Aborted CI, only |
|
One more attempt at CI run: https://ci.nodejs.org/job/node-test-pull-request/6205/ |
addaleax
dismissed
sam-github’s stale review
requested changes have been made
There was a problem hiding this comment.
One more CI attempt: https://ci.nodejs.org/job/node-test-commit/7674/
|
New CI since there's some red in that last run: https://ci.nodejs.org/job/node-test-pull-request/6273/ |
Sorry, didn't see this before. Only collaborators have the access to run jobs in the Jenkins CI (ci.nodejs.org). Someone should run the CI for you when you submit the PR, if they don't you can comment asking for it to be run. As long as you've followed CONTRIBUTING.md and run Once CI has been run, you can click on the link and see the results, if there are any failures that seem related to changes you made you can investigate (but they could also just be infrastructure issues). In general if you're not sure about something, you can always ask. |
|
Landed in 5ffb7d7 |
PR-URL: #11095 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Sam Roberts <[email protected]>
PR-URL: nodejs#11095 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Sam Roberts <[email protected]>
|
needs a backport PR to land on v4 or v6 |
|
@jasnell I would like to implement but I don not know hot to do it. Is there document ? |
|
The process is fairly simple. To backport for v6, for instance, create a working branch off the Then cherry-pick the commit that landed in master You will see that there are a number of conflicts to be resolved. Make the necessary changes to fix those conflicts, then complete the cherry-pick using: Push the branch to your fork on Github and open a new PR against Make sure to run |
|
@jasnell Thank you very much. I really appreciate your thoughtfulness. |
Backport-PR-URL: #12173 PR-URL: #11095 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Sam Roberts <[email protected]>
Backport-PR-URL: #12173 PR-URL: #11095 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Sam Roberts <[email protected]>
Backport-PR-URL: nodejs/node#12173 PR-URL: nodejs/node#11095 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Sam Roberts <[email protected]>
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test
I fixed #9509.