Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add coverage to dgram receive error case #11241

Merged
merged 1 commit into from
Feb 10, 2017
Merged

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Feb 8, 2017

This commit adds coverage for the case where a dgram socket
handle receives a message, but nread < 0, indicating an error.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Feb 8, 2017
@mscdex mscdex added the dgram Issues and PRs related to the dgram subsystem / UDP. label Feb 8, 2017
@hiroppy
Copy link
Member

hiroppy commented Feb 9, 2017

This commit adds coverage for the case where a dgram socket
handle receives a message, but nread < 0, indicating an error.

PR-URL: nodejs#11241
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
@cjihrig cjihrig merged commit 1683299 into nodejs:master Feb 10, 2017
@cjihrig cjihrig deleted the recv-err branch February 10, 2017 17:28
italoacasas pushed a commit that referenced this pull request Feb 13, 2017
This commit adds coverage for the case where a dgram socket
handle receives a message, but nread < 0, indicating an error.

PR-URL: #11241
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Feb 14, 2017
This commit adds coverage for the case where a dgram socket
handle receives a message, but nread < 0, indicating an error.

PR-URL: nodejs#11241
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
krydos pushed a commit to krydos/node that referenced this pull request Feb 25, 2017
This commit adds coverage for the case where a dgram socket
handle receives a message, but nread < 0, indicating an error.

PR-URL: nodejs#11241
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
@jasnell
Copy link
Member

jasnell commented Mar 8, 2017

Depends on common.mustNotCall() to be backported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dgram Issues and PRs related to the dgram subsystem / UDP. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants