Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: refactor test-dgram-address.js #11271

Merged
merged 1 commit into from
Feb 13, 2017
Merged

test: refactor test-dgram-address.js #11271

merged 1 commit into from
Feb 13, 2017

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Feb 9, 2017

  • separate the IPv4 and IPv6 tests using block scopes
  • use common.mustCall() and arrow functions for callbacks
  • add coverage for case where address() throws
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Feb 9, 2017
@cjihrig cjihrig added the dgram Issues and PRs related to the dgram subsystem / UDP. label Feb 9, 2017
@cjihrig
Copy link
Contributor Author

cjihrig commented Feb 10, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/6338/

@cjihrig
test: refactor test-dgram-address.js
3a1e67d 
- separate the IPv4 and IPv6 tests using block scopes
- use common.mustCall() and arrow functions for callbacks
- add coverage for case where address() throws

PR-URL: nodejs#11271
Reviewed-By: James M Snell <[email protected]>
@cjihrig cjihrig merged commit 3a1e67d into nodejs:master Feb 13, 2017
@cjihrig cjihrig deleted the address branch February 13, 2017 15:09
italoacasas pushed a commit to italoacasas/node that referenced this pull request Feb 14, 2017
@cjihrig @italoacasas
test: refactor test-dgram-address.js
6ee11f8 
- separate the IPv4 and IPv6 tests using block scopes
- use common.mustCall() and arrow functions for callbacks
- add coverage for case where address() throws

PR-URL: nodejs#11271
Reviewed-By: James M Snell <[email protected]>
@italoacasas italoacasas mentioned this pull request Feb 14, 2017
Merged
@rvagg rvagg mentioned this pull request Feb 16, 2017
Closed
2 tasks
@jasnell
Copy link
Member

jasnell commented Mar 9, 2017

Needs backport PRs if it should land on v6 or v4

@piascikj piascikj mentioned this pull request Oct 3, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
dgram Issues and PRs related to the dgram subsystem / UDP. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cjihrig @jasnell @nodejs-github-bot