test: improve crypto.setEngine coverage to check for errors #11143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
approved these changes
Feb 3, 2017
test/parallel/test-crypto-engine.js
Outdated
| }, /"id" argument should be a string/); | ||
|
|
||
| assert.throws(function() { | ||
| crypto.setEngine('/path/to/engine', 'notANumber') |
There was a problem hiding this comment.
Does the linter pass with these (make lint)? We do use semicolons to end statements 😄
hiroppy
suggested changes
Feb 3, 2017
test/parallel/test-crypto-engine.js
Outdated
|
|
||
| assert.throws(function() { | ||
| crypto.setEngine(true) | ||
| }, /"id" argument should be a string/); |
There was a problem hiding this comment.
You can write /^TypeError: "id" argument should be a string$/ :)
seppevs
force-pushed
the
test_crypto_engine
branch
2 times, most recently
from
5618f04
to
d9121e9
Compare
|
I did the changes:
I amended the changes to the previous commit. |
hiroppy
approved these changes
Feb 3, 2017
seppevs
force-pushed
the
test_crypto_engine
branch
from
d9121e9
to
a82e13d
Compare
|
cc/ @nodejs/crypto @sam-github |
|
This is duplicated to #10786 and related #10865. I'm now waiting for resolve nodejs/build#596. |
jasnell
approved these changes
Feb 7, 2017
jasnell
pushed a commit
that referenced
this pull request
Feb 7, 2017
PR-URL: #11143 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Landed in ddbfdba |
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Feb 9, 2017
PR-URL: nodejs#11143 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: James M Snell <[email protected]>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Feb 14, 2017
PR-URL: nodejs#11143 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: James M Snell <[email protected]>
krydos
pushed a commit
to krydos/node
that referenced
this pull request
Feb 25, 2017
PR-URL: nodejs#11143 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: James M Snell <[email protected]>
jasnell
pushed a commit
that referenced
this pull request
Mar 7, 2017
PR-URL: #11143 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Would require a backport PR to land on v4 |
MylesBorins
pushed a commit
that referenced
this pull request
Mar 9, 2017
PR-URL: #11143 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test: improve crypto.setEngine test coverage to check for errors
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
N/A