test: refactor test-repl-sigint-nested-eval #11303
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remove debugging code that prints child stdout * indexOf() -> includes() * improved messages on assertion failures
Trott
added
repl
addaleax
approved these changes
Feb 10, 2017
cjihrig
approved these changes
Feb 10, 2017
jasnell
approved these changes
Feb 10, 2017
lpinca
approved these changes
Feb 12, 2017
thefourtheye
approved these changes
Feb 12, 2017
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Feb 13, 2017
* remove debugging code that prints child stdout * indexOf() -> includes() * improved messages on assertion failures PR-URL: nodejs#11303 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
|
Landed in 4762791 |
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Feb 14, 2017
* remove debugging code that prints child stdout * indexOf() -> includes() * improved messages on assertion failures PR-URL: nodejs#11303 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
jasnell
pushed a commit
that referenced
this pull request
Mar 7, 2017
* remove debugging code that prints child stdout * indexOf() -> includes() * improved messages on assertion failures PR-URL: #11303 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 9, 2017
* remove debugging code that prints child stdout * indexOf() -> includes() * improved messages on assertion failures PR-URL: #11303 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test repl