Fix internal JS clients disconnecting on account max connection updates#7258
Merged
neilalexander merged 2 commits intomainfrom Sep 8, 2025
Merged
Fix internal JS clients disconnecting on account max connection updates#7258neilalexander merged 2 commits intomainfrom
neilalexander merged 2 commits intomainfrom
Conversation
Signed-off-by: Waldemar Quevedo <wally@nats.io>
wallyqs
force-pushed
the
acc-js-reconnect
branch
from
6790c44 to
c63b1ed
Compare
wallyqs
force-pushed
the
acc-js-reconnect
branch
from
c63b1ed to
5c405b7
Compare
derekcollison
approved these changes
Sep 4, 2025
Member
derekcollison
left a comment
derekcollison
left a comment
There was a problem hiding this comment.
LGTM
Should this just be a helper so we do not have to go through list twice?
Member
|
Right now we loop through that list twice - which if big could be costly. |
Signed-off-by: Waldemar Quevedo <wally@nats.io>
wallyqs
force-pushed
the
acc-js-reconnect
branch
from
5c405b7 to
737c7d2
Compare
Member
Author
|
updated with a helper to avoid looping twice over clients. |
neilalexander
added a commit
that referenced
this pull request
Sep 8, 2025
Includes the following: - #7200 - #7201 - #7202 - #7209 - #7210 - #7211 - #7213 - #7212 - #7216 - #7217 - #7230 - #7239 - #7246 - #7248 - 8241a15, specifically delayed errors that are not JS API errors - #7158 (not containing 2.12-specific changes) - #7233 - #7255 - #7249 - #7259 - #7265 - #7273 (not including Go 1.25.x) - #7258 - #7222 Signed-off-by: Maurice van Veen <github@mauricevanveen.com> Signed-off-by: Neil Twigg <neil@nats.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a condition where when running into a account max connections limit, sometimes a number of JetStream streams would have lost interest after getting a
JETSTREAM - maximum account active connections exceedederror.Signed-off-by: Waldemar Quevedo wally@nats.io