[ADDED] Assert leader never receives appendEntry for same term#7248
Merged
neilalexander merged 1 commit intomainfrom Sep 2, 2025
Merged
[ADDED] Assert leader never receives appendEntry for same term#7248neilalexander merged 1 commit intomainfrom
neilalexander merged 1 commit intomainfrom
Conversation
Replace wrong comment about leaders that need to break tie when using same term, with a assert.Unreachable. Two leaders should never use the same term. Signed-off-by: Daniele Sciascia <daniele@nats.io>
sciascid
force-pushed
the
no-multiple-leaders
branch
from
7020dc7 to
55dd23a
Compare
MauriceVanVeen
pushed a commit
that referenced
this pull request
Sep 3, 2025
Replace wrong comment about leaders that need to break tie when using same term, with a assert.Unreachable. Two leaders should never use the same term. Signed-off-by: Daniele Sciascia <daniele@nats.io>
wallyqs
changed the title
neilalexander
added a commit
that referenced
this pull request
Sep 8, 2025
Includes the following: - #7200 - #7201 - #7202 - #7209 - #7210 - #7211 - #7213 - #7212 - #7216 - #7217 - #7230 - #7239 - #7246 - #7248 - 8241a15, specifically delayed errors that are not JS API errors - #7158 (not containing 2.12-specific changes) - #7233 - #7255 - #7249 - #7259 - #7265 - #7273 (not including Go 1.25.x) - #7258 - #7222 Signed-off-by: Maurice van Veen <github@mauricevanveen.com> Signed-off-by: Neil Twigg <neil@nats.io>
neilalexander
added a commit
that referenced
this pull request
Sep 11, 2025
Antithesis reproduced a case of `Two leaders using the same term` (#7248) by having a server receive a vote request to stepdown due to a leader with a higher term in one goroutine, but at the same time shutting down the server which also steps down the Raft nodes. This would then result in sending an append entry for a leader transfer with the higher term, while not being leader anymore. Also fixes a case where we could technically perform catchup while not being leader anymore, or with a too high term. Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace wrong comment about leaders that need to break tie when using same term, with a assert.Unreachable. Two leaders should never use the same term.
Signed-off-by: Daniele Sciascia daniele@nats.io