Skip to content

[FIXED] Reject parallel clustered stream create#7210

Merged
neilalexander merged 1 commit intomainfrom
maurice/propose-1-stream
Aug 26, 2025
Merged

[FIXED] Reject parallel clustered stream create#7210
neilalexander merged 1 commit intomainfrom
maurice/propose-1-stream

Conversation

@MauriceVanVeen
Copy link
Copy Markdown
Member

In addition to #7202, this PR adds short-term protection for parallel stream creation if the to-be-created stream config doesn't equal what's inflight.

Signed-off-by: Maurice van Veen github@mauricevanveen.com

Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
@MauriceVanVeen MauriceVanVeen requested a review from a team as a code owner August 25, 2025 19:38
Copy link
Copy Markdown
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this fixes this test: 0ff90b8

@neilalexander neilalexander merged commit 10a3d55 into main Aug 26, 2025
67 of 70 checks passed
@neilalexander neilalexander deleted the maurice/propose-1-stream branch August 26, 2025 08:35
neilalexander added a commit that referenced this pull request Aug 26, 2025
Follow up from #7210

Signed-off-by: Waldemar Quevedo <wally@nats.io>
MauriceVanVeen pushed a commit that referenced this pull request Sep 3, 2025
In addition to #7202, this PR
adds short-term protection for parallel stream creation if the
to-be-created stream config doesn't equal what's inflight.

Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
MauriceVanVeen pushed a commit that referenced this pull request Sep 3, 2025
Follow up from #7210

Signed-off-by: Waldemar Quevedo <wally@nats.io>
neilalexander added a commit that referenced this pull request Sep 8, 2025
Includes the following:
- #7200
- #7201
- #7202
- #7209
- #7210
- #7211
- #7213
- #7212
- #7216
- #7217
- #7230
- #7239
- #7246
- #7248
-
8241a15,
specifically delayed errors that are not JS API errors
- #7158 (not containing
2.12-specific changes)
- #7233
- #7255
- #7249
- #7259
- #7265
- #7273 (not including Go
1.25.x)
- #7258
- #7222

Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
Signed-off-by: Neil Twigg <neil@nats.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants