[FIXED] LeafNode: Subject propagation with daisy chain and import/export#7255
Merged
derekcollison merged 1 commit intomainfrom Sep 3, 2025
Merged
[FIXED] LeafNode: Subject propagation with daisy chain and import/export#7255derekcollison merged 1 commit intomainfrom
derekcollison merged 1 commit intomainfrom
Conversation
The issue can be observed for instance with JetStream and source streams, that would not be populating properly depending on where a server connects to in a given topology. See the new test `TestLeafNodeDaisyChainWithAccountImportExport` for a demonstration of the issue without the fix in place. Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
kozlovic
commented
Sep 3, 2025
| // this function already takes care of not sending to a spoke leafnode since | ||
| // the `nsub` here is already from a spoke leafnode, but to be explicit, we | ||
| // use this version that updates only leafnodes that connect to this server. | ||
| im.acc.updateLeafNodesEx(&nsub, 1, true) |
Member
Author
There was a problem hiding this comment.
@derekcollison I am pretty sure that - as of now, and with the test case I have added - we would not need a new function, but decided after much thinking, that I would have this version that excludes some type of leafnode connections. Let me know if you want me to remove that and simply use updateLeafNodes().
derekcollison
approved these changes
Sep 3, 2025
| // this function already takes care of not sending to a spoke leafnode since | ||
| // the `nsub` here is already from a spoke leafnode, but to be explicit, we | ||
| // use this version that updates only leafnodes that connect to this server. | ||
| im.acc.updateLeafNodesEx(&nsub, 1, true) |
neilalexander
added a commit
that referenced
this pull request
Sep 8, 2025
Includes the following: - #7200 - #7201 - #7202 - #7209 - #7210 - #7211 - #7213 - #7212 - #7216 - #7217 - #7230 - #7239 - #7246 - #7248 - 8241a15, specifically delayed errors that are not JS API errors - #7158 (not containing 2.12-specific changes) - #7233 - #7255 - #7249 - #7259 - #7265 - #7273 (not including Go 1.25.x) - #7258 - #7222 Signed-off-by: Maurice van Veen <github@mauricevanveen.com> Signed-off-by: Neil Twigg <neil@nats.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue can be observed for instance with JetStream and source streams, that would not be populating properly depending on where a server connects to in a given topology. See the new test
TestLeafNodeDaisyChainWithAccountImportExportfor a demonstration of the issue without the fix in place.Signed-off-by: Ivan Kozlovic ivan@synadia.com