[ADDED] Add assert.Unreachable when losing commits#7213
Merged
neilalexander merged 1 commit intomainfrom Aug 26, 2025
Merged
Conversation
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
MauriceVanVeen
pushed a commit
that referenced
this pull request
Sep 3, 2025
To support our testing in Antithesis, add an explicit assert when truncating data that was meant to be committed. Before we'd only be notified based on logging `Resetting WAL state`, but even if the WAL is not reset entirely losing just a single committed message already violates correctness. This assert is purely added to make it easier to spot any issues in Antithesis, and given our effort in fixing replication bugs I don't expect this assert to fail. It will just be there being a more strict guard for safety. Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
wallyqs
changed the title
neilalexander
added a commit
that referenced
this pull request
Sep 8, 2025
Includes the following: - #7200 - #7201 - #7202 - #7209 - #7210 - #7211 - #7213 - #7212 - #7216 - #7217 - #7230 - #7239 - #7246 - #7248 - 8241a15, specifically delayed errors that are not JS API errors - #7158 (not containing 2.12-specific changes) - #7233 - #7255 - #7249 - #7259 - #7265 - #7273 (not including Go 1.25.x) - #7258 - #7222 Signed-off-by: Maurice van Veen <github@mauricevanveen.com> Signed-off-by: Neil Twigg <neil@nats.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To support our testing in Antithesis, add an explicit assert when truncating data that was meant to be committed. Before we'd only be notified based on logging
Resetting WAL state, but even if the WAL is not reset entirely losing just a single committed message already violates correctness.This assert is purely added to make it easier to spot any issues in Antithesis, and given our effort in fixing replication bugs I don't expect this assert to fail. It will just be there being a more strict guard for safety.
Signed-off-by: Maurice van Veen github@mauricevanveen.com