[IMPROVED] Enhance JWT validation for scoped users#7217
Merged
neilalexander merged 1 commit intomainfrom Aug 27, 2025
Merged
Conversation
Member
Author
|
@MauriceVanVeen I couldn't finds a way of loading the preload to check that the account indeed had a scoped signing key. However the hint is that if the permissions are empty, and it is a signing key the permissions will come from the account when presented to the server. |
Signed-off-by: Alberto Ricart <alberto@synadia.com>
aricart
force-pushed
the
relax-sentinel-token-verification
branch
from
bd21975 to
894112f
Compare
Member
|
This approach sounds good. I think we can't guarantee the preload contains the account for the |
MauriceVanVeen
pushed a commit
that referenced
this pull request
Sep 3, 2025
Updated logic to allow scoped users with `IssuerAccount` and empty permissions to bypass immediate validation, with runtime rejection if invalid. Fix #7137 Signed-off-by: Your Name alberto@synadia.io
wallyqs
changed the title
neilalexander
added a commit
that referenced
this pull request
Sep 8, 2025
Includes the following: - #7200 - #7201 - #7202 - #7209 - #7210 - #7211 - #7213 - #7212 - #7216 - #7217 - #7230 - #7239 - #7246 - #7248 - 8241a15, specifically delayed errors that are not JS API errors - #7158 (not containing 2.12-specific changes) - #7233 - #7255 - #7249 - #7259 - #7265 - #7273 (not including Go 1.25.x) - #7258 - #7222 Signed-off-by: Maurice van Veen <github@mauricevanveen.com> Signed-off-by: Neil Twigg <neil@nats.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated logic to allow scoped users with
IssuerAccountand empty permissions to bypass immediate validation, with runtime rejection if invalid.Fix #7137
Signed-off-by: Your Name alberto@synadia.io