[FIXED] Cache and limit pending entries#7233
Merged
neilalexander merged 1 commit intomainfrom Aug 29, 2025
Merged
Conversation
server/raft.go
Outdated
| // cachePendingEntry saves append entries in memory for faster processing during applyCommit. | ||
| // Only save so many however to avoid memory bloat. | ||
| func (n *raft) cachePendingEntry(ae *appendEntry) { | ||
| if l := len(n.pae); l <= paeDropThreshold { |
Member
There was a problem hiding this comment.
I realise it’s pedantic but this will put us one above paeDropThreshold, although it probably doesn’t matter much. Might make sense to put this to < and then make the log condition >=.
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
MauriceVanVeen
force-pushed
the
maurice/infinite-pae
branch
from
5440ab7 to
93a435d
Compare
neilalexander
added a commit
that referenced
this pull request
Sep 8, 2025
Includes the following: - #7200 - #7201 - #7202 - #7209 - #7210 - #7211 - #7213 - #7212 - #7216 - #7217 - #7230 - #7239 - #7246 - #7248 - 8241a15, specifically delayed errors that are not JS API errors - #7158 (not containing 2.12-specific changes) - #7233 - #7255 - #7249 - #7259 - #7265 - #7273 (not including Go 1.25.x) - #7258 - #7222 Signed-off-by: Maurice van Veen <github@mauricevanveen.com> Signed-off-by: Neil Twigg <neil@nats.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Raft group leader would cache all pending entries in
n.pae, allowing it to grow infinitely when applies are slower than the proposals themselves. This PR extracts that logic so the leader and follower caching paths are the same, as well as applying the same limits.Signed-off-by: Maurice van Veen github@mauricevanveen.com