fix: Outline color now respects OS force colors settings #28182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit fb13fb6:
|
Collaborator
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| AttachmentMinimalPerf.default | 90 | 77 | 1.17:1 |
| EmbedMinimalPerf.default | 1908 | 1719 | 1.11:1 |
| ListWith60ListItems.default | 387 | 348 | 1.11:1 |
| TextMinimalPerf.default | 205 | 187 | 1.1:1 |
| CarouselMinimalPerf.default | 272 | 250 | 1.09:1 |
| SliderMinimalPerf.default | 756 | 703 | 1.08:1 |
| ChatWithPopoverPerf.default | 212 | 198 | 1.07:1 |
| FormMinimalPerf.default | 240 | 229 | 1.05:1 |
| GridMinimalPerf.default | 203 | 193 | 1.05:1 |
| CustomToolbarPrototype.default | 1486 | 1413 | 1.05:1 |
| TreeWith60ListItems.default | 87 | 83 | 1.05:1 |
| ListNestedPerf.default | 329 | 315 | 1.04:1 |
| LoaderMinimalPerf.default | 194 | 186 | 1.04:1 |
| StatusMinimalPerf.default | 404 | 387 | 1.04:1 |
| IconMinimalPerf.default | 386 | 370 | 1.04:1 |
| ButtonOverridesMissPerf.default | 652 | 636 | 1.03:1 |
| DividerMinimalPerf.default | 213 | 207 | 1.03:1 |
| DropdownMinimalPerf.default | 1440 | 1397 | 1.03:1 |
| HeaderMinimalPerf.default | 213 | 207 | 1.03:1 |
| ListMinimalPerf.default | 317 | 308 | 1.03:1 |
| PopupMinimalPerf.default | 350 | 340 | 1.03:1 |
| ProviderMinimalPerf.default | 204 | 199 | 1.03:1 |
| AlertMinimalPerf.default | 154 | 151 | 1.02:1 |
| ButtonMinimalPerf.default | 88 | 86 | 1.02:1 |
| ChatMinimalPerf.default | 435 | 428 | 1.02:1 |
| FlexMinimalPerf.default | 153 | 152 | 1.01:1 |
| LabelMinimalPerf.default | 227 | 224 | 1.01:1 |
| LayoutMinimalPerf.default | 200 | 199 | 1.01:1 |
| ListCommonPerf.default | 403 | 400 | 1.01:1 |
| ProviderMergeThemesPerf.default | 674 | 670 | 1.01:1 |
| RadioGroupMinimalPerf.default | 273 | 270 | 1.01:1 |
| ReactionMinimalPerf.default | 207 | 205 | 1.01:1 |
| TextAreaMinimalPerf.default | 287 | 285 | 1.01:1 |
| ToolbarMinimalPerf.default | 548 | 543 | 1.01:1 |
| TreeMinimalPerf.default | 474 | 467 | 1.01:1 |
| AttachmentSlotsPerf.default | 647 | 645 | 1:1 |
| CheckboxMinimalPerf.default | 1136 | 1136 | 1:1 |
| DropdownManyItemsPerf.default | 394 | 395 | 1:1 |
| InputMinimalPerf.default | 536 | 534 | 1:1 |
| RefMinimalPerf.default | 107 | 107 | 1:1 |
| VideoMinimalPerf.default | 426 | 426 | 1:1 |
| AccordionMinimalPerf.default | 86 | 87 | 0.99:1 |
| ItemLayoutMinimalPerf.default | 710 | 716 | 0.99:1 |
| MenuMinimalPerf.default | 489 | 495 | 0.99:1 |
| MenuButtonMinimalPerf.default | 943 | 953 | 0.99:1 |
| SegmentMinimalPerf.default | 193 | 195 | 0.99:1 |
| SplitButtonMinimalPerf.default | 2236 | 2267 | 0.99:1 |
| TableMinimalPerf.default | 235 | 238 | 0.99:1 |
| AnimationMinimalPerf.default | 296 | 302 | 0.98:1 |
| ChatDuplicateMessagesPerf.default | 150 | 153 | 0.98:1 |
| HeaderSlotsPerf.default | 464 | 472 | 0.98:1 |
| TableManyItemsPerf.default | 1094 | 1119 | 0.98:1 |
| TooltipMinimalPerf.default | 1239 | 1259 | 0.98:1 |
| BoxMinimalPerf.default | 192 | 197 | 0.97:1 |
| DialogMinimalPerf.default | 445 | 461 | 0.97:1 |
| SkeletonMinimalPerf.default | 194 | 201 | 0.97:1 |
| DatepickerMinimalPerf.default | 3742 | 3916 | 0.96:1 |
| ImageMinimalPerf.default | 223 | 232 | 0.96:1 |
| RosterPerf.default | 1451 | 1509 | 0.96:1 |
| AvatarMinimalPerf.default | 103 | 108 | 0.95:1 |
| CardMinimalPerf.default | 307 | 325 | 0.94:1 |
| ButtonSlotsPerf.default | 309 | 331 | 0.93:1 |
| PortalMinimalPerf.default | 79 | 89 | 0.89:1 |
Collaborator
📊 Bundle size report🤖 This report was generated against 5c4d358b05f8e5fb90cdd59aab2be560c7d6d947 |
Collaborator
🕵 FluentUI-v0 No visual regressions between this PR and main |
added 2 commits
June 11, 2023 21:07
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Jun 13, 2023
* master: applying package updates doc: Remove wrong recommendation from input (microsoft#28168) fix: Outline color now respects OS force colors settings (microsoft#28182) Datepicker onCalendarOpenStateChange prop (microsoft#28136) feat(react-file-type-icons): Add getFileTypeIconAsUrl utility (microsoft#27336) applying package updates [FIX] Updates selection dot and label positioning for ChoiceGroupOption when an Image or Icon is present. (microsoft#28173) chore(react-infobutton): Rename InfoTip to InfoIcon (microsoft#28177) fix(react-datepicker-compat): Make DatePicker Compat stories SSR safe (microsoft#28017) Added `tab` focus mode to the Breadcrumb (microsoft#28046) docs: Add usable documentation (microsoft#28155) applying package updates Fix up rebase code (microsoft#27864) fix: ContextualMenu indexing in sections (microsoft#28127) applying package updates fix: Layer sets focus visible classname for its FocusRectsProvider (microsoft#28157) docs(react-infobutton): Update stories to show better guidance (microsoft#28144) fix(react-avatar): Do not render the image when src prop is undefined (microsoft#28146) feat(react-datepicker-compat): Add null to value prop and handle controlled cases correctly (microsoft#28056)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
Outline ignores forced colors by OS. See #27878 for more details.
New Behavior
The outline styles generated now use system
Highlightcolor for outline.Related Issue(s)