fix(react-datepicker-compat): Make DatePicker Compat stories SSR safe #28017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to react-datepicker-compat/label-fix
sopranopillow
added
Fluent UI react-components (v9)
Component: DatePickerCompat
Contributor
Author
|
This is the correct change, but this bug is coming up #27931. Once it's fixed this PR will be ready to merge. |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: e101115deef04a486083afb56af060c03d9fa9f3 (build) |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 27d23cf:
|
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Collaborator
🕵 fluentuiv9 No visual regressions between this PR and main |
…to react-datepicker-compat/label-fix
Contributor
Author
|
@layershifter the error causing the crash (not the Date.now()) has been resolved and therefore the change is ready to be made! |
khmakoto
approved these changes
Jun 6, 2023
layershifter
reviewed
Jun 7, 2023
...t-components/react-datepicker-compat/stories/DatePicker/DatePickerDateBoundaries.stories.tsx
Outdated
Show resolved
Hide resolved
…al:sopranopillow/fluentui into react-datepicker-compat/label-fix
layershifter
approved these changes
Jun 8, 2023
Hotell
approved these changes
Jun 8, 2023
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Jun 13, 2023
* master: applying package updates doc: Remove wrong recommendation from input (microsoft#28168) fix: Outline color now respects OS force colors settings (microsoft#28182) Datepicker onCalendarOpenStateChange prop (microsoft#28136) feat(react-file-type-icons): Add getFileTypeIconAsUrl utility (microsoft#27336) applying package updates [FIX] Updates selection dot and label positioning for ChoiceGroupOption when an Image or Icon is present. (microsoft#28173) chore(react-infobutton): Rename InfoTip to InfoIcon (microsoft#28177) fix(react-datepicker-compat): Make DatePicker Compat stories SSR safe (microsoft#28017) Added `tab` focus mode to the Breadcrumb (microsoft#28046) docs: Add usable documentation (microsoft#28155) applying package updates Fix up rebase code (microsoft#27864) fix: ContextualMenu indexing in sections (microsoft#28127) applying package updates fix: Layer sets focus visible classname for its FocusRectsProvider (microsoft#28157) docs(react-infobutton): Update stories to show better guidance (microsoft#28144) fix(react-avatar): Do not render the image when src prop is undefined (microsoft#28146) feat(react-datepicker-compat): Add null to value prop and handle controlled cases correctly (microsoft#28056)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
Date boundaries story uses Date.now().
New Behavior
Date boundaries story no longer uses Date.now().
Related Issue(s)