fix: Layer sets focus visible classname for its FocusRectsProvider #28157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smhigley
commented
Jun 6, 2023
smhigley
commented
Jun 6, 2023
Asset size changes
Baseline commit: 7eca299aed541ae297ab5bc7d511e64f56570932 (build) |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 6b59b9e:
|
Collaborator
📊 Bundle size report🤖 This report was generated against 7eca299aed541ae297ab5bc7d511e64f56570932 |
Collaborator
🕵 fluentuiv8 No visual regressions between this PR and main |
micahgodbolt
approved these changes
Jun 6, 2023
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 629 | 638 | 5000 | |
| Breadcrumb | mount | 1642 | 1661 | 1000 | |
| Checkbox | mount | 1686 | 1677 | 5000 | |
| CheckboxBase | mount | 1446 | 1459 | 5000 | |
| ChoiceGroup | mount | 2890 | 2925 | 5000 | |
| ComboBox | mount | 648 | 643 | 1000 | |
| CommandBar | mount | 6156 | 6164 | 1000 | |
| ContextualMenu | mount | 11261 | 11323 | 1000 | |
| DefaultButton | mount | 750 | 730 | 5000 | |
| DetailsRow | mount | 2147 | 2174 | 5000 | |
| DetailsRowFast | mount | 2208 | 2172 | 5000 | |
| DetailsRowNoStyles | mount | 1984 | 1978 | 5000 | |
| Dialog | mount | 2736 | 2749 | 1000 | |
| DocumentCardTitle | mount | 229 | 225 | 1000 | |
| Dropdown | mount | 1949 | 1968 | 5000 | |
| FocusTrapZone | mount | 1125 | 1109 | 5000 | |
| FocusZone | mount | 1061 | 1040 | 5000 | |
| GroupedList | mount | 40708 | 41011 | 2 | |
| GroupedList | virtual-rerender | 19710 | 19383 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 50162 | 49808 | 2 | |
| GroupedListV2 | mount | 223 | 237 | 2 | |
| GroupedListV2 | virtual-rerender | 206 | 209 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 231 | 229 | 2 | |
| IconButton | mount | 1054 | 1057 | 5000 | |
| Label | mount | 333 | 336 | 5000 | |
| Layer | mount | 2672 | 2728 | 5000 | |
| Link | mount | 386 | 393 | 5000 | |
| MenuButton | mount | 957 | 934 | 5000 | |
| MessageBar | mount | 21508 | 21489 | 5000 | |
| Nav | mount | 1908 | 1926 | 1000 | |
| OverflowSet | mount | 768 | 759 | 5000 | |
| Panel | mount | 1769 | 1775 | 1000 | |
| Persona | mount | 745 | 764 | 1000 | |
| Pivot | mount | 851 | 832 | 1000 | |
| PrimaryButton | mount | 828 | 836 | 5000 | |
| Rating | mount | 4593 | 4629 | 5000 | |
| SearchBox | mount | 896 | 873 | 5000 | |
| Shimmer | mount | 1847 | 1837 | 5000 | |
| Slider | mount | 1318 | 1317 | 5000 | |
| SpinButton | mount | 2873 | 2810 | 5000 | |
| Spinner | mount | 375 | 388 | 5000 | |
| SplitButton | mount | 1822 | 1822 | 5000 | |
| Stack | mount | 398 | 404 | 5000 | |
| StackWithIntrinsicChildren | mount | 836 | 858 | 5000 | |
| StackWithTextChildren | mount | 2607 | 2607 | 5000 | |
| SwatchColorPicker | mount | 6001 | 6038 | 5000 | |
| TagPicker | mount | 1419 | 1422 | 5000 | |
| Text | mount | 369 | 369 | 5000 | |
| TextField | mount | 939 | 924 | 5000 | |
| ThemeProvider | mount | 820 | 830 | 5000 | |
| ThemeProvider | virtual-rerender | 585 | 586 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1268 | 1241 | 5000 | |
| Toggle | mount | 634 | 609 | 5000 | |
| buttonNative | mount | 200 | 190 | 5000 |
khmakoto
approved these changes
Jun 6, 2023
Collaborator
|
🎉 Handy links: |
Collaborator
|
🎉 Handy links: |
Collaborator
|
🎉 Handy links: |
Collaborator
|
🎉 Handy links: |
Collaborator
|
🎉 Handy links: |
Collaborator
|
🎉 Handy links: |
Collaborator
|
🎉 Handy links: |
Collaborator
|
🎉 Handy links: |
Collaborator
|
🎉 Handy links: |
Collaborator
|
🎉 Handy links: |
Collaborator
|
🎉 Handy links: |
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Jun 13, 2023
* master: applying package updates doc: Remove wrong recommendation from input (microsoft#28168) fix: Outline color now respects OS force colors settings (microsoft#28182) Datepicker onCalendarOpenStateChange prop (microsoft#28136) feat(react-file-type-icons): Add getFileTypeIconAsUrl utility (microsoft#27336) applying package updates [FIX] Updates selection dot and label positioning for ChoiceGroupOption when an Image or Icon is present. (microsoft#28173) chore(react-infobutton): Rename InfoTip to InfoIcon (microsoft#28177) fix(react-datepicker-compat): Make DatePicker Compat stories SSR safe (microsoft#28017) Added `tab` focus mode to the Breadcrumb (microsoft#28046) docs: Add usable documentation (microsoft#28155) applying package updates Fix up rebase code (microsoft#27864) fix: ContextualMenu indexing in sections (microsoft#28127) applying package updates fix: Layer sets focus visible classname for its FocusRectsProvider (microsoft#28157) docs(react-infobutton): Update stories to show better guidance (microsoft#28144) fix(react-avatar): Do not render the image when src prop is undefined (microsoft#28146) feat(react-datepicker-compat): Add null to value prop and handle controlled cases correctly (microsoft#28056)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
Focus outlines would not show up when opening a Modal, Dialog, Panel, etc. in a new Layer, since the layer contents would be under a new
FocusRectsProvider.New Behavior
Layer now checks whether the focus visible classname is present in its own context, then sets it (if applicable) on the new provider it instantiates.
Related Issue(s)