docs: Add usable documentation #28155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates all the documentation examples for Toast so that they are human readable. Also adds docstring to public API
Collaborator
📊 Bundle size report🤖 This report was generated against 1acc2cdf9ab63707eb26d656fca5161680df42c5 |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 1acc2cdf9ab63707eb26d656fca5161680df42c5 (build) |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 7261fe8:
|
layershifter
reviewed
Jun 7, 2023
packages/react-components/react-toast/stories/Toast/CustomTimeout.stories.tsx
Outdated
Show resolved
Hide resolved
layershifter
reviewed
Jun 7, 2023
packages/react-components/react-toast/stories/Toast/Offset.stories.tsx
Outdated
Show resolved
Hide resolved
layershifter
reviewed
Jun 7, 2023
packages/react-components/react-toast/stories/Toast/ToasterLimit.stories.tsx
Outdated
Show resolved
Hide resolved
layershifter
reviewed
Jun 7, 2023
packages/react-components/react-toast/stories/Toast/Offset.stories.tsx
Outdated
Show resolved
Hide resolved
layershifter
reviewed
Jun 7, 2023
packages/react-components/react-toast/stories/Toast/Offset.stories.tsx
Outdated
Show resolved
Hide resolved
layershifter
reviewed
Jun 7, 2023
packages/react-components/react-toast/stories/Toast/DismissToast.stories.tsx
Show resolved
Hide resolved
layershifter
reviewed
Jun 7, 2023
packages/react-components/react-toast/stories/Toast/DismissAll.stories.tsx
Outdated
Show resolved
Hide resolved
layershifter
reviewed
Jun 7, 2023
packages/react-components/react-toast/stories/Toast/DismissAll.stories.tsx
Show resolved
Hide resolved
layershifter
reviewed
Jun 7, 2023
packages/react-components/react-toast/stories/Toast/ToasterLimit.stories.tsx
Show resolved
Hide resolved
Member
|
I guess that something is missing as I don't see a table with props on a component page: 
|
layershifter
approved these changes
Jun 7, 2023
ling1726
force-pushed
the
chore/react-toast/docs
branch
from
511b625 to
b2e7f12
Compare
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Jun 13, 2023
* master: applying package updates doc: Remove wrong recommendation from input (microsoft#28168) fix: Outline color now respects OS force colors settings (microsoft#28182) Datepicker onCalendarOpenStateChange prop (microsoft#28136) feat(react-file-type-icons): Add getFileTypeIconAsUrl utility (microsoft#27336) applying package updates [FIX] Updates selection dot and label positioning for ChoiceGroupOption when an Image or Icon is present. (microsoft#28173) chore(react-infobutton): Rename InfoTip to InfoIcon (microsoft#28177) fix(react-datepicker-compat): Make DatePicker Compat stories SSR safe (microsoft#28017) Added `tab` focus mode to the Breadcrumb (microsoft#28046) docs: Add usable documentation (microsoft#28155) applying package updates Fix up rebase code (microsoft#27864) fix: ContextualMenu indexing in sections (microsoft#28127) applying package updates fix: Layer sets focus visible classname for its FocusRectsProvider (microsoft#28157) docs(react-infobutton): Update stories to show better guidance (microsoft#28144) fix(react-avatar): Do not render the image when src prop is undefined (microsoft#28146) feat(react-datepicker-compat): Add null to value prop and handle controlled cases correctly (microsoft#28056)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates all the documentation examples for Toast so that they are human readable. Also adds docstring to public API