Skip to content

Datepicker onCalendarOpenStateChange prop #28136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jurokapsiar merged 6 commits into from
Jun 12, 2023
Merged

Datepicker onCalendarOpenStateChange prop #28136

jurokapsiar merged 6 commits into from
Jun 12, 2023

Conversation

@jurokapsiar
Copy link
Contributor

@jurokapsiar jurokapsiar commented Jun 5, 2023

Previous Behavior

https://fluentsite.z22.web.core.windows.net/0.66.2/components/datepicker/definition?showCode=false&showRtl=false&showTransparent=false&showVariables=false#types-open

Datepicker only had calendarOpenState prop but the change callback prop was missing

New Behavior

onCalendarOpenStateChange is called when the state is changed internally.

@jurokapsiar jurokapsiar requested a review from a team as a code owner June 5, 2023 04:48
@github-actions github-actions bot added this to the June Project Cycle Q2 2023 milestone Jun 5, 2023
@fabricteam
Copy link
Collaborator

fabricteam commented Jun 5, 2023 •
edited
Loading

📊 Bundle size report

🤖 This report was generated against 711a734d30fab93fd8359e2880329beacd237e2a

@fabricteam
Copy link
Collaborator

fabricteam commented Jun 5, 2023 •
edited
Loading

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
ChatDuplicateMessagesPerf.default 170 153 1.11:1
TextAreaMinimalPerf.default 305 287 1.06:1
ReactionMinimalPerf.default 217 207 1.05:1
AttachmentMinimalPerf.default 86 83 1.04:1
BoxMinimalPerf.default 205 197 1.04:1
RadioGroupMinimalPerf.default 267 257 1.04:1
RefMinimalPerf.default 111 107 1.04:1
TreeMinimalPerf.default 495 477 1.04:1
HeaderSlotsPerf.default 483 468 1.03:1
InputMinimalPerf.default 549 532 1.03:1
ItemLayoutMinimalPerf.default 737 713 1.03:1
LayoutMinimalPerf.default 203 198 1.03:1
ListMinimalPerf.default 322 313 1.03:1
VideoMinimalPerf.default 445 434 1.03:1
AttachmentSlotsPerf.default 660 646 1.02:1
ButtonMinimalPerf.default 90 88 1.02:1
CarouselMinimalPerf.default 266 262 1.02:1
CheckboxMinimalPerf.default 1164 1143 1.02:1
ListCommonPerf.default 409 401 1.02:1
RosterPerf.default 1570 1542 1.02:1
PopupMinimalPerf.default 354 348 1.02:1
AccordionMinimalPerf.default 81 80 1.01:1
AvatarMinimalPerf.default 117 116 1.01:1
ButtonSlotsPerf.default 319 317 1.01:1
DialogMinimalPerf.default 458 453 1.01:1
DividerMinimalPerf.default 205 203 1.01:1
DropdownMinimalPerf.default 1409 1393 1.01:1
EmbedMinimalPerf.default 1759 1748 1.01:1
FlexMinimalPerf.default 155 153 1.01:1
FormMinimalPerf.default 225 223 1.01:1
GridMinimalPerf.default 190 188 1.01:1
ProviderMergeThemesPerf.default 677 668 1.01:1
ToolbarMinimalPerf.default 541 538 1.01:1
TooltipMinimalPerf.default 1276 1265 1.01:1
DatepickerMinimalPerf.default 3624 3608 1:1
HeaderMinimalPerf.default 212 212 1:1
LabelMinimalPerf.default 224 225 1:1
ListNestedPerf.default 315 316 1:1
MenuButtonMinimalPerf.default 953 953 1:1
ProviderMinimalPerf.default 207 207 1:1
SplitButtonMinimalPerf.default 2236 2238 1:1
TableManyItemsPerf.default 1115 1116 1:1
ButtonOverridesMissPerf.default 627 633 0.99:1
DropdownManyItemsPerf.default 393 396 0.99:1
LoaderMinimalPerf.default 190 192 0.99:1
MenuMinimalPerf.default 494 499 0.99:1
CustomToolbarPrototype.default 1444 1453 0.99:1
ListWith60ListItems.default 369 378 0.98:1
SkeletonMinimalPerf.default 193 197 0.98:1
StatusMinimalPerf.default 397 405 0.98:1
TableMinimalPerf.default 236 242 0.98:1
TextMinimalPerf.default 198 202 0.98:1
AnimationMinimalPerf.default 291 301 0.97:1
SliderMinimalPerf.default 684 705 0.97:1
CardMinimalPerf.default 307 320 0.96:1
ImageMinimalPerf.default 216 224 0.96:1
SegmentMinimalPerf.default 192 199 0.96:1
IconMinimalPerf.default 384 399 0.96:1
TreeWith60ListItems.default 87 91 0.96:1
AlertMinimalPerf.default 151 161 0.94:1
ChatWithPopoverPerf.default 189 202 0.94:1
ChatMinimalPerf.default 415 444 0.93:1
PortalMinimalPerf.default 83 90 0.92:1

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 5, 2023 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b6a230b:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

Juraj Kapsiar added 2 commits June 8, 2023 21:21
fabricteam
fabricteam reviewed Jun 11, 2023
View reviewed changes
packages/fluentui/CHANGELOG.md
------------------------------------------------------------------------------->
# Changelog
This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

Copy link
Collaborator

@fabricteam fabricteam Jun 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕵 FluentUI-v0 Open the Visual Regressions report to inspect the 1 screenshots

✅ There was 0 screenshots added, 1 screenshots removed, 1259 screenshots unchanged, 0 screenshots with different dimensions and 0 screenshots with visible difference.

unknown 1 screenshots
Image Name Diff(in Pixels) Image Type
Chat.Chat Example Details Teams High Contrast.chromium.png 0 Removed

@jurokapsiar jurokapsiar merged commit 5c4d358 into microsoft:master Jun 12, 2023
@jurokapsiar jurokapsiar deleted the v0-datepicker-open-state branch June 12, 2023 04:04
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Jun 13, 2023
@marcosmoura
Merge branch 'master' into feat/drawer-motion
d1292a7 
* master:
  applying package updates
  doc: Remove wrong recommendation from input (microsoft#28168)
  fix: Outline color now respects OS force colors settings (microsoft#28182)
  Datepicker onCalendarOpenStateChange prop (microsoft#28136)
  feat(react-file-type-icons): Add getFileTypeIconAsUrl utility (microsoft#27336)
  applying package updates
  [FIX] Updates selection dot and label positioning for ChoiceGroupOption when an Image or Icon is present. (microsoft#28173)
  chore(react-infobutton): Rename InfoTip to InfoIcon (microsoft#28177)
  fix(react-datepicker-compat): Make DatePicker Compat stories SSR safe (microsoft#28017)
  Added `tab` focus mode to the Breadcrumb (microsoft#28046)
  docs: Add usable documentation (microsoft#28155)
  applying package updates
  Fix up rebase code (microsoft#27864)
  fix: ContextualMenu indexing in sections (microsoft#28127)
  applying package updates
  fix: Layer sets focus visible classname for its FocusRectsProvider (microsoft#28157)
  docs(react-infobutton): Update stories to show better guidance (microsoft#28144)
  fix(react-avatar): Do not render the image when src prop is undefined (microsoft#28146)
  feat(react-datepicker-compat): Add null to value prop and handle controlled cases correctly (microsoft#28056)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabricteam fabricteam fabricteam left review comments

+1 more reviewer

@ling1726 ling1726 ling1726 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@micahgodbolt micahgodbolt

Labels

Fluent UI react-northstar

Projects

None yet

Milestone

June Project Cycle Q2 2023

Development

Successfully merging this pull request may close these issues.

5 participants

@jurokapsiar @fabricteam @ling1726 @micahgodbolt @msft-fluent-ui-bot