Skip to content

Virtualizer: ScrollTo hooks & callbacks #27864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Mitch-At-Work merged 1 commit into from
Jun 7, 2023
Merged

Virtualizer: ScrollTo hooks & callbacks #27864

Mitch-At-Work merged 1 commit into from
Jun 7, 2023

Conversation

@Mitch-At-Work
Copy link
Contributor

@Mitch-At-Work Mitch-At-Work commented May 16, 2023

New Behavior

ScrollTo hooks for scrolling animated or instantly to a specific item index
Callback for when a flagged index has been rendered
Optional isScrolling flag available in the child render function for users to render lightweight placeholders

Related Issue(s)

#27217
#27218
#27219

@Mitch-At-Work Mitch-At-Work requested a review from ling1726 May 16, 2023 16:55
@fabricteam
Copy link
Collaborator

fabricteam commented May 16, 2023 •
edited
Loading

Perf Analysis (@fluentui/react-components)

Scenario Render type Master Ticks PR Ticks Iterations Status
FluentProviderWithTheme mount 78 85 10 Possible regression
InfoButton mount 17 16 5000 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 578 580 5000
Button mount 284 298 5000
Field mount 1009 1052 5000
FluentProvider mount 663 666 5000
FluentProviderWithTheme mount 78 85 10 Possible regression
FluentProviderWithTheme virtual-rerender 84 70 10
FluentProviderWithTheme virtual-rerender-with-unmount 87 83 10
InfoButton mount 17 16 5000 Possible regression
MakeStyles mount 860 843 50000
Persona mount 1598 1542 5000
SpinButton mount 1256 1288 5000

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 16, 2023 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4e32934:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented May 16, 2023 •
edited
Loading

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Button, FluentProvider & webLightTheme		 64.935 kB
17.918 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover		 211.151 kB
58.715 kB
react-components
react-components: FluentProvider & webLightTheme		 36.168 kB
11.964 kB
react-portal-compat
PortalCompatProvider		 6.473 kB
2.196 kB
🤖 This report was generated against 1acc2cdf9ab63707eb26d656fca5161680df42c5

@size-auditor
Copy link

size-auditor bot commented May 16, 2023 •
edited
Loading

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 1acc2cdf9ab63707eb26d656fca5161680df42c5 (build)

@Mitch-At-Work Mitch-At-Work marked this pull request as ready for review May 16, 2023 19:03
@Mitch-At-Work Mitch-At-Work requested a review from a team as a code owner May 16, 2023 19:03
AkimaLunar
AkimaLunar approved these changes May 30, 2023
View reviewed changes
Copy link
Member

@AkimaLunar AkimaLunar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really neat way to implement scroll! 🚢

ling1726
ling1726 reviewed May 31, 2023
View reviewed changes
@Mitch-At-Work Mitch-At-Work requested a review from a team as a code owner June 2, 2023 19:49
@Mitch-At-Work Mitch-At-Work force-pushed the user/mifraser/dynamic-virtualizer-hooks branch 2 times, most recently from acf1414 to bd9fa85 Compare June 5, 2023 16:33
@Mitch-At-Work Mitch-At-Work requested a review from ling1726 June 5, 2023 16:34
ling1726
ling1726 approved these changes Jun 6, 2023
View reviewed changes
Copy link
Contributor

@ling1726 ling1726 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the styles file duplication

ling1726
ling1726 approved these changes Jun 6, 2023
View reviewed changes
Copy link
Contributor

@ling1726 ling1726 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the styles file duplication

@Mitch-At-Work Mitch-At-Work force-pushed the user/mifraser/dynamic-virtualizer-hooks branch from d9e9a8a to 388dec5 Compare June 7, 2023 00:01
@fabricteam
Copy link
Collaborator

fabricteam commented Jun 7, 2023

🕵 fluentuiv9 No visual regressions between this PR and main

@Mitch-At-Work Mitch-At-Work force-pushed the user/mifraser/dynamic-virtualizer-hooks branch 3 times, most recently from 3ad2fae to 4e32934 Compare June 7, 2023 18:03
@Mitch-At-Work Mitch-At-Work merged commit ab90189 into microsoft:master Jun 7, 2023
@msft-fluent-ui-bot
Copy link
Collaborator

msft-fluent-ui-bot commented Jun 8, 2023

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

msft-fluent-ui-bot commented Jun 8, 2023

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

msft-fluent-ui-bot commented Jun 8, 2023

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

msft-fluent-ui-bot commented Jun 8, 2023

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

msft-fluent-ui-bot commented Jun 8, 2023

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

msft-fluent-ui-bot commented Jun 8, 2023

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

msft-fluent-ui-bot commented Jun 8, 2023

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

msft-fluent-ui-bot commented Jun 8, 2023

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

msft-fluent-ui-bot commented Jun 8, 2023

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

msft-fluent-ui-bot commented Jun 8, 2023

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Jun 13, 2023
@marcosmoura
Merge branch 'master' into feat/drawer-motion
d1292a7 
* master:
  applying package updates
  doc: Remove wrong recommendation from input (microsoft#28168)
  fix: Outline color now respects OS force colors settings (microsoft#28182)
  Datepicker onCalendarOpenStateChange prop (microsoft#28136)
  feat(react-file-type-icons): Add getFileTypeIconAsUrl utility (microsoft#27336)
  applying package updates
  [FIX] Updates selection dot and label positioning for ChoiceGroupOption when an Image or Icon is present. (microsoft#28173)
  chore(react-infobutton): Rename InfoTip to InfoIcon (microsoft#28177)
  fix(react-datepicker-compat): Make DatePicker Compat stories SSR safe (microsoft#28017)
  Added `tab` focus mode to the Breadcrumb (microsoft#28046)
  docs: Add usable documentation (microsoft#28155)
  applying package updates
  Fix up rebase code (microsoft#27864)
  fix: ContextualMenu indexing in sections (microsoft#28127)
  applying package updates
  fix: Layer sets focus visible classname for its FocusRectsProvider (microsoft#28157)
  docs(react-infobutton): Update stories to show better guidance (microsoft#28144)
  fix(react-avatar): Do not render the image when src prop is undefined (microsoft#28146)
  feat(react-datepicker-compat): Add null to value prop and handle controlled cases correctly (microsoft#28056)
@msft-fluent-ui-bot
Copy link
Collaborator

msft-fluent-ui-bot commented Jun 21, 2023

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

msft-fluent-ui-bot commented Jun 21, 2023

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@Mitch-At-Work Mitch-At-Work mentioned this pull request Aug 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AkimaLunar AkimaLunar AkimaLunar approved these changes

+1 more reviewer

@ling1726 ling1726 ling1726 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@TristanWatanabe TristanWatanabe

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Mitch-At-Work @fabricteam @msft-fluent-ui-bot @AkimaLunar @ling1726 @TristanWatanabe