-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Added tab focus mode to the Breadcrumb
#28046
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added tab focus mode to the Breadcrumb
#28046
Conversation
📊 Bundle size report🤖 This report was generated against 1acc2cdf9ab63707eb26d656fca5161680df42c5 |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 1acc2cdf9ab63707eb26d656fca5161680df42c5 (build) |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 2153f9d:
|
cdb5bf2 to
c525dd1
Compare
tab focus modetab focus mode to the Breadcrumb
|
cypress is not properly setup the fix should be running
{
"extends": "./tsconfig.json",
"compilerOptions": {
"isolatedModules": false,
"types": ["node", "cypress", "cypress-storybook/cypress", "cypress-real-events"],
"lib": ["ES2019", "dom"]
},
"include": ["**/*.cy.ts", "**/*.cy.tsx"]
}
"exclude": [
"./src/testing/**",
"**/*.spec.ts",
"**/*.spec.tsx",
"**/*.test.ts",
"**/*.test.tsx",
"**/*.stories.ts",
"**/*.stories.tsx",
+ "**/*.cy.ts",
+ "**/*.cy.tsx"
],
"references": [
{
"path": "./tsconfig.lib.json"
},
{
"path": "./tsconfig.spec.json"
},
{
"path": "./.storybook/tsconfig.json"
},
+ {
+ "path": "./tsconfig.cy.json"
+ }
] |
Thank you! :) |
aae296a to
65088a7
Compare
packages/react-components/react-breadcrumb/src/components/BreadcrumbLink/useBreadcrumbLink.ts
Outdated
Show resolved
Hide resolved
* master: applying package updates doc: Remove wrong recommendation from input (microsoft#28168) fix: Outline color now respects OS force colors settings (microsoft#28182) Datepicker onCalendarOpenStateChange prop (microsoft#28136) feat(react-file-type-icons): Add getFileTypeIconAsUrl utility (microsoft#27336) applying package updates [FIX] Updates selection dot and label positioning for ChoiceGroupOption when an Image or Icon is present. (microsoft#28173) chore(react-infobutton): Rename InfoTip to InfoIcon (microsoft#28177) fix(react-datepicker-compat): Make DatePicker Compat stories SSR safe (microsoft#28017) Added `tab` focus mode to the Breadcrumb (microsoft#28046) docs: Add usable documentation (microsoft#28155) applying package updates Fix up rebase code (microsoft#27864) fix: ContextualMenu indexing in sections (microsoft#28127) applying package updates fix: Layer sets focus visible classname for its FocusRectsProvider (microsoft#28157) docs(react-infobutton): Update stories to show better guidance (microsoft#28144) fix(react-avatar): Do not render the image when src prop is undefined (microsoft#28146) feat(react-datepicker-compat): Add null to value prop and handle controlled cases correctly (microsoft#28056)
After discussion with the design team and Sarah we have to change focus behavior.
Previous Behavior
arrowtabnavigationNew Behavior
tabnavigation became the default one