Skip to content

Conversation

@ValentinaKozlova
Copy link
Contributor

@ValentinaKozlova ValentinaKozlova commented May 30, 2023

After discussion with the design team and Sarah we have to change focus behavior.

Previous Behavior

  • default mode was arrow
  • no tab navigation

New Behavior

  • tab navigation became the default one
  • added cypress tests

@fabricteam
Copy link
Collaborator

fabricteam commented May 30, 2023

📊 Bundle size report

🤖 This report was generated against 1acc2cdf9ab63707eb26d656fca5161680df42c5

@size-auditor
Copy link

size-auditor bot commented May 30, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 1acc2cdf9ab63707eb26d656fca5161680df42c5 (build)

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 30, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2153f9d:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@ValentinaKozlova ValentinaKozlova force-pushed the feat/breadcrumb-tab-nav branch from cdb5bf2 to c525dd1 Compare May 31, 2023 17:25
@ValentinaKozlova ValentinaKozlova changed the title Added tab focus mode Added tab focus mode to the Breadcrumb May 31, 2023
@ValentinaKozlova ValentinaKozlova marked this pull request as ready for review May 31, 2023 17:31
@ValentinaKozlova ValentinaKozlova requested review from a team as code owners May 31, 2023 17:31
@tudorpopams tudorpopams requested review from Hotell and marcosmoura June 1, 2023 12:11
@Hotell
Copy link
Contributor

Hotell commented Jun 1, 2023

cypress is not properly setup

the fix should be running yarn nx workspace-generators migrate-converged-pkg --name @fluentui/react-breadcrumb, but it contains bug which wont update your project thus you need to do it manually:

  1. create tsconfig.cy.json in your project root
{
  "extends": "./tsconfig.json",
  "compilerOptions": {
    "isolatedModules": false,
    "types": ["node", "cypress", "cypress-storybook/cypress", "cypress-real-events"],
    "lib": ["ES2019", "dom"]
  },
  "include": ["**/*.cy.ts", "**/*.cy.tsx"]
}
  1. update tsconfig.json.lib:
 "exclude": [
    "./src/testing/**",
    "**/*.spec.ts",
    "**/*.spec.tsx",
    "**/*.test.ts",
    "**/*.test.tsx",
    "**/*.stories.ts",
    "**/*.stories.tsx",
+    "**/*.cy.ts",
+    "**/*.cy.tsx"
  ],
  1. update tsconfig.lib:
"references": [
    {
      "path": "./tsconfig.lib.json"
    },
    {
      "path": "./tsconfig.spec.json"
    },
    {
      "path": "./.storybook/tsconfig.json"
    },
+    {
+      "path": "./tsconfig.cy.json"
+    }
  ]

@ValentinaKozlova
Copy link
Contributor Author

cypress is not properly setup

the fix should be running yarn nx workspace-generators migrate-converged-pkg --name @fluentui/react-breadcrumb, but it contains bug which wont update your project thus you need to do it manually:

  1. create tsconfig.cy.json in your project root
{
  "extends": "./tsconfig.json",
  "compilerOptions": {
    "isolatedModules": false,
    "types": ["node", "cypress", "cypress-storybook/cypress", "cypress-real-events"],
    "lib": ["ES2019", "dom"]
  },
  "include": ["**/*.cy.ts", "**/*.cy.tsx"]
}
  1. update tsconfig.json.lib:
 "exclude": [
    "./src/testing/**",
    "**/*.spec.ts",
    "**/*.spec.tsx",
    "**/*.test.ts",
    "**/*.test.tsx",
    "**/*.stories.ts",
    "**/*.stories.tsx",
+    "**/*.cy.ts",
+    "**/*.cy.tsx"
  ],
  1. update tsconfig.lib:
"references": [
    {
      "path": "./tsconfig.lib.json"
    },
    {
      "path": "./tsconfig.spec.json"
    },
    {
      "path": "./.storybook/tsconfig.json"
    },
+    {
+      "path": "./tsconfig.cy.json"
+    }
  ]

Thank you! :)

@ValentinaKozlova ValentinaKozlova force-pushed the feat/breadcrumb-tab-nav branch from aae296a to 65088a7 Compare June 5, 2023 14:21
@ValentinaKozlova ValentinaKozlova requested a review from ling1726 June 7, 2023 10:02
@Hotell Hotell removed their request for review June 8, 2023 14:05
@ValentinaKozlova ValentinaKozlova merged commit 0b0fdb0 into microsoft:master Jun 8, 2023
@ValentinaKozlova ValentinaKozlova deleted the feat/breadcrumb-tab-nav branch June 8, 2023 14:09
@ValentinaKozlova ValentinaKozlova mentioned this pull request May 23, 2023
28 tasks
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Jun 13, 2023
* master:
  applying package updates
  doc: Remove wrong recommendation from input (microsoft#28168)
  fix: Outline color now respects OS force colors settings (microsoft#28182)
  Datepicker onCalendarOpenStateChange prop (microsoft#28136)
  feat(react-file-type-icons): Add getFileTypeIconAsUrl utility (microsoft#27336)
  applying package updates
  [FIX] Updates selection dot and label positioning for ChoiceGroupOption when an Image or Icon is present. (microsoft#28173)
  chore(react-infobutton): Rename InfoTip to InfoIcon (microsoft#28177)
  fix(react-datepicker-compat): Make DatePicker Compat stories SSR safe (microsoft#28017)
  Added `tab` focus mode to the Breadcrumb (microsoft#28046)
  docs: Add usable documentation (microsoft#28155)
  applying package updates
  Fix up rebase code (microsoft#27864)
  fix: ContextualMenu indexing in sections (microsoft#28127)
  applying package updates
  fix: Layer sets focus visible classname for its FocusRectsProvider (microsoft#28157)
  docs(react-infobutton): Update stories to show better guidance (microsoft#28144)
  fix(react-avatar): Do not render the image when src prop is undefined (microsoft#28146)
  feat(react-datepicker-compat): Add null to value prop and handle controlled cases correctly (microsoft#28056)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants