feat: implement motion for Drawer #28133
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: d93cb0b8cb80f56e753ad18c645eeb84a9c10256 (build) |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| FluentProviderWithTheme | mount | 77 | 78 | 10 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 626 | 592 | 5000 | |
| Button | mount | 316 | 307 | 5000 | |
| Field | mount | 1098 | 1129 | 5000 | |
| FluentProvider | mount | 692 | 688 | 5000 | |
| FluentProviderWithTheme | mount | 77 | 78 | 10 | Possible regression |
| FluentProviderWithTheme | virtual-rerender | 69 | 66 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 71 | 74 | 10 | |
| InfoButton | mount | 11 | 11 | 5000 | |
| MakeStyles | mount | 827 | 850 | 50000 | |
| Persona | mount | 1702 | 1683 | 5000 | |
| SpinButton | mount | 1368 | 1318 | 5000 |
* master: Accordion : updated styles for accordion header cursor (microsoft#28850) Additional VR tests Charting Library (microsoft#28777) feat(react-motion): create react-motion-preview package scaffolding (microsoft#28947)
* master: chore: update CODEOWNERS to some components to tag the current owner (microsoft#28949) fix(react-popover): Only apply modal attributes if the PopoverSurface traps focus (microsoft#28613) feat(react-table, react-components): export DataGridContextProvider (microsoft#28955) chore: decrease bundle size & adds fixtures (microsoft#28962) feat(react-utilities): create useAnimationFrame hook (microsoft#28948) fix(react-utilities): `useOnClickOutside` should consider text selection from inside to outside as inside click (microsoft#28765) docs(react-accordion): Added subcomponents to index story (microsoft#28956) applying package updates bugfix: ensure interop between assertSlots and old API (microsoft#28957) chore: rename imports from react-tree to react-components (microsoft#28946) applying package updates fix: Autofill queries the inputElement ownerDocument instead of document (microsoft#27312)
* master: (27 commits) feat: Add documentKeyboardEvent to OnVisibleChangeData when Tooltip is hidden via Escape (microsoft#28951) RFC: Component CSS Transitions/Animations on mount/unmount (microsoft#27328) 8.0 Azure Theme: Details list row focus contrast a11y bug fix (microsoft#28966) chore: update CODEOWNERS to some components to tag the current owner (microsoft#28949) fix(react-popover): Only apply modal attributes if the PopoverSurface traps focus (microsoft#28613) feat(react-table, react-components): export DataGridContextProvider (microsoft#28955) chore: decrease bundle size & adds fixtures (microsoft#28962) feat(react-utilities): create useAnimationFrame hook (microsoft#28948) fix(react-utilities): `useOnClickOutside` should consider text selection from inside to outside as inside click (microsoft#28765) docs(react-accordion): Added subcomponents to index story (microsoft#28956) applying package updates bugfix: ensure interop between assertSlots and old API (microsoft#28957) chore: rename imports from react-tree to react-components (microsoft#28946) applying package updates fix: Autofill queries the inputElement ownerDocument instead of document (microsoft#27312) Accordion : updated styles for accordion header cursor (microsoft#28850) Additional VR tests Charting Library (microsoft#28777) feat(react-motion): create react-motion-preview package scaffolding (microsoft#28947) chore: updates generator to use new slot API (microsoft#28916) chore: bumps version of esbuild-loader to v3.2.0 (microsoft#28878) ...
* feat/use-motion-presence-hook: (34 commits) fix: improve typings and documentation fix: use correct boolean values fix: remove outdated changefile feat: use boolean instead of function fix: add type to improve useMemo fix: remove leftover property docs: add title to example docs: move stories to public site fix: remove unused imports fix: join two related hooks in one file to be easier to test fix: add missing change file feat: make package public fix: upgrade stories to use latest changes to hook feat: create useMotion hook accepting either a boolean or motion state docs: add documentatio for the hook feat: add motion docs to public site fix: mismatch dependencies fix: add missing changefile feat: expose useAnimationFrame hook fix: remove old changefile ...
Collaborator
🕵 fluentuiv8 No visual regressions between this PR and main |
Collaborator
🕵 FluentUIV0 No visual regressions between this PR and main |
fabricteam
reviewed
Aug 23, 2023
| packages/react-components/react-storybook-addon-codesandbox @microsoft/fluentui-react-build | ||
| packages/react-components/babel-preset-storybook-full-source @microsoft/fluentui-react-build | ||
| packages/react-components/react-jsx-runtime @microsoft/teams-prg | ||
| packages/react-components/react-toast @microsoft/teams-prg |
Collaborator
There was a problem hiding this comment.
🕵 fluentuiv9 Open the Visual Regressions report to inspect the affected screenshots
Dialog 46 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Dialog.alert - Dark Mode.chromium.png | 810618 | Changed |
| Dialog.alert.chromium.png | 914105 | Changed |
| Dialog.actions position start - Dark Mode.chromium.png | 810618 | Changed |
| Dialog.actions position start & position end - Dark Mode.chromium.png | 810978 | Changed |
| Dialog.default - Dark Mode.chromium.png | 810618 | Changed |
| Dialog.actions position start & position end - High Contrast.chromium.png | 834227 | Changed |
| Dialog.alert - High Contrast.chromium.png | 833839 | Changed |
| Dialog.actions position start & position end.chromium.png | 913773 | Changed |
| Dialog.Fluid Actions End.chromium.png | 913215 | Changed |
| Dialog.alert - RTL.chromium.png | 914104 | Changed |
| Dialog.actions position start - RTL.chromium.png | 914104 | Changed |
| Dialog.actions position start & position end - RTL.chromium.png | 913772 | Changed |
| Dialog.actions position start.chromium.png | 914105 | Changed |
| Dialog.default - High Contrast.chromium.png | 833839 | Changed |
| Dialog.Fluid Actions Start.chromium.png | 913215 | Changed |
| Dialog.actions position start - High Contrast.chromium.png | 833840 | Changed |
| Dialog.nested.chromium.png | 908008 | Changed |
| Dialog.nested - RTL.chromium.png | 908009 | Changed |
| Dialog.nested - High Contrast.chromium.png | 836118 | Changed |
| Dialog.no actions - High Contrast.chromium.png | 839180 | Changed |
| Dialog.no actions.chromium.png | 907033 | Changed |
| Dialog.no actions - Dark Mode.chromium.png | 820783 | Changed |
| Dialog.default - RTL.chromium.png | 914104 | Changed |
| Dialog.nested - Dark Mode.chromium.png | 814795 | Changed |
| Dialog.default.chromium.png | 914105 | Changed |
| Dialog.no title - High Contrast.chromium.png | 839087 | Changed |
| Dialog.no title & no actions.chromium.png | 900940 | Changed |
| Dialog.no title & no actions - Dark Mode.chromium.png | 828154 | Changed |
| Dialog.no actions - RTL.chromium.png | 907032 | Changed |
| Dialog.no title & no actions - High Contrast.chromium.png | 844429 | Changed |
| Dialog.no title & no actions - RTL.chromium.png | 900939 | Changed |
| Dialog.no title - Dark Mode.chromium.png | 817989 | Changed |
| Dialog.non-modal - Dark Mode.chromium.png | 1467483 | Changed |
| Dialog.no title - RTL.chromium.png | 908011 | Changed |
| Dialog.non-modal - High Contrast.chromium.png | 1492220 | Changed |
| Dialog.title custom action - Dark Mode.chromium.png | 820007 | Changed |
| Dialog.no title.chromium.png | 908012 | Changed |
| Dialog.non-modal - RTL.chromium.png | 1597881 | Changed |
| Dialog.scroll long content.chromium.png | 1053070 | Changed |
| Dialog.scroll long content - Dark Mode.chromium.png | 666310 | Changed |
| Dialog.scroll long content - High Contrast.chromium.png | 705209 | Changed |
| Dialog.title custom action - High Contrast.chromium.png | 838587 | Changed |
| Dialog.non-modal.chromium.png | 1597882 | Changed |
| Dialog.scroll long content - RTL.chromium.png | 1053025 | Changed |
| Dialog.title custom action.chromium.png | 907631 | Changed |
| Dialog.title custom action - RTL.chromium.png | 907631 | Changed |
* master: (24 commits) feat(react-motion): add useMotion hook (microsoft#28699) feat: add closeOnIframeFocus prop to Popover (microsoft#28881) chore: updates .devcontainer to follow new format (microsoft#28990) Line Chart and Area Chart - Component tests (microsoft#28235) applying package updates 28576 small button is using 3px border radius (microsoft#28589) In PeoplePicker, we can now use arrow keys to move cursor around microsoft#28655 (microsoft#28975) chore: Migrate bot config to yml (microsoft#28981) fix(react-card): CardHeader grid layout ignoring line-height of content (microsoft#28968) fix(react-tags-preview): tag with secondary text has no top border under windows high contrast (microsoft#28963) applying package updates feat(Stack): Add deprecated flag to render null when receiving a falsy value (microsoft#28978) feat(react-infobutton): Add inline prop to InfoButton and make it inline by default (microsoft#28605) fix(Dialog): Add displayName for dialog footer and content (microsoft#28939) Revert "Keytips: Align keytipData with visible instance for dupes" (microsoft#28977) Vertical stacked bar chart - Component tests (microsoft#28594) docs: update drawer spec to be inline with changes to component (microsoft#28934) Table/DataGrid: fix visuals for overflow (microsoft#28940) Focus indicator bug in bar charts (microsoft#28414) Pie chart focus spacing (microsoft#28504) ...
…reaChart.base.tsx
…arChart/HorizontalBarChart.base.tsx
…hart/MultiStackedBarChart.base.tsx
…ineChartRTL.test.tsx
…hart/StackedBarChart.base.tsx
* master: chore: Make triage bot add needs triage label to new issues (microsoft#28994) fix(react-tags-preview): use regular icon for dismiss (microsoft#28958)
* master: (32 commits) refactor(react-drawer): change DrawerHeaderTitle slot creation while keeping the same API (microsoft#29042) test(react-drawer): add render tests for drawer subcomponents (microsoft#29043) Grouped vertical bar chart - Component tests (microsoft#29031) docs: add Fluent UI Insights EP06 to README (microsoft#29051) chore: use swc-plugin-de-indent-template-literal for consoles (microsoft#29040) chore: adds swc-plugin-de-indent-template-literal (microsoft#29037) feat(react-jsx-runtime): v9 packages to use importSource (microsoft#28959) chore: update swc build dependencies (microsoft#28989) fix(react-tags-preview): add hover/pressed style for windows high contrast (microsoft#29035) chore(react-tags-preview): use InteractionTag for TagGroup's stories (microsoft#29024) chore(react-tags-preview): use makeResetStyles for base styles (microsoft#29022) chore: fix codesandbox export for preview component by making @fluentui/react-components required dependency (microsoft#29016) applying package updates feat(react-motion): create useReducedMotion and apply to useMotion to skip animations (microsoft#29014) ReAdd: Keytips: Align keytipData with visible instance for dupes (microsoft#28992) feat(react-drawer): add motion to Drawer (microsoft#28999) fix(react-utilities): avoid calling requestAnimationFrame when in SSR (microsoft#29015) fix(ssr-tests-v9): use correct path for ssr-tests-v9 stories (microsoft#29025) chore: updates devcontainer to use v16-bookworm image (microsoft#28997) feat(docsite): add Application Insights telemetry (microsoft#28709) ...
…rChart.stories.tsx
…wer/DrawerDefault.stories.tsx
…wer/DrawerInline.stories.tsx
…/hooks/useIsMotion.ts
…ries/useMotion/index.stories.tsx
* master: (146 commits) remove a11y test ux from theme designer (microsoft#29379) feat: preview release (microsoft#29377) Fixed divider in the tooltip (microsoft#29357) fix (microsoft#29376) docs: Initial documentation pass (microsoft#29372) feat: Integrate Announce context (microsoft#29362) chore(react-tags): stable release (microsoft#29355) chore: delegate focus outline to layout components (microsoft#29293) Vertical bar chart line bug (microsoft#29299) applying package updates Adding axis title examples for line, area, vertical bar and vertical stacked bar charts (microsoft#29254) A11y: Pagination: Add tooltip for all icon buttons (microsoft#29155) A11y: Fix aria attribute for page number and add correct role (microsoft#29349) feat: Implement motion for MessageBar (microsoft#29339) feat: creates getIntrinsicElementProps to replace getNativeElementProps on slots creation (microsoft#29310) chore: replace makeStyles with makeResetStyles (microsoft#29338) applying package updates ci(github/policies): remove bot rules that created and added `Component/Package $1`: labels on PRs (microsoft#29301) fix: handle multiple classes in PortalCompatProvider (microsoft#29351) applying package updates ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is only to track the work, feedback and experimentation about implementing motion for Drawer.
The full PR will be created later.