fix(Dialog): Add displayName for dialog footer and content #28939

ymyqwe · 2023-08-22T09:46:33Z

Add displayName to Dialog components to align with other components

fabricteam · 2023-08-22T09:58:30Z

📊 Bundle size report

_{🤖 This report was generated against 7e494ac4414be5eac624a69bfecd5a84c26227e4}

codesandbox-ci · 2023-08-22T09:59:39Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 30fd864:

Sandbox	Source
@fluentui/react 8 starter	Configuration
@fluentui/react-components 9 starter	Configuration

size-auditor · 2023-08-22T10:04:37Z

Asset size changes

Project	Bundle	Baseline Size	New Size	Difference
office-ui-fabric-react	fluentui-react-Dialog	202.521 kB	202.59 kB	69 bytes

Over Tolerance (1024 B) Over Baseline Below Baseline New Removed 1 kB = 1000 B

Baseline commit: 7e494ac4414be5eac624a69bfecd5a84c26227e4 (build)

fabricteam · 2023-08-22T10:12:21Z

Perf Analysis (`@fluentui/react`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
BaseButton	mount	629	620	5000
Breadcrumb	mount	1707	1705	1000
Checkbox	mount	1711	1743	5000
CheckboxBase	mount	1488	1514	5000
ChoiceGroup	mount	2966	3000	5000
ComboBox	mount	647	660	1000
CommandBar	mount	6317	6286	1000
ContextualMenu	mount	14122	13770	1000
DefaultButton	mount	774	772	5000
DetailsRow	mount	2176	2154	5000
DetailsRowFast	mount	2172	2164	5000
DetailsRowNoStyles	mount	1982	1997	5000
Dialog	mount	2646	2781	1000
DocumentCardTitle	mount	225	227	1000
Dropdown	mount	2006	1990	5000
FocusTrapZone	mount	1129	1146	5000
FocusZone	mount	1077	1060	5000
GroupedList	mount	41583	42025	2
GroupedList	virtual-rerender	20027	20011	2
GroupedList	virtual-rerender-with-unmount	50750	50819	2
GroupedListV2	mount	228	225	2
GroupedListV2	virtual-rerender	202	215	2
GroupedListV2	virtual-rerender-with-unmount	231	227	2
IconButton	mount	1084	1089	5000
Label	mount	346	354	5000
Layer	mount	2755	2752	5000
Link	mount	402	393	5000
MenuButton	mount	951	968	5000
MessageBar	mount	21755	21919	5000
Nav	mount	1939	1924	1000
OverflowSet	mount	785	803	5000
Panel	mount	1749	1831	1000
Persona	mount	750	749	1000
Pivot	mount	865	891	1000
PrimaryButton	mount	856	855	5000
Rating	mount	4598	4566	5000
SearchBox	mount	944	924	5000
Shimmer	mount	1909	1920	5000
Slider	mount	1336	1337	5000
SpinButton	mount	2893	2910	5000
Spinner	mount	392	393	5000
SplitButton	mount	1868	1834	5000
Stack	mount	422	421	5000
StackWithIntrinsicChildren	mount	871	857	5000
StackWithTextChildren	mount	2645	2647	5000
SwatchColorPicker	mount	6090	6142	5000
TagPicker	mount	1453	1465	5000
Text	mount	392	376	5000
TextField	mount	939	980	5000
ThemeProvider	mount	836	845	5000
ThemeProvider	virtual-rerender	595	591	5000
ThemeProvider	virtual-rerender-with-unmount	1305	1260	5000
Toggle	mount	607	612	5000
buttonNative	mount	203	196	5000

sopranopillow · 2023-08-22T22:10:09Z

@ymyqwe, Looks like you're missing the change files, you need to run yarn buildto @fluentui/react and then yarn change

ymyqwe · 2023-08-23T02:46:43Z

@ymyqwe, Looks like you're missing the change files, you need to run yarn buildto @fluentui/react and then yarn change

@sopranopillow change files added. Which version of @fluentui/react will this change be in?

change/@fluentui-react-e393acc7-f1bd-4632-9c6d-359924839807.json

sopranopillow · 2023-08-23T15:23:49Z

@ymyqwe, Looks like you're missing the change files, you need to run yarn buildto @fluentui/react and then yarn change

@sopranopillow change files added. Which version of @fluentui/react will this change be in?

@ymyqwe, most likely in 8.110.16 or 8.111.0 depending on the type of changes that are waiting for release.

Co-authored-by: Esteban Munoz Facusse <esteban.230@hotmail.com>

fabricteam · 2023-08-24T15:53:45Z

🕵 fluentuiv8 No visual regressions between this PR and main

TristanWatanabe · 2023-08-24T20:29:52Z

/azp run Fluent UI React - PR and CI

azure-pipelines · 2023-08-24T20:30:01Z

Azure Pipelines successfully started running 1 pipeline(s).

* master: (23 commits) feat: add closeOnIframeFocus prop to Popover (microsoft#28881) chore: updates .devcontainer to follow new format (microsoft#28990) Line Chart and Area Chart - Component tests (microsoft#28235) applying package updates 28576 small button is using 3px border radius (microsoft#28589) In PeoplePicker, we can now use arrow keys to move cursor around microsoft#28655 (microsoft#28975) chore: Migrate bot config to yml (microsoft#28981) fix(react-card): CardHeader grid layout ignoring line-height of content (microsoft#28968) fix(react-tags-preview): tag with secondary text has no top border under windows high contrast (microsoft#28963) applying package updates feat(Stack): Add deprecated flag to render null when receiving a falsy value (microsoft#28978) feat(react-infobutton): Add inline prop to InfoButton and make it inline by default (microsoft#28605) fix(Dialog): Add displayName for dialog footer and content (microsoft#28939) Revert "Keytips: Align keytipData with visible instance for dupes" (microsoft#28977) Vertical stacked bar chart - Component tests (microsoft#28594) docs: update drawer spec to be inline with changes to component (microsoft#28934) Table/DataGrid: fix visuals for overflow (microsoft#28940) Focus indicator bug in bar charts (microsoft#28414) Pie chart focus spacing (microsoft#28504) applying package updates ...

* master: (24 commits) feat(react-motion): add useMotion hook (microsoft#28699) feat: add closeOnIframeFocus prop to Popover (microsoft#28881) chore: updates .devcontainer to follow new format (microsoft#28990) Line Chart and Area Chart - Component tests (microsoft#28235) applying package updates 28576 small button is using 3px border radius (microsoft#28589) In PeoplePicker, we can now use arrow keys to move cursor around microsoft#28655 (microsoft#28975) chore: Migrate bot config to yml (microsoft#28981) fix(react-card): CardHeader grid layout ignoring line-height of content (microsoft#28968) fix(react-tags-preview): tag with secondary text has no top border under windows high contrast (microsoft#28963) applying package updates feat(Stack): Add deprecated flag to render null when receiving a falsy value (microsoft#28978) feat(react-infobutton): Add inline prop to InfoButton and make it inline by default (microsoft#28605) fix(Dialog): Add displayName for dialog footer and content (microsoft#28939) Revert "Keytips: Align keytipData with visible instance for dupes" (microsoft#28977) Vertical stacked bar chart - Component tests (microsoft#28594) docs: update drawer spec to be inline with changes to component (microsoft#28934) Table/DataGrid: fix visuals for overflow (microsoft#28940) Focus indicator bug in bar charts (microsoft#28414) Pie chart focus spacing (microsoft#28504) ...

* master: (26 commits) chore: Make triage bot add needs triage label to new issues (microsoft#28994) fix(react-tags-preview): use regular icon for dismiss (microsoft#28958) feat(react-motion): add useMotion hook (microsoft#28699) feat: add closeOnIframeFocus prop to Popover (microsoft#28881) chore: updates .devcontainer to follow new format (microsoft#28990) Line Chart and Area Chart - Component tests (microsoft#28235) applying package updates 28576 small button is using 3px border radius (microsoft#28589) In PeoplePicker, we can now use arrow keys to move cursor around microsoft#28655 (microsoft#28975) chore: Migrate bot config to yml (microsoft#28981) fix(react-card): CardHeader grid layout ignoring line-height of content (microsoft#28968) fix(react-tags-preview): tag with secondary text has no top border under windows high contrast (microsoft#28963) applying package updates feat(Stack): Add deprecated flag to render null when receiving a falsy value (microsoft#28978) feat(react-infobutton): Add inline prop to InfoButton and make it inline by default (microsoft#28605) fix(Dialog): Add displayName for dialog footer and content (microsoft#28939) Revert "Keytips: Align keytipData with visible instance for dupes" (microsoft#28977) Vertical stacked bar chart - Component tests (microsoft#28594) docs: update drawer spec to be inline with changes to component (microsoft#28934) Table/DataGrid: fix visuals for overflow (microsoft#28940) ...

add displayName for dialog footer and content

9bb0f80

ymyqwe requested review from a team as code owners August 22, 2023 09:46

yarn change

ecd72ab

sopranopillow reviewed Aug 23, 2023

View reviewed changes

change/@fluentui-react-e393acc7-f1bd-4632-9c6d-359924839807.json Outdated Show resolved Hide resolved

sopranopillow changed the title ~~add displayName for dialog footer and content~~ fix(Dialog): Add displayName for dialog footer and content Aug 23, 2023

Update change/@fluentui-react-e393acc7-f1bd-4632-9c6d-359924839807.json

86991e5

Co-authored-by: Esteban Munoz Facusse <esteban.230@hotmail.com>

sopranopillow enabled auto-merge (squash) August 24, 2023 15:35

Merge branch 'master' into add_dialog_name

30fd864

sopranopillow closed this Aug 24, 2023

auto-merge was automatically disabled August 24, 2023 16:15
Pull request was closed

sopranopillow reopened this Aug 24, 2023

sopranopillow approved these changes Aug 24, 2023

View reviewed changes

sopranopillow merged commit 0dfca34 into microsoft:master Aug 24, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(Dialog): Add displayName for dialog footer and content #28939

fix(Dialog): Add displayName for dialog footer and content #28939

Uh oh!

ymyqwe commented Aug 22, 2023

Uh oh!

fabricteam commented Aug 22, 2023 •

edited

Loading

Uh oh!

codesandbox-ci bot commented Aug 22, 2023 •

edited

Loading

Uh oh!

size-auditor bot commented Aug 22, 2023 •

edited

Loading

Uh oh!

fabricteam commented Aug 22, 2023 •

edited

Loading

Uh oh!

sopranopillow commented Aug 22, 2023

Uh oh!

ymyqwe commented Aug 23, 2023 •

edited

Loading

Uh oh!

Uh oh!

sopranopillow commented Aug 23, 2023

Uh oh!

fabricteam commented Aug 24, 2023 •

edited

Loading

Uh oh!

TristanWatanabe commented Aug 24, 2023

Uh oh!

azure-pipelines bot commented Aug 24, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

fix(Dialog): Add displayName for dialog footer and content #28939

fix(Dialog): Add displayName for dialog footer and content #28939

Uh oh!

Conversation

ymyqwe commented Aug 22, 2023

Uh oh!

fabricteam commented Aug 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Bundle size report

Uh oh!

codesandbox-ci bot commented Aug 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

size-auditor bot commented Aug 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Asset size changes

Uh oh!

fabricteam commented Aug 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react)

Uh oh!

sopranopillow commented Aug 22, 2023

Uh oh!

ymyqwe commented Aug 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

sopranopillow commented Aug 23, 2023

Uh oh!

fabricteam commented Aug 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🕵 fluentuiv8 No visual regressions between this PR and main

Uh oh!

TristanWatanabe commented Aug 24, 2023

Uh oh!

azure-pipelines bot commented Aug 24, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

fabricteam commented Aug 22, 2023 •

edited

Loading

codesandbox-ci bot commented Aug 22, 2023 •

edited

Loading

size-auditor bot commented Aug 22, 2023 •

edited

Loading

fabricteam commented Aug 22, 2023 •

edited

Loading

Perf Analysis (`@fluentui/react`)

ymyqwe commented Aug 23, 2023 •

edited

Loading

fabricteam commented Aug 24, 2023 •

edited

Loading