Skip to content

Conversation

@YuanboXue-Amber
Copy link
Contributor

@YuanboXue-Amber YuanboXue-Amber commented Oct 3, 2023

see title.

After fix:
image

@YuanboXue-Amber YuanboXue-Amber marked this pull request as ready for review October 3, 2023 14:25
@YuanboXue-Amber YuanboXue-Amber requested review from a team as code owners October 3, 2023 14:25
@YuanboXue-Amber YuanboXue-Amber changed the title fix chore: move tag stories under components Oct 3, 2023
@YuanboXue-Amber YuanboXue-Amber enabled auto-merge (squash) October 3, 2023 14:27
@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 644 626 5000
Button mount 323 312 5000
Field mount 1127 1102 5000
FluentProvider mount 702 683 5000
FluentProviderWithTheme mount 86 87 10
FluentProviderWithTheme virtual-rerender 70 69 10
FluentProviderWithTheme virtual-rerender-with-unmount 70 70 10
InfoButton mount 15 14 5000
MakeStyles mount 846 849 50000
Persona mount 1738 1706 5000
SpinButton mount 1350 1385 5000

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 3, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4b2a1fb:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Button, FluentProvider & webLightTheme
69.227 kB
19.584 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
206.783 kB
59.085 kB
react-components
react-components: FluentProvider & webLightTheme
40.793 kB
13.521 kB
react-portal-compat
PortalCompatProvider
6.503 kB
2.22 kB
react-tags
InteractionTag
14.275 kB
5.717 kB
react-tags
Tag
28.998 kB
9.061 kB
react-tags
TagGroup
72.507 kB
21.605 kB
🤖 This report was generated against 5ddea119dcc0dbace2484f78f1e933424b46ba8c

@size-auditor
Copy link

size-auditor bot commented Oct 3, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 5ddea119dcc0dbace2484f78f1e933424b46ba8c (build)

@fabricteam
Copy link
Collaborator

🕵 fluentuiv9 No visual regressions between this PR and main

@YuanboXue-Amber YuanboXue-Amber merged commit f4b9077 into microsoft:master Oct 3, 2023
@YuanboXue-Amber YuanboXue-Amber deleted the story branch October 3, 2023 15:47
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Oct 4, 2023
* master: (146 commits)
  remove a11y test ux from theme designer (microsoft#29379)
  feat: preview release (microsoft#29377)
  Fixed divider in the tooltip (microsoft#29357)
  fix (microsoft#29376)
  docs: Initial documentation pass (microsoft#29372)
  feat: Integrate Announce context (microsoft#29362)
  chore(react-tags): stable release (microsoft#29355)
  chore: delegate focus outline to layout components (microsoft#29293)
  Vertical bar chart line bug (microsoft#29299)
  applying package updates
  Adding axis title examples for line, area, vertical bar and vertical stacked bar charts (microsoft#29254)
  A11y: Pagination: Add tooltip for all icon buttons  (microsoft#29155)
  A11y: Fix aria attribute for page number and add correct role (microsoft#29349)
  feat: Implement motion for MessageBar (microsoft#29339)
  feat: creates getIntrinsicElementProps to replace getNativeElementProps on slots creation (microsoft#29310)
  chore: replace makeStyles with makeResetStyles (microsoft#29338)
  applying package updates
  ci(github/policies): remove bot rules that created and added `Component/Package $1`: labels on PRs (microsoft#29301)
  fix: handle multiple classes in PortalCompatProvider (microsoft#29351)
  applying package updates
  ...
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Oct 4, 2023
* master: (49 commits)
  remove a11y test ux from theme designer (microsoft#29379)
  feat: preview release (microsoft#29377)
  Fixed divider in the tooltip (microsoft#29357)
  fix (microsoft#29376)
  docs: Initial documentation pass (microsoft#29372)
  feat: Integrate Announce context (microsoft#29362)
  chore(react-tags): stable release (microsoft#29355)
  chore: delegate focus outline to layout components (microsoft#29293)
  Vertical bar chart line bug (microsoft#29299)
  applying package updates
  Adding axis title examples for line, area, vertical bar and vertical stacked bar charts (microsoft#29254)
  A11y: Pagination: Add tooltip for all icon buttons  (microsoft#29155)
  A11y: Fix aria attribute for page number and add correct role (microsoft#29349)
  feat: Implement motion for MessageBar (microsoft#29339)
  feat: creates getIntrinsicElementProps to replace getNativeElementProps on slots creation (microsoft#29310)
  chore: replace makeStyles with makeResetStyles (microsoft#29338)
  applying package updates
  ci(github/policies): remove bot rules that created and added `Component/Package $1`: labels on PRs (microsoft#29301)
  fix: handle multiple classes in PortalCompatProvider (microsoft#29351)
  applying package updates
  ...
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Oct 4, 2023
* master: (35 commits)
  bugfix(react-dialog): removes context hooks invocations from styles hook (microsoft#29396)
  chore(react-dialog): exports DialogSurface context types and hooks (microsoft#29397)
  Minimum height feature for bar chart (microsoft#29359)
  (feat) Breadcrumb - register items via context (microsoft#29393)
  fix: Consider all parents as scroll parents (microsoft#29378)
  Changes to enable charting on fluent docsite (microsoft#29210)
  bugfix: ensure TreeItem emits events properly (microsoft#29390)
  chore(deps): bump get-func-name from 2.0.0 to 2.0.2 (microsoft#29320)
  chore: migrate from getNativeElementProps to getIntrinsicElementProps (microsoft#29387)
  applying package updates
  applying package updates
  fix: Icon in disabled Button shouldn't change color on hover or pressed (microsoft#29342)
  Squish changes for rebase (microsoft#28705)
  fix: GroupedListV2 scrollToIndex now works correctly (microsoft#29332)
  Fix 27482: ProgressBar has an optional state variable  (microsoft#29366)
  remove a11y test ux from theme designer (microsoft#29379)
  feat: preview release (microsoft#29377)
  Fixed divider in the tooltip (microsoft#29357)
  fix (microsoft#29376)
  docs: Initial documentation pass (microsoft#29372)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants