Skip to content

chore: adds swc-plugin-de-indent-template-literal #29037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bsunderhus merged 1 commit into from
Aug 31, 2023
Merged

chore: adds swc-plugin-de-indent-template-literal #29037

bsunderhus merged 1 commit into from
Aug 31, 2023

Conversation

@bsunderhus
Copy link
Contributor

@bsunderhus bsunderhus commented Aug 31, 2023 •
edited
Loading

Previous Behavior

New Behavior

  1. adds dependency to swc-plugin-de-indent-template-literal to strip indentation from template literals on build time
  2. adds .swc cache folder to .gitignore

Related Issue(s)

  • Fixes #

@bsunderhus bsunderhus self-assigned this Aug 31, 2023
@github-actions github-actions bot added this to the August Project Cycle Q4 2023 milestone Aug 31, 2023
@bsunderhus bsunderhus marked this pull request as ready for review August 31, 2023 13:17
@bsunderhus bsunderhus requested a review from a team as a code owner August 31, 2023 13:17
@fabricteam
Copy link
Collaborator

fabricteam commented Aug 31, 2023

Perf Analysis (@fluentui/react-components)

Scenario Render type Master Ticks PR Ticks Iterations Status
FluentProviderWithTheme virtual-rerender-with-unmount 76 74 10 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 611 599 5000
Button mount 303 331 5000
Field mount 1094 1073 5000
FluentProvider mount 708 684 5000
FluentProviderWithTheme mount 86 90 10
FluentProviderWithTheme virtual-rerender 81 71 10
FluentProviderWithTheme virtual-rerender-with-unmount 76 74 10 Possible regression
InfoButton mount 16 11 5000
MakeStyles mount 865 851 50000
Persona mount 1711 1683 5000
SpinButton mount 1349 1370 5000

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 31, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 676571c:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 31, 2023

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AttachmentMinimalPerf.default 89 77 1.16:1
TreeWith60ListItems.default 92 80 1.15:1
AvatarMinimalPerf.default 113 101 1.12:1
ChatWithPopoverPerf.default 207 185 1.12:1
IconMinimalPerf.default 392 353 1.11:1
SkeletonMinimalPerf.default 206 190 1.08:1
RefMinimalPerf.default 111 104 1.07:1
AttachmentSlotsPerf.default 656 619 1.06:1
ButtonMinimalPerf.default 93 88 1.06:1
GridMinimalPerf.default 196 185 1.06:1
ImageMinimalPerf.default 230 216 1.06:1
LayoutMinimalPerf.default 202 191 1.06:1
TextMinimalPerf.default 197 186 1.06:1
VideoMinimalPerf.default 433 409 1.06:1
AnimationMinimalPerf.default 301 288 1.05:1
CarouselMinimalPerf.default 263 250 1.05:1
DividerMinimalPerf.default 207 197 1.05:1
ButtonOverridesMissPerf.default 649 626 1.04:1
ChatMinimalPerf.default 434 418 1.04:1
LabelMinimalPerf.default 224 215 1.04:1
SegmentMinimalPerf.default 196 189 1.04:1
TextAreaMinimalPerf.default 278 268 1.04:1
FlexMinimalPerf.default 162 157 1.03:1
ItemLayoutMinimalPerf.default 715 697 1.03:1
ListWith60ListItems.default 372 360 1.03:1
ProviderMergeThemesPerf.default 649 632 1.03:1
ProviderMinimalPerf.default 202 196 1.03:1
SplitButtonMinimalPerf.default 2260 2187 1.03:1
BoxMinimalPerf.default 194 190 1.02:1
FormMinimalPerf.default 213 209 1.02:1
InputMinimalPerf.default 539 527 1.02:1
ToolbarMinimalPerf.default 532 520 1.02:1
TreeMinimalPerf.default 481 470 1.02:1
AlertMinimalPerf.default 156 154 1.01:1
DropdownManyItemsPerf.default 385 383 1.01:1
EmbedMinimalPerf.default 1866 1843 1.01:1
MenuButtonMinimalPerf.default 952 942 1.01:1
RadioGroupMinimalPerf.default 258 256 1.01:1
CustomToolbarPrototype.default 1464 1452 1.01:1
DialogMinimalPerf.default 436 438 1:1
DropdownMinimalPerf.default 1437 1440 1:1
ListCommonPerf.default 390 390 1:1
ListMinimalPerf.default 301 301 1:1
RosterPerf.default 1542 1541 1:1
PortalMinimalPerf.default 84 84 1:1
SliderMinimalPerf.default 747 748 1:1
TableManyItemsPerf.default 1106 1109 1:1
TableMinimalPerf.default 229 228 1:1
DatepickerMinimalPerf.default 3636 3669 0.99:1
HeaderMinimalPerf.default 203 205 0.99:1
LoaderMinimalPerf.default 187 188 0.99:1
MenuMinimalPerf.default 501 506 0.99:1
TooltipMinimalPerf.default 1254 1261 0.99:1
ButtonSlotsPerf.default 311 316 0.98:1
CardMinimalPerf.default 300 306 0.98:1
ChatDuplicateMessagesPerf.default 142 145 0.98:1
CheckboxMinimalPerf.default 1121 1149 0.98:1
PopupMinimalPerf.default 347 355 0.98:1
ReactionMinimalPerf.default 203 210 0.97:1
ListNestedPerf.default 313 327 0.96:1
HeaderSlotsPerf.default 438 459 0.95:1
StatusMinimalPerf.default 386 406 0.95:1
AccordionMinimalPerf.default 69 74 0.93:1

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 31, 2023

🕵 fluentuiv8 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 31, 2023

🕵 FluentUIV0 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 31, 2023

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
global-context
createContext		 510 B
330 B
global-context
createContextSelector		 537 B
342 B
priority-overflow
createOverflowManager		 4.162 kB
1.735 kB
react-accordion
Accordion (including children components)		 88.934 kB
26.969 kB
react-alert
Alert		 82.011 kB
22.042 kB
react-avatar
Avatar		 47.206 kB
14.562 kB
react-avatar
AvatarGroup		 16.186 kB
6.457 kB
react-avatar
AvatarGroupItem		 61.985 kB
18.974 kB
react-badge
Badge		 23.253 kB
7.288 kB
react-badge
CounterBadge		 24.154 kB
7.589 kB
react-badge
PresenceBadge		 22.21 kB
7.9 kB
react-button
Button		 37.127 kB
9.727 kB
react-button
CompoundButton		 44.476 kB
11.225 kB
react-button
MenuButton		 41.536 kB
10.992 kB
react-button
SplitButton		 49.571 kB
12.548 kB
react-button
ToggleButton		 54.215 kB
11.634 kB
react-card
Card - All		 88.694 kB
25.317 kB
react-card
Card		 83.495 kB
23.797 kB
react-card
CardFooter		 9.408 kB
3.96 kB
react-card
CardHeader		 11.701 kB
4.748 kB
react-card
CardPreview		 10.367 kB
4.351 kB
react-checkbox
Checkbox		 33.072 kB
10.727 kB
react-combobox
Combobox (including child components)		 87.933 kB
28.539 kB
react-combobox
Dropdown (including child components)		 86.278 kB
28.169 kB
react-components
react-components: Button, FluentProvider & webLightTheme		 66.907 kB
18.548 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover		 205.508 kB
58.347 kB
react-components
react-components: FluentProvider & webLightTheme		 38.103 kB
12.469 kB
react-datepicker-compat
DatePicker Compat		 208.62 kB
57.77 kB
react-dialog
Dialog (including children components)		 87.504 kB
26.478 kB
react-divider
Divider		 17.168 kB
6.327 kB
react-field
Field		 18.466 kB
7.046 kB
react-image
Image		 12.099 kB
4.808 kB
react-infobutton
InfoButton		 126.751 kB
39.688 kB
react-infobutton
InfoLabel		 130.464 kB
40.865 kB
react-input
Input		 23.414 kB
7.759 kB
react-jsx-runtime
Classic Pragma		 1.072 kB
544 B
react-jsx-runtime
JSX Dev Runtime		 2.775 kB
1.29 kB
react-jsx-runtime
JSX Runtime		 3.293 kB
1.529 kB
react-label
Label		 10.493 kB
4.334 kB
react-link
Link		 13.37 kB
5.445 kB
react-menu
Menu (including children components)		 136.96 kB
41.935 kB
react-menu
Menu (including selectable components)		 139.696 kB
42.47 kB
react-overflow
hooks only		 12.594 kB
4.702 kB
react-persona
Persona		 54.101 kB
16.433 kB
react-popover
Popover		 116.022 kB
36.301 kB
react-portal
Portal		 12.362 kB
4.543 kB
react-portal-compat
PortalCompatProvider		 6.541 kB
2.227 kB
react-positioning
usePositioning		 25.245 kB
9.141 kB
react-progress
ProgressBar		 13.872 kB
5.539 kB
react-provider
FluentProvider		 18.648 kB
6.899 kB
react-radio
Radio		 26.784 kB
8.642 kB
react-radio
RadioGroup		 11.814 kB
4.911 kB
react-select
Select		 24.776 kB
8.731 kB
react-slider
Slider		 34.311 kB
11.102 kB
react-spinbutton
SpinButton		 32.992 kB
10.31 kB
react-spinner
Spinner		 19.748 kB
7.055 kB
react-switch
Switch		 29.343 kB
9.299 kB
react-table
DataGrid		 154.174 kB
42.648 kB
react-table
Table (Primitives only)		 39.939 kB
12.198 kB
react-table
Table as DataGrid		 126.91 kB
33.753 kB
react-table
Table (Selection only)		 72.188 kB
19.062 kB
react-table
Table (Sort only)		 70.819 kB
18.665 kB
react-tags-preview
InteractionTag		 11.31 kB
4.567 kB
react-tags-preview
Tag		 27.061 kB
8.519 kB
react-tags-preview
TagGroup		 69.959 kB
20.568 kB
react-text
Text - Default		 13.113 kB
5.151 kB
react-text
Text - Wrappers		 16.285 kB
5.477 kB
react-textarea
Textarea		 27.479 kB
9.12 kB
react-theme
Single theme token import		 69 B
89 B
react-theme
Teams: all themes		 34.611 kB
7.295 kB
react-theme
Teams: Light theme		 19.282 kB
5.486 kB
react-toast
Toast (including Toaster)		 88.365 kB
26.188 kB
react-tooltip
Tooltip		 48.593 kB
17.017 kB
react-utilities
SSRProvider		 180 B
159 B
🤖 This report was generated against b93c2ac22355b6cb6f33dd509c6cd9c21f4fffc8

@size-auditor
Copy link

size-auditor bot commented Aug 31, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: b93c2ac22355b6cb6f33dd509c6cd9c21f4fffc8 (build)

@bsunderhus bsunderhus enabled auto-merge (squash) August 31, 2023 13:39
@fabricteam
Copy link
Collaborator

fabricteam commented Aug 31, 2023

🕵 fluentuiv9 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 31, 2023

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 632 626 5000
Breadcrumb mount 1665 1652 1000
Checkbox mount 1694 1711 5000
CheckboxBase mount 1492 1497 5000
ChoiceGroup mount 2916 2973 5000
ComboBox mount 647 662 1000
CommandBar mount 6163 6088 1000
ContextualMenu mount 12311 12574 1000
DefaultButton mount 751 753 5000
DetailsRow mount 2197 2162 5000
DetailsRowFast mount 2193 2155 5000
DetailsRowNoStyles mount 2007 2002 5000
Dialog mount 2783 2609 1000
DocumentCardTitle mount 230 228 1000
Dropdown mount 1964 2002 5000
FocusTrapZone mount 1129 1108 5000
FocusZone mount 1085 1045 5000
GroupedList mount 41535 41767 2
GroupedList virtual-rerender 19869 19761 2
GroupedList virtual-rerender-with-unmount 50278 50579 2
GroupedListV2 mount 219 221 2
GroupedListV2 virtual-rerender 218 211 2
GroupedListV2 virtual-rerender-with-unmount 228 222 2
IconButton mount 1076 1080 5000
Label mount 334 326 5000
Layer mount 2686 2763 5000
Link mount 387 394 5000
MenuButton mount 926 938 5000
MessageBar mount 21231 21227 5000
Nav mount 1963 1967 1000
OverflowSet mount 769 784 5000
Panel mount 2057 1779 1000
Persona mount 742 731 1000
Pivot mount 874 856 1000
PrimaryButton mount 837 840 5000
Rating mount 4577 4585 5000
SearchBox mount 939 901 5000
Shimmer mount 1887 1847 5000
Slider mount 1315 1326 5000
SpinButton mount 2901 2825 5000
Spinner mount 374 391 5000
SplitButton mount 1880 1820 5000
Stack mount 404 401 5000
StackWithIntrinsicChildren mount 857 843 5000
StackWithTextChildren mount 2621 2603 5000
SwatchColorPicker mount 6023 6048 5000
TagPicker mount 1496 1433 5000
Text mount 371 361 5000
TextField mount 941 928 5000
ThemeProvider mount 835 827 5000
ThemeProvider virtual-rerender 582 587 5000
ThemeProvider virtual-rerender-with-unmount 1281 1272 5000
Toggle mount 583 604 5000
buttonNative mount 186 197 5000

@bsunderhus bsunderhus merged commit 3f805b9 into microsoft:master Aug 31, 2023
@bsunderhus bsunderhus deleted the swc/feat--adds-swc-plugin-de-indent-template-literal branch August 31, 2023 14:06
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Sep 3, 2023
@marcosmoura
Merge branch 'master' into test/add-e2e-tests-for-drawer-base-components
b79b672 
* master:
  refactor(react-drawer): change DrawerHeaderTitle slot creation while keeping the same API (microsoft#29042)
  test(react-drawer): add render tests for drawer subcomponents (microsoft#29043)
  Grouped vertical bar chart - Component tests (microsoft#29031)
  docs: add Fluent UI Insights EP06 to README (microsoft#29051)
  chore: use swc-plugin-de-indent-template-literal for consoles (microsoft#29040)
  chore: adds swc-plugin-de-indent-template-literal (microsoft#29037)
  feat(react-jsx-runtime): v9 packages to use importSource (microsoft#28959)
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Sep 3, 2023
@marcosmoura
Merge branch 'master' into feat/drawer-motion
58b1e52 
* master: (32 commits)
  refactor(react-drawer): change DrawerHeaderTitle slot creation while keeping the same API (microsoft#29042)
  test(react-drawer): add render tests for drawer subcomponents (microsoft#29043)
  Grouped vertical bar chart - Component tests (microsoft#29031)
  docs: add Fluent UI Insights EP06 to README (microsoft#29051)
  chore: use swc-plugin-de-indent-template-literal for consoles (microsoft#29040)
  chore: adds swc-plugin-de-indent-template-literal (microsoft#29037)
  feat(react-jsx-runtime): v9 packages to use importSource (microsoft#28959)
  chore: update swc build dependencies (microsoft#28989)
  fix(react-tags-preview): add hover/pressed style for windows high contrast (microsoft#29035)
  chore(react-tags-preview): use InteractionTag for TagGroup's stories (microsoft#29024)
  chore(react-tags-preview): use makeResetStyles for base styles (microsoft#29022)
  chore: fix codesandbox export for preview component by making @fluentui/react-components required dependency (microsoft#29016)
  applying package updates
  feat(react-motion): create useReducedMotion and apply to useMotion to skip animations (microsoft#29014)
  ReAdd: Keytips: Align keytipData with visible instance for dupes (microsoft#28992)
  feat(react-drawer): add motion to Drawer (microsoft#28999)
  fix(react-utilities): avoid calling requestAnimationFrame when in SSR (microsoft#29015)
  fix(ssr-tests-v9): use correct path for ssr-tests-v9 stories (microsoft#29025)
  chore: updates devcontainer to use v16-bookworm image (microsoft#28997)
  feat(docsite): add Application Insights telemetry (microsoft#28709)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tudorpopams tudorpopams tudorpopams approved these changes

Assignees

@bsunderhus bsunderhus

Labels

None yet

Projects

None yet

Milestone

August Project Cycle Q4 2023

Development

Successfully merging this pull request may close these issues.

3 participants

@bsunderhus @fabricteam @tudorpopams